Skip to content

Performance issue on padding function #12

@panesher

Description

@panesher

Recently i discovered that jTransUP paddingItems function has performance issue in mine project at evaluating stage: we should iterate through whole range of items in loop however it could be done with LongTensor without iterating at all if i_map, new_map containing whole range of items without spaces.

In my case there is some difference in function. However, fixing such small thing reduce time for evaluating from 15 minutes to 20 seconds. My padding function.

Also there is TODO to simplify init stage, which possibly can be fixed with my initialisation function for embedding.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions