Per-room order select and set_segment_order are a silent no-op on v2 maps

[ceandraka]

Device: L10s Ultra Gen 2 (vacuum.l10s_ultra_gen_2), firmware 1156+, customized cleaning enabled, v2 (multi-map) map

Summary: Setting any per-room order select (dropdown or select_select_next/select_select_previous) does nothing. Root cause is DreameMapVacuumMapEditor.set_segment_order (dreame/map.py:2798): it mutates self._map_data segment orders, then re-normalizes every segment against self.map_manager.cleaning_sequence, which for v2 maps derives from selected_map → _saved_map_data (map.py:1881-1895), not the just-mutated live map. The mutation is clobbered and the unchanged sequence is written back. Confirmed via device log: repeated identical UPDATE_MAP_DATA {"cleanareaorder":[...]} writes, select state never changes.

Working path for comparison: set_cleaning_sequence (map.py:2743) operates on _saved_map_data directly (map.py:2748) and works correctly.

Suggested fix: make set_segment_order operate on _saved_map_data for v2 maps the way set_cleaning_sequence does (or re-normalize against the mutated map), then sync the live map.

[Tasshack]

Are you on v2.0.0b25?

[ceandraka]

Yes. I am sorry, I should have put that. I had to go to the V2 beta to get the Dreame login to work.

[Tasshack]

This should fix the issue;

  def set_segment_order(self, segment_id: int, order: int) -> list[int] | None:
      if order is None or (isinstance(order, str) and not order.isnumeric()):
          order = 0
      map_data = self._map_data
      if map_data and map_data.segments and segment_id in map_data.segments and not map_data.temporary_map:
          if map_data.version > 1:
              map_data = self._saved_map_data[map_data.saved_map_id]

          if not order and map_data.version > 1:
              order = max([v.order for v in map_data.segments.values() if v.order]) + 1

          if order > 0:
              current_order = map_data.segments[segment_id].order
              if current_order != order:
                  map_data.segments[segment_id].order = order
                  if map_data.version < 2:
                      map_data.cleanset[str(segment_id)][3] = order
                  for k, v in map_data.segments.items():
                      if k != segment_id and v.order == order:
                          map_data.segments[k].order = (
                              (len(self.map_manager.cleaning_sequence) + 1) if not current_order else current_order
                          )
          else:
              map_data.segments[segment_id].order = 0

          index = 1
          for k in self.map_manager.cleaning_sequence:
              if map_data.segments[k].order or map_data.version > 1:
                  map_data.segments[k].order = index
                  if map_data.version < 2:
                      map_data.cleanset[str(k)][3] = index
                  index = index + 1
              else:
                  map_data.cleanset[str(k)][3] = 0

          if map_data.version > 1:
              map_data.cleaning_sequence = {
                  str(k): map_data.segments[k].order
                  for k in sorted(map_data.segments.keys(), key=lambda k: map_data.segments[k].id)
              }

              self._map_data.cleaning_sequence = map_data.cleaning_sequence.copy()
              for k, v in map_data.segments.items():
                  if k in self._map_data.segments:
                      self._map_data.segments[k].order = v.order
              self.refresh_map(self._map_data.saved_map_id)

          if (
              self._saved_map_data
              and self._selected_map_id is not None
              and self._selected_map_id in self._saved_map_data
          ):
              if map_data.version > 1:
                  self._saved_map_data[self._selected_map_id].cleaning_sequence = map_data.cleaning_sequence.copy()
              else:
                  self._saved_map_data[self._selected_map_id].cleanset = copy.deepcopy(map_data.cleanset)

          self._set_updated_frame_id(map_data.frame_id)
          self.refresh_map()

          return self.map_manager.cleaning_sequence

[ceandraka]

Thanks for the fix — that addresses exactly what I saw. The issue was that the order mutations were being applied to the live _map_data, but the cleaning_sequence property reads from the saved map, so the changes never surfaced. Switching to _saved_map_data[map_data.saved_map_id] first (mirroring set_cleaning_sequence) makes sense and should resolve the no-op.

One minor observation on the change: the self._saved_map_data[map_data.saved_map_id] access is unguarded. In practice the saved map should always exist when version > 1 (the selected_map property resolves the same way), so I don't expect it to be a problem — just flagging it in case you'd prefer a .get() fallback there.

I'll test once it's in a release and confirm the per-room order select updates correctly. Thanks again!

[Tasshack]

One minor observation on the change: the self._saved_map_data[map_data.saved_map_id] access is unguarded. In practice the saved map should always exist when version > 1 (the selected_map property resolves the same way), so I don't expect it to be a problem — just flagging it in case you'd prefer a .get() fallback there.

I will address this as well..
Thanks