chore!: save IO config as byte array instead of list

it inscrutably gets converted into a byte array when serialized to an item, so might as well use a byte array from the start

Author: marcus8448

src/main/java/dev/galacticraft/machinelib/api/block/entity/ConfiguredBlockEntity.java

@@ -36,6 +36,7 @@
 import net.fabricmc.fabric.api.blockview.v2.RenderDataBlockEntity;
 import net.minecraft.core.BlockPos;
 import net.minecraft.core.HolderLookup;
+import net.minecraft.nbt.ByteArrayTag;
 import net.minecraft.nbt.ByteTag;
 import net.minecraft.nbt.CompoundTag;
 import net.minecraft.nbt.Tag;
@@ -281,8 +282,8 @@ protected void saveAdditional(CompoundTag tag, HolderLookup.Provider lookup) {
     @Override
     public void loadAdditional(CompoundTag tag, HolderLookup.Provider lookup) {
         super.loadAdditional(tag, lookup);
-        if (tag.contains(Constant.Nbt.CONFIGURATION, Tag.TAG_LIST))
-            this.configuration.readTag(tag.getList(Constant.Nbt.CONFIGURATION, Tag.TAG_BYTE));
+        if (tag.contains(Constant.Nbt.CONFIGURATION, Tag.TAG_BYTE_ARRAY))
+            this.configuration.readTag(new ByteArrayTag(tag.getByteArray(Constant.Nbt.CONFIGURATION)));
         if (tag.contains(Constant.Nbt.SECURITY, Tag.TAG_COMPOUND))
             this.security.readTag(tag.getCompound(Constant.Nbt.SECURITY));
         if (tag.contains(Constant.Nbt.REDSTONE_MODE, Tag.TAG_BYTE))

src/main/java/dev/galacticraft/machinelib/api/machine/configuration/IOConfig.java

@@ -30,16 +30,14 @@
 import dev.galacticraft.machinelib.api.transfer.ResourceType;
 import dev.galacticraft.machinelib.api.util.BlockFace;
 import io.netty.buffer.ByteBuf;
-import net.minecraft.nbt.ByteTag;
-import net.minecraft.nbt.ListTag;
-import net.minecraft.nbt.Tag;
+import net.minecraft.nbt.ByteArrayTag;
 import net.minecraft.network.codec.StreamCodec;
 import org.jetbrains.annotations.NotNull;
 
 /**
  * Stores the configuration of a machine's I/O for all six faces.
  */
-public final class IOConfig implements Serializable<ListTag>, MachineRenderData, DeltaPacketSerializable<ByteBuf, IOConfig> {
+public final class IOConfig implements Serializable<ByteArrayTag>, MachineRenderData, DeltaPacketSerializable<ByteBuf, IOConfig> {
     public static final StreamCodec<ByteBuf, IOConfig> CODEC = PacketSerializable.createCodec(IOConfig::new);
 
     /**
@@ -78,19 +76,19 @@ public IOFace get(@NotNull BlockFace face) {
     }
 
     @Override
-    public @NotNull ListTag createTag() {
-        ListTag nbt = new ListTag();
-        for (IOFace face : this.faces) {
-            nbt.add(face.createTag());
+    public @NotNull ByteArrayTag createTag() {
+        ByteArrayTag nbt = new ByteArrayTag(new byte[6]);
+        for (int i = 0; i < this.faces.length; i++) {
+            nbt.set(i, this.faces[i].createTag());
         }
         return nbt;
     }
 
     @Override
-    public void readTag(@NotNull ListTag tag) {
-        if (tag.getElementType() == Tag.TAG_BYTE) {
+    public void readTag(@NotNull ByteArrayTag tag) {
+        if (tag.size() == 6) {
             for (int i = 0; i < tag.size(); i++) {
-                this.faces[i].readTag((ByteTag) tag.get(i));
+                this.faces[i].readTag(tag.get(i));
             }
         } else {
             for (IOFace face : faces) {

src/main/java/dev/galacticraft/machinelib/client/impl/model/MachineBakedModel.java

@@ -47,6 +47,7 @@
 import net.minecraft.core.BlockPos;
 import net.minecraft.core.Direction;
 import net.minecraft.core.component.DataComponents;
+import net.minecraft.nbt.ByteArrayTag;
 import net.minecraft.nbt.Tag;
 import net.minecraft.util.RandomSource;
 import net.minecraft.world.item.BlockItem;
@@ -194,9 +195,9 @@ public void emitItemQuads(ItemStack stack, Supplier<RandomSource> randomSupplier
         CustomData customData = stack.getOrDefault(DataComponents.BLOCK_ENTITY_DATA, CustomData.EMPTY);
 
         IOConfig config;
-        if (!customData.isEmpty() && customData.contains(Constant.Nbt.CONFIGURATION)) {
+        if (!customData.isEmpty() && customData.getUnsafe().contains(Constant.Nbt.CONFIGURATION, Tag.TAG_BYTE_ARRAY)) {
             config = new IOConfig();
-            config.readTag(customData.getUnsafe().getList(Constant.Nbt.CONFIGURATION, Tag.TAG_BYTE));
+            config.readTag(new ByteArrayTag(customData.getUnsafe().getByteArray(Constant.Nbt.CONFIGURATION)));
         } else {
             config = null;
         }

src/test/java/dev/galacticraft/machinelib/test/misc/EmptyDeserializationTest.java

@@ -24,8 +24,8 @@
 
 import dev.galacticraft.machinelib.api.machine.configuration.IOConfig;
 import dev.galacticraft.machinelib.api.machine.configuration.SecuritySettings;
+import net.minecraft.nbt.ByteArrayTag;
 import net.minecraft.nbt.CompoundTag;
-import net.minecraft.nbt.ListTag;
 import org.junit.jupiter.api.Assertions;
 import org.junit.jupiter.api.Test;
 
@@ -39,6 +39,6 @@ public void securitySettings() {
     @Test
     public void ioConfiguration() {
         IOConfig ioConfig = new IOConfig();
-        Assertions.assertDoesNotThrow(() -> ioConfig.readTag(new ListTag()));
+        Assertions.assertDoesNotThrow(() -> ioConfig.readTag(new ByteArrayTag(new byte[6])));
     }
 }