Migrate playlist fragment to Jetpack Compose #11259
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Isira-Seneviratne
force-pushed
the
Playlist-Compose
branch
4 times, most recently
from
64bdabb to
b6751c2
Compare
Isira-Seneviratne
force-pushed
the
Playlist-Compose
branch
5 times, most recently
from
d9a06a8 to
8049fa5
Compare
This comment was marked as outdated.
This comment was marked as outdated.
5 tasks
# Conflicts: # app/build.gradle # app/src/main/java/org/schabi/newpipe/MainActivity.java # app/src/main/java/org/schabi/newpipe/error/ReCaptchaActivity.java # app/src/main/java/org/schabi/newpipe/fragments/detail/VideoDetailFragment.java # app/src/main/java/org/schabi/newpipe/fragments/list/comments/CommentsFragment.kt # app/src/main/java/org/schabi/newpipe/fragments/list/playlist/PlaylistFragment.java # app/src/main/java/org/schabi/newpipe/ktx/Bundle.kt # app/src/main/java/org/schabi/newpipe/local/bookmark/BookmarkFragment.java # app/src/main/java/org/schabi/newpipe/paging/CommentsSource.kt # app/src/main/java/org/schabi/newpipe/ui/components/common/DescriptionText.kt # app/src/main/java/org/schabi/newpipe/ui/components/common/LoadingIndicator.kt # app/src/main/java/org/schabi/newpipe/viewmodels/CommentsViewModel.kt # build.gradle
|
There was a problem hiding this comment.
Copilot reviewed 19 out of 32 changed files in this pull request and generated no comments.
Files not reviewed (13)
- app/build.gradle: Language not supported
- app/src/androidTest/java/org/schabi/newpipe/database/DatabaseMigrationTest.kt: Language not supported
- app/src/main/java/org/schabi/newpipe/database/playlist/dao/PlaylistRemoteDAO.kt: Language not supported
- app/src/main/java/org/schabi/newpipe/fragments/list/playlist/PlaylistFragment.kt: Language not supported
- app/src/main/java/org/schabi/newpipe/local/playlist/RemotePlaylistManager.kt: Language not supported
- app/src/main/java/org/schabi/newpipe/paging/PlaylistItemsSource.kt: Language not supported
- app/src/main/java/org/schabi/newpipe/ui/components/comment/Comment.kt: Language not supported
- app/src/main/java/org/schabi/newpipe/ui/components/comment/CommentRepliesHeader.kt: Language not supported
- app/src/main/java/org/schabi/newpipe/ui/components/comment/CommentSection.kt: Language not supported
- app/src/main/java/org/schabi/newpipe/ui/components/common/DescriptionText.kt: Language not supported
- app/src/main/java/org/schabi/newpipe/ui/components/common/IconButtonWithLabel.kt: Language not supported
- app/src/main/java/org/schabi/newpipe/ui/components/common/PlaybackControlButtons.kt: Language not supported
- app/src/main/java/org/schabi/newpipe/ui/components/items/ItemList.kt: Language not supported
Comments suppressed due to low confidence (4)
app/src/main/java/org/schabi/newpipe/settings/tabs/Tab.java:608
- Ensure that the target Java version supports pattern matching for instanceof to avoid compilation issues.
if (!(obj instanceof PlaylistTab other)) {
app/src/main/java/org/schabi/newpipe/fragments/list/channel/ChannelFragment.java:195
- Verify that the MenuProvider is automatically removed when using a lifecycle owner; if not, consider reinstituting a manual removal in onDestroy().
activity.addMenuProvider(menuProvider, getViewLifecycleOwner());
app/src/main/java/org/schabi/newpipe/database/playlist/model/PlaylistRemoteEntity.java:84
- Confirm that PlaylistScreenInfo supplies all the required fields formerly provided by PlaylistInfo, and update any relevant documentation if necessary.
public PlaylistRemoteEntity(final PlaylistScreenInfo info) {
app/src/main/java/org/schabi/newpipe/database/playlist/dao/PlaylistRemoteDAO.java:1
- Ensure that removal of the PlaylistRemoteDAO file is intentional and that all references to this DAO have been removed or migrated.
package org.schabi.newpipe.database.playlist.dao;
# Conflicts: # app/src/main/java/org/schabi/newpipe/database/playlist/dao/PlaylistRemoteDAO.java # app/src/main/java/org/schabi/newpipe/database/playlist/model/PlaylistRemoteEntity.java # app/src/main/java/org/schabi/newpipe/fragments/list/channel/ChannelFragment.java # app/src/main/java/org/schabi/newpipe/local/playlist/RemotePlaylistManager.java
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is it?
Description of the changes in your PR
Before/After Screenshots/Screen Record
Screen_recording_20240710_085704.mp4
Fixes the following issue(s)
Relies on the following changes
APK testing
The APK can be found by going to the "Checks" tab below the title. On the left pane, click on "CI", scroll down to "artifacts" and click "app" to download the zip file which contains the debug APK of this PR. You can find more info and a video demonstration on this wiki page.
Due diligence