Update rules to allow without embedding

Author: frysch

lib/rubocop/cop/teamtailor/no_embeddings_in_active_model_serializer.rb

@@ -10,15 +10,28 @@ class NoEmbeddingsInActiveModelSerializer < Base
           (send nil? {:has_many | :has_one} ...)
         PATTERN
 
+        def_node_matcher :no_embed?, <<~PATTERN
+          (sym {:embed | :embed_in_root})
+        PATTERN
+
         def on_class(class_node)
           return unless class_node.defined_module_name.end_with?("Serializer")
           check_children(class_node)
         end
 
         private
 
+        def is_embedding?(node)
+          return true if no_embed?(node)
+
+          if node.respond_to?(:children)
+            return node.children.any? { |child| is_embedding?(child) }
+          end
+          false
+        end
+
         def check_children(node)
-          if no_has_many?(node)
+          if no_has_many?(node) && is_embedding?(node)
             add_offense(node)
           end
 

spec/rubocop/cop/teamtailor/no_embeddings_in_active_model_serializer_spec.rb

@@ -4,7 +4,7 @@
   let(:config) { RuboCop::Config.new }
 
   context "when in a serializer" do
-    it "registers an offense when using `has_many`" do
+    it "registers an offense when using `has_many` with embed" do
       expect_offense(<<~RUBY)
         class FooSerializer < ActiveModel::Serializer
           has_many :locations, embed: :ids
@@ -13,7 +13,16 @@ class FooSerializer < ActiveModel::Serializer
       RUBY
     end
 
-    it "registers an offense when using `has_one`" do
+    it "registers an offense when using `has_many` with embed_in_root" do
+      expect_offense(<<~RUBY)
+        class FooSerializer < ActiveModel::Serializer
+          has_many :locations, embed_in_root: true
+          ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ Teamtailor/NoEmbeddingsInActiveModelSerializer: No embedding of records
+        end
+      RUBY
+    end
+
+    it "registers an offense when using `has_one` with embed_in_root" do
       expect_offense(<<~RUBY)
         class FooSerializer < ActiveModel::Serializer
           has_one :location, embed_in_root: true
@@ -22,6 +31,15 @@ class FooSerializer < ActiveModel::Serializer
       RUBY
     end
 
+    it "registers an offense when using `has_one` with embed" do
+      expect_offense(<<~RUBY)
+        class FooSerializer < ActiveModel::Serializer
+          has_one :location, embed: :ids
+          ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ Teamtailor/NoEmbeddingsInActiveModelSerializer: No embedding of records
+        end
+      RUBY
+    end
+
     it "registers offenses for all `has_many`" do
       expect_offense(<<~RUBY)
         class FooSerializer < ActiveModel::Serializer
@@ -33,7 +51,7 @@ class FooSerializer < ActiveModel::Serializer
       RUBY
     end
 
-    it "registers offenses for both `has_many` and `has_one`" do
+    it "registers offenses for both `has_many` and `has_one` with embed" do
       expect_offense(<<~RUBY)
         class FooSerializer < ActiveModel::Serializer
           has_many :locations, embed: :ids
@@ -51,6 +69,15 @@ class FooSerializer < ActiveModel::Serializer
         end
       RUBY
     end
+
+    it "does not register an offence when no has_one/has_many without embedding" do
+      expect_no_offenses(<<~RUBY)
+        class FooSerializer < OjSerializer
+          has_many :locations, serializer: LocationSerializer
+          has_one :candidate, serializer: CandidateSerializer
+        end
+      RUBY
+    end
   end
 
   context "when not in a serializer" do