Empty filters raises ArgumentError (#4)

Closes #3

Author: Da9elKH

CHANGELOG.md

@@ -1,6 +1,7 @@
 ## Unreleased
 - Added `Client#create_candidate`
 - Added `Client#create_job_application`
+- Fix accessing `Client#jobs` without filters
 
 ## v0.3.2 - 2021-02-03
 

lib/teamtailor/client.rb

@@ -54,9 +54,7 @@ def create_candidate(attributes:, relationships:)
     end
 
     def jobs(page: 1, include: [], filters: {})
-      filter_params = filters.keys.map do |key|
-        { "filter[#{key}]" => filters[key] }
-      end
+      filter_params = filters.transform_keys { |key| "filter[#{key}]" }
 
       Teamtailor::Request.new(
         base_url: base_url,
@@ -67,7 +65,7 @@ def jobs(page: 1, include: [], filters: {})
           "page[number]" => page,
           "page[size]" => 30,
           "include" => include.join(","),
-        }.merge(*filter_params)
+        }.merge(filter_params)
       ).call
     end
 

spec/teamtailor/client_spec.rb

@@ -28,5 +28,27 @@
         }
       end
     end
+
+    context "passing request without filters" do
+      it "passes an empty filter list along in the request" do
+        client = Teamtailor::Client.new(
+            base_url: "http://api.teamtailor.localhost",
+            api_token: "foobar",
+            api_version: "123",
+          )
+
+        stub_request(:get, "http://api.teamtailor.localhost/v1/jobs")
+            .with(
+                query: {
+                    'page[number]': 1,
+                    'page[size]': 30,
+                    'include': "",
+                }
+            )
+            .to_return(status: 200, body: {}.to_json)
+
+        client.jobs
+      end
+    end
   end
 end