test(api): add dry-run coverage to smoke evaluator path (#24)

Adds generic dry-run coverage to the smoke test path, ensuring that the
/launch/dry-run endpoint contract and stable response fields are exercised.
Includes a new example curl script and Makefile target for local testing.

Author: InderdeepBajwa

Makefile

@@ -1,4 +1,4 @@
-.PHONY: help build build-agent build-control-plane test test-agent test-control-plane fmt lint doctor dev-preflight dev-up dev-down demo dev-db-reset example-intake example-schedule example-launch-validate example-launch-execute example-readiness example-orphans
+.PHONY: help build build-agent build-control-plane test test-agent test-control-plane fmt lint doctor dev-preflight dev-up dev-down demo dev-db-reset example-intake example-schedule example-launch-validate example-launch-dry-run example-launch-execute example-readiness example-orphans
 
 # Configuration
 BIN_DIR=bin
@@ -72,6 +72,9 @@ example-schedule: ## Run a workload eligibility evaluation explanation
 example-launch-validate: ## Validate a launch without executing it
 	@bash examples/curls/launch-validate.sh
 
+example-launch-dry-run: ## Dry-run a launch without executing it
+	@bash examples/curls/launch-dry-run.sh
+
 example-launch-execute: ## Execute a launch on a local runtime
 	@bash examples/curls/launch-execute.sh
 

examples/curls/launch-dry-run.sh

@@ -0,0 +1,29 @@
+#!/usr/bin/env bash
+set -euo pipefail
+
+API_BASE="${API_BASE:-http://127.0.0.1:9090}"
+PAYLOAD_FILE="/tmp/payload.json"
+SPEC_FILE="examples/launch-specs/cloudhypervisor-validate.json"
+
+if [ ! -f "$PAYLOAD_FILE" ]; then
+    echo "Error: /tmp/payload.json is missing. Please run 'make example-intake' first to ingest a node."
+    exit 1
+fi
+
+NODE_ID=$(grep -o '"hostname": *"[^"]*"' "$PAYLOAD_FILE" | cut -d'"' -f4 | head -n 1)
+if [ -z "$NODE_ID" ]; then
+    NODE_ID="unknown"
+fi
+
+TMP_SPEC=$(mktemp)
+trap 'rm -f "$TMP_SPEC"' EXIT
+
+# Safely replace PUT_NODE_ID_HERE with the dynamic NODE_ID and override launch_mode to DryRun
+if command -v python3 >/dev/null 2>&1; then
+    python3 -c "import json, sys; d = json.load(sys.stdin); d['node_id'] = '${NODE_ID}'; d['launch_mode'] = 'DryRun'; json.dump(d, sys.stdout)" < "$SPEC_FILE" > "$TMP_SPEC"
+    curl -s -X POST -H "Content-Type: application/json" -d @"$TMP_SPEC" "${API_BASE}/api/v1alpha1/launch/dry-run" | python3 -m json.tool || true
+else
+    sed "s/PUT_NODE_ID_HERE/${NODE_ID}/g" "$SPEC_FILE" | sed 's/"launch_mode": "Validate"/"launch_mode": "DryRun"/g' > "$TMP_SPEC"
+    curl -s -X POST -H "Content-Type: application/json" -d @"$TMP_SPEC" "${API_BASE}/api/v1alpha1/launch/dry-run"
+    echo ""
+fi

scripts/smoke-test.sh

@@ -109,6 +109,40 @@ fi
 python3 -m json.tool < "$VALIDATE_RESP" > /dev/null
 echo "Launch Validate API success. (is_valid status not asserted for generic CI environments)"
 
+echo "--------------------------------------------"
+echo "5. Launch Dry-Run (POST /api/v1alpha1/launch/dry-run)..."
+LAUNCH_SPEC_DRYRUN="examples/launch-specs/cloudhypervisor-validate.json"
+TMP_SPEC_DRYRUN="$TMP_DIR/launch_spec_dryrun.json"
+DRYRUN_RESP="$TMP_DIR/dryrun_resp.json"
+
+# Safely inject node_id and override launch_mode
+python3 -c "import json, sys; d = json.load(sys.stdin); d['node_id'] = '${NODE_ID}'; d['launch_mode'] = 'DryRun'; json.dump(d, sys.stdout)" < "$LAUNCH_SPEC_DRYRUN" > "$TMP_SPEC_DRYRUN"
+
+HTTP_CODE=$(curl -s -w "%{http_code}" -X POST -H "Content-Type: application/json" -d @"$TMP_SPEC_DRYRUN" "${API_BASE}/api/v1alpha1/launch/dry-run" -o "$DRYRUN_RESP")
+
+if [ "$HTTP_CODE" -ne 200 ]; then
+    echo "Error: Launch Dry-Run API failed with HTTP $HTTP_CODE"
+    cat "$DRYRUN_RESP"
+    exit 1
+fi
+python3 -m json.tool < "$DRYRUN_RESP" > /dev/null
+
+# Assert stable fields exist in response regardless of actual is_valid boolean status
+python3 -c "import json, sys
+try:
+    d = json.load(open('$DRYRUN_RESP'))
+    assert 'validation' in d, 'missing validation object'
+    v = d['validation']
+    assert 'is_valid' in v, 'missing is_valid'
+    if not v['is_valid']:
+        assert 'rejected_backends' in v or 'backend_rejection_evidence' in v, 'missing rejection evidence'
+except Exception as e:
+    print(f'Assertion Error: {e}')
+    sys.exit(1)
+" || { echo "Error: Launch Dry-Run assertions failed"; cat "$DRYRUN_RESP"; exit 1; }
+
+echo "Launch Dry-Run API success. (is_valid status not asserted for generic CI environments)"
+
 echo "--------------------------------------------"
 echo "Smoke test completed successfully."
 exit 0