Skip to content

[Issue 567] Eligibility Check + Conditional Structuring#869

Draft
daaimah123 wants to merge 21 commits into
mvpfrom
mvp-issue-567
Draft

[Issue 567] Eligibility Check + Conditional Structuring#869
daaimah123 wants to merge 21 commits into
mvpfrom
mvp-issue-567

Conversation

@daaimah123
Copy link
Copy Markdown
Collaborator

@daaimah123 daaimah123 commented Dec 14, 2025

Continued work from @kabugatti addressing #567.

✅ Changes from previous work in PR #860:

  1. Style Duplication: form.html had inline styles that should be in forms.scss
  2. Selector Specificity Conflicts: .application-form .learn-more-wrapper only worked when wrapped in <form class="application-form">, causing Step 1 to fail initially
  3. Line Breaking Behavior: display: inline on .learn-more-wrapper caused content to jump to new line when expanded
  4. Shared Stylesheet Impact: Any changes to forms.scss would affect ALL mvp pages using it, not just form.html
  5. Missing Responsive Overrides: No .form-step padding rules in mobile media queries
  6. Learn-More Enhancement
    • Changed .learn-more-wrapper from display: inline to display: inline-block with vertical-align: top
    • Prevents line breaking when content expands
    • Maintains inline flow while supporting block-level children
  7. Wrapped Step 1: content in <form class="application-form"> to match Step 2+ structure, for .application-form selector consistency

⚠️ Remaining Issues

  1. Fieldset border removed on small breakpoints only (recommended investigation of form border + .application-form > fieldset border)
  2. Non-app-form pages seem to have strange container issue (width/padding) with fieldset at <360px likely a result of these changes
  3. This form is the only page in mvp with form-step

Step 1

gif app-form page

Step 2

gif app-form page2

@daaimah123 daaimah123 linked an issue Dec 14, 2025 that may be closed by this pull request
@daaimah123 daaimah123 changed the title Mvp issue 567 [Issue 567] Eligibility Check + Conditional Structuring Dec 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Handle Form Structuring & Conditionals

2 participants