Commit b636075
committed
fix(fixtures): skip getfqdn (fixes macOS CI hang)
host_guard::run_allows_loopback_when_escape_hatch_set timed out
~30s on macOS CI only. Root cause: Python stdlib
http.server.HTTPServer.server_bind() calls socket.getfqdn(host), a
reverse-DNS lookup that blocks on macOS GitHub runners. It is the
sole fresh consumer of mock-http-server.py (http_transport uses
httpmock; this fixture isn't otherwise spawned), so only this test
hit it; bumping the test timeout could not help (hang >= the DNS
timeout).
Fix at the root in both HTTP/SSE fixtures: a _Server subclass binds
via socketserver.TCPServer.server_bind (no getfqdn) and sets
server_name/port directly, so LISTENING is emitted immediately on
every platform. mock-sse-server.py shares the identical latent bug
(not yet triggered) — fixed preventively for consistency.
Local: ci-checks.sh green; 16/16 host_guard/http/sse tests pass;
LISTENING smoke immediate. macOS reverse-DNS path is removed
entirely, not merely given more time.1 parent 4ed745e commit b636075
2 files changed
Lines changed: 39 additions & 6 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
12 | 12 | | |
13 | 13 | | |
14 | 14 | | |
| 15 | + | |
15 | 16 | | |
16 | 17 | | |
17 | 18 | | |
| |||
93 | 94 | | |
94 | 95 | | |
95 | 96 | | |
| 97 | + | |
| 98 | + | |
| 99 | + | |
| 100 | + | |
| 101 | + | |
| 102 | + | |
| 103 | + | |
| 104 | + | |
| 105 | + | |
| 106 | + | |
| 107 | + | |
| 108 | + | |
| 109 | + | |
| 110 | + | |
| 111 | + | |
96 | 112 | | |
97 | 113 | | |
98 | 114 | | |
99 | 115 | | |
100 | 116 | | |
101 | 117 | | |
102 | | - | |
| 118 | + | |
103 | 119 | | |
104 | 120 | | |
105 | 121 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
20 | 20 | | |
21 | 21 | | |
22 | 22 | | |
| 23 | + | |
23 | 24 | | |
24 | 25 | | |
25 | 26 | | |
| |||
102 | 103 | | |
103 | 104 | | |
104 | 105 | | |
105 | | - | |
| 106 | + | |
| 107 | + | |
| 108 | + | |
| 109 | + | |
106 | 110 | | |
107 | 111 | | |
108 | 112 | | |
| |||
128 | 132 | | |
129 | 133 | | |
130 | 134 | | |
131 | | - | |
132 | | - | |
133 | | - | |
| 135 | + | |
134 | 136 | | |
135 | 137 | | |
136 | 138 | | |
| |||
165 | 167 | | |
166 | 168 | | |
167 | 169 | | |
| 170 | + | |
| 171 | + | |
| 172 | + | |
| 173 | + | |
| 174 | + | |
| 175 | + | |
| 176 | + | |
| 177 | + | |
| 178 | + | |
| 179 | + | |
| 180 | + | |
| 181 | + | |
| 182 | + | |
| 183 | + | |
| 184 | + | |
168 | 185 | | |
169 | 186 | | |
170 | 187 | | |
171 | 188 | | |
172 | 189 | | |
173 | 190 | | |
174 | | - | |
| 191 | + | |
175 | 192 | | |
176 | 193 | | |
177 | 194 | | |
| |||
0 commit comments