Copy ctor, move ctor, <=> operator for datetime module.

Author: StefanoLusardiTC

sdk/include/teiacare/sdk/datetime/date.hpp

@@ -97,6 +97,16 @@ class date
     {
     }
 
+    /*!
+     * \brief Copy Constructor. Copy a tc::sdk::date instance to another one.
+     */
+    constexpr date(const date&) noexcept = default;
+
+    /*!
+     * \brief Move Constructor. Copy a tc::sdk::date instance to another one.
+     */
+    constexpr date(date&&) noexcept = default;
+
     /*!
      * \brief Assignment operator. Assign a tc::sdk::date instance to another one.
      */
@@ -171,24 +181,11 @@ class date
     }
 
     /*!
-     * \brief Equality operator.
-     * \param other the date to compare against.
-     * \return true if the two date objects are the same.
-     */
-    constexpr inline bool operator==(const date& other) const noexcept
-    {
-        return _ymd == other._ymd;
-    }
-
-    /*!
-     * \brief Inequality operator.
+     * \brief Spaceship operator.
      * \param other the date to compare against.
-     * \return true if the two date objects are the different.
+     * \return std::strong_ordering comparing two date objects.
      */
-    constexpr inline bool operator!=(const date& other) const noexcept
-    {
-        return !operator==(other);
-    }
+    constexpr auto operator<=>(const date& other) const noexcept = default;
 
     /*!
      * \brief Adds a time delta to the current date.
@@ -210,26 +207,6 @@ class date
         return tc::sdk::date{std::chrono::sys_days(_ymd) - delta.total_nanoseconds()};
     }
 
-    /*!
-     * \brief Checks if the current date is less than another date.
-     * \param other The date to compare against.
-     * \return true if the current date is less, false otherwise.
-     */
-    constexpr inline bool operator<(const date& other) const noexcept
-    {
-        return _ymd < other._ymd;
-    }
-
-    /*!
-     * \brief Checks if the current date is greater than another date.
-     * \param other The date to compare against.
-     * \return true if the current date is greater, false otherwise.
-     */
-    constexpr inline bool operator>(const date& other) const noexcept
-    {
-        return _ymd > other._ymd;
-    }
-
     /*!
      * \brief Calculates the time difference between two dates.
      * \param other The date to subtract from the current date.

sdk/include/teiacare/sdk/datetime/datetime.hpp

@@ -115,6 +115,16 @@ class datetime
     {
     }
 
+    /*!
+     * \brief Copy Constructor. Copy a tc::sdk::datetime instance to another one.
+     */
+    constexpr datetime(const datetime&) noexcept = default;
+
+    /*!
+     * \brief Move Constructor. Copy a tc::sdk::datetime instance to another one.
+     */
+    constexpr datetime(datetime&&) noexcept = default;
+
     /*!
      * \brief Assignment operator. Assign a tc::sdk::datetime instance to another one.
      */
@@ -166,24 +176,11 @@ class datetime
     }
 
     /*!
-     * \brief Equality operator.
-     * \param other the datetime to compare against.
-     * \return true if the two datetime objects are the same.
-     */
-    constexpr inline bool operator==(const datetime& other) const noexcept
-    {
-        return _tp == other._tp;
-    }
-
-    /*!
-     * \brief Inequality operator.
+     * \brief Spaceship operator.
      * \param other the datetime to compare against.
-     * \return true if the two datetime objects are the different.
+     * \return std::strong_ordering comparing two datetime objects.
      */
-    constexpr inline bool operator!=(const datetime& other) const noexcept
-    {
-        return !operator==(other);
-    }
+    constexpr auto operator<=>(const datetime& other) const noexcept = default;
 
     /*!
      * \brief Adds a timedelta to the current datetime.
@@ -205,26 +202,6 @@ class datetime
         return tc::sdk::datetime{_tp - delta.total_nanoseconds()};
     }
 
-    /*!
-     * \brief Checks if the current datetime is less than another datetime.
-     * \param other The datetime to compare against.
-     * \return true if the current datetime is less, false otherwise.
-     */
-    constexpr inline bool operator<(const datetime& other) const noexcept
-    {
-        return _tp < other._tp;
-    }
-
-    /*!
-     * \brief Checks if the current datetime is greater than another datetime.
-     * \param other The datetime to compare against.
-     * \return true if the current datetime is greater, false otherwise.
-     */
-    constexpr inline bool operator>(const datetime& other) const noexcept
-    {
-        return _tp > other._tp;
-    }
-
     /*!
      * \brief Calculates the time difference between two datetime objects.
      * \param other The datetime to subtract from the current datetime.

sdk/include/teiacare/sdk/datetime/time.hpp

@@ -59,6 +59,16 @@ class time
     {
     }
 
+    /*!
+     * \brief Copy Constructor. Copy a tc::sdk::time instance to another one.
+     */
+    constexpr time(const time&) noexcept = default;
+
+    /*!
+     * \brief Move Constructor. Copy a tc::sdk::time instance to another one.
+     */
+    constexpr time(time&&) noexcept = default;
+
     /*!
      * \brief Assignment operator. Assign a tc::sdk::time instance to another one.
      */
@@ -161,6 +171,16 @@ class time
         return !operator==(other);
     }
 
+    /*!
+     * \brief Spaceship operator.
+     * \param other the time to compare against.
+     * \return std::strong_ordering comparing two time objects.
+     */
+    constexpr auto operator<=>(const time& other) const noexcept
+    {
+        return _hh_mm_ss.to_duration() <=> other._hh_mm_ss.to_duration();
+    }
+
     /*!
      * \brief Adds a timedelta to the current time.
      * \param delta The tc::sdk::timedelta to add.
@@ -181,26 +201,6 @@ class time
         return tc::sdk::time{_hh_mm_ss.to_duration() - delta.total_nanoseconds()};
     }
 
-    /*!
-     * \brief Checks if the current time is less than another time.
-     * \param other The time to compare against.
-     * \return true if the current time is less, false otherwise.
-     */
-    constexpr inline bool operator<(const time& other) const noexcept
-    {
-        return _hh_mm_ss.to_duration() < other._hh_mm_ss.to_duration();
-    }
-
-    /*!
-     * \brief Checks if the current time is greater than another time.
-     * \param other The time to compare against.
-     * \return true if the current time is greater, false otherwise.
-     */
-    constexpr inline bool operator>(const time& other) const noexcept
-    {
-        return _hh_mm_ss.to_duration() > other._hh_mm_ss.to_duration();
-    }
-
     /*!
      * \brief Calculates the time difference between two time objects.
      * \param other The time to subtract from the current time.

sdk/include/teiacare/sdk/datetime/timedelta.hpp

@@ -72,6 +72,16 @@ class timedelta
     {
     }
 
+    /*!
+     * \brief Copy Constructor. Copy a tc::sdk::timedelta instance to another one.
+     */
+    constexpr timedelta(const timedelta&) noexcept = default;
+
+    /*!
+     * \brief Move Constructor. Copy a tc::sdk::timedelta instance to another one.
+     */
+    constexpr timedelta(timedelta&&) noexcept = default;
+
     /*!
      * \brief Assignment operator. Assign a tc::sdk::timedelta instance to another one.
      */
@@ -232,24 +242,11 @@ class timedelta
     }
 
     /*!
-     * \brief Equality operator.
-     * \param other the timedelta to compare against.
-     * \return true if the two timedelta objects are the same.
-     */
-    constexpr inline bool operator==(const timedelta& other) const noexcept
-    {
-        return _duration == other._duration;
-    }
-
-    /*!
-     * \brief Inequality operator.
+     * \brief Spaceship operator.
      * \param other the timedelta to compare against.
-     * \return true if the two timedelta objects are the different.
+     * \return std::strong_ordering comparing two timedelta objects.
      */
-    constexpr inline bool operator!=(const timedelta& other) const noexcept
-    {
-        return !operator==(other);
-    }
+    constexpr auto operator<=>(const timedelta& other) const noexcept = default;
 
     /*!
      * \brief Addition operator.

sdk/tests/src/test_datetime_date.cpp

@@ -226,12 +226,20 @@ TEST_F(test_datetime_date, operator_comparison)
     const auto d1 = tc::sdk::date(2024y, std::chrono::January, 1d);   // 2024 Jan 1st
     const auto d2 = tc::sdk::date(2023y, std::chrono::December, 31d); // 2023 Dec 31th
     const auto d3 = tc::sdk::date(2023y, std::chrono::December, 1d);  // 2023 Dec 1st
+    const auto d4 = tc::sdk::date(2023y, std::chrono::December, 1d);  // 2023 Dec 1st
 
     EXPECT_TRUE(d1 > d2);
     EXPECT_TRUE(d2 > d3);
+    EXPECT_TRUE(d1 >= d2);
+    EXPECT_TRUE(d2 >= d3);
 
     EXPECT_TRUE(d3 < d1);
     EXPECT_TRUE(d3 < d2);
+    EXPECT_TRUE(d3 <= d1);
+    EXPECT_TRUE(d3 <= d2);
+
+    EXPECT_TRUE(d3 <= d4);
+    EXPECT_TRUE(d3 >= d4);
 }
 
 TEST_F(test_datetime_date, ostream)

sdk/tests/src/test_datetime_datetime.cpp

@@ -180,6 +180,7 @@ TEST_F(test_datetime_datetime, operator_minus_timedelta)
     EXPECT_EQ(dt2 - delta, dt1);
     EXPECT_EQ(dt2, tc::sdk::datetime(2024y, std::chrono::May, 1d, 20h, 33min, 46s, 2ms) - delta);
 }
+
 TEST_F(test_datetime_datetime, operator_minus)
 {
     const auto dt1 = tc::sdk::datetime{tc::sdk::sys_time_point(1'714'588'424'000ms)}; // 01 May 2024 18:33:44.000 UTC
@@ -194,12 +195,20 @@ TEST_F(test_datetime_datetime, operator_comparison)
     const auto dt1 = tc::sdk::datetime(2024y, std::chrono::May, 1d, 18h, 33min, 44s, 555ms, 666us); // 01 May 2024 18:33:44.555666 UTC
     const auto dt2 = tc::sdk::datetime(2024y, std::chrono::May, 1d, 18h, 33min, 44s, 555ms);        // 01 May 2024 18:33:44.555000 UTC
     const auto dt3 = tc::sdk::datetime(2024y, std::chrono::May, 1d, 18h, 33min, 44s);               // 01 May 2024 18:33:44.000000 UTC
+    const auto dt4 = tc::sdk::datetime(2024y, std::chrono::May, 1d, 18h, 33min, 44s);               // 01 May 2024 18:33:44.000000 UTC
 
     EXPECT_TRUE(dt1 > dt2);
     EXPECT_TRUE(dt2 > dt3);
+    EXPECT_TRUE(dt1 >= dt2);
+    EXPECT_TRUE(dt2 >= dt3);
 
     EXPECT_TRUE(dt3 < dt1);
     EXPECT_TRUE(dt3 < dt2);
+    EXPECT_TRUE(dt3 <= dt1);
+    EXPECT_TRUE(dt3 <= dt2);
+
+    EXPECT_TRUE(dt3 <= dt4);
+    EXPECT_TRUE(dt3 >= dt4);
 }
 
 TEST_F(test_datetime_datetime, ostream)

sdk/tests/src/test_datetime_time.cpp

@@ -218,12 +218,20 @@ TEST_F(test_datetime_time, operator_comparison)
     const auto t1 = tc::sdk::time(3'662s);               // 01:01:02
     const auto t2 = tc::sdk::time(1h, 1min, 1s);         // 01:01:01
     const auto t3 = tc::sdk::time(std::chrono::days(1)); // 00:00:00
+    const auto t4 = tc::sdk::time(std::chrono::days(1)); // 00:00:00
 
     EXPECT_TRUE(t1 > t2);
     EXPECT_TRUE(t2 > t3);
+    EXPECT_TRUE(t1 >= t2);
+    EXPECT_TRUE(t2 >= t3);
 
     EXPECT_TRUE(t3 < t1);
     EXPECT_TRUE(t3 < t2);
+    EXPECT_TRUE(t3 <= t1);
+    EXPECT_TRUE(t3 <= t2);
+
+    EXPECT_TRUE(t3 <= t4);
+    EXPECT_TRUE(t3 >= t4);
 }
 
 TEST_F(test_datetime_time, ostream)

sdk/tests/src/test_datetime_timedelta.cpp

@@ -156,6 +156,25 @@ TEST_F(test_datetime_timedelta, operator_div)
     EXPECT_EQ(t1 / divider, t3);
 }
 
+TEST_F(test_datetime_timedelta, operator_comparison)
+{
+    const auto t1 = tc::sdk::timedelta(1h);
+    const auto t2 = tc::sdk::timedelta(12min);
+    const auto t3 = tc::sdk::timedelta(720'000ms);
+    const auto t4 = tc::sdk::timedelta(720s);
+
+    EXPECT_TRUE(t1 > t2);
+    EXPECT_TRUE(t1 >= t2);
+    EXPECT_TRUE(t2 >= t3);
+
+    EXPECT_TRUE(t3 < t1);
+    EXPECT_TRUE(t3 <= t1);
+    EXPECT_TRUE(t3 <= t2);
+
+    EXPECT_TRUE(t3 <= t4);
+    EXPECT_TRUE(t3 >= t4);
+}
+
 TEST_F(test_datetime_timedelta, ostream)
 {
     {