Merge pull request #1513 from Tinyblargon/qemu-power-state

Tinyblargon · web-flow · commit a084896992a7 · 2026-04-23T22:38:05.000+02:00
Feat: Qemu power state
diff --git a/docs/examples/pxe_example.tf b/docs/examples/pxe_example.tf
@@ -37,7 +37,7 @@ resource "proxmox_vm_qemu" "pxe-example" {
     kvm                       = true
     memory                    = 2048
     onboot                    = false
-    vm_state                  = "running"
+    power_state               = "running"
     os_type                   = "Linux 5.x - 2.6 Kernel"
     qemu_os                   = "l26"
     scsihw                    = "virtio-scsi-pci"
diff --git a/docs/resources/vm_qemu.md b/docs/resources/vm_qemu.md
@@ -101,8 +101,7 @@ The following arguments are supported in the top level resource block.
 | `efidisk`                     | `nested` |                      | The configuration for the EFI disk, see [EFI Disk Block](#efi-disk-block) section.|
 | `start_at_node_boot`          | `bool`   | `false`              | Whether the guest should start automatically when the Proxmox node boots.|
 | `startup_shutdown`            | `nested` |                      | Startup and shutdown configuration of the guest, see [Startup and Shutdown Reference](#startup-and-shutdown-reference).|
-| `vm_state`                    | `string` | `"running"`          | The desired state of the VM, options are `running`, `stopped` and `started`. Do note that `started` will only start the vm on creation and won't fully manage the power state unlike `running` and `stopped` do. |
-| `oncreate`                    | `bool`   | `true`               | Whether to have the VM startup after the VM is created (deprecated, use `vm_state` instead) |
+| `power_state`                 | `string` | `"running"`          | Power state of the guest, can be `"running"` or `"stopped"`.|
 | `protection`                  | `bool`   | `false`              | Enable/disable the VM protection from being removed. The default value of `false` indicates the VM is removable. |
 | `tablet`                      | `bool`   | `true`               | Enable/disable the USB tablet device. This device is usually needed to allow absolute mouse positioning with VNC. |
 | `boot`                        | `str`    |                      | The boot order for the VM. For example: `order=scsi0;ide2;net0`. The deprecated `legacy=` syntax is no longer supported. See the `boot` option in the [Proxmox manual](https://pve.proxmox.com/wiki/Manual:_qm.conf#_options) for more information. |
diff --git a/go.mod b/go.mod
@@ -3,7 +3,7 @@ module github.com/Telmate/terraform-provider-proxmox/v2
 go 1.24.9
 
 require (
-	github.com/Telmate/proxmox-api-go v0.0.0-20260405210716-af179791a625
+	github.com/Telmate/proxmox-api-go v0.0.0-20260423201259-0eeefb930bb2
 	github.com/google/uuid v1.6.0
 	github.com/hashicorp/go-cty v1.5.0
 	github.com/hashicorp/terraform-plugin-sdk/v2 v2.38.2
diff --git a/go.sum b/go.sum
@@ -4,8 +4,8 @@ github.com/Microsoft/go-winio v0.6.2 h1:F2VQgta7ecxGYO8k3ZZz3RS8fVIXVxONVUPlNERo
 github.com/Microsoft/go-winio v0.6.2/go.mod h1:yd8OoFMLzJbo9gZq8j5qaps8bJ9aShtEA8Ipt1oGCvU=
 github.com/ProtonMail/go-crypto v1.2.0 h1:+PhXXn4SPGd+qk76TlEePBfOfivE0zkWFenhGhFLzWs=
 github.com/ProtonMail/go-crypto v1.2.0/go.mod h1:9whxjD8Rbs29b4XWbB8irEcE8KHMqaR2e7GWU1R+/PE=
-github.com/Telmate/proxmox-api-go v0.0.0-20260405210716-af179791a625 h1:F0YfK9eN0dIfa3bz3ZRklsihsuHj8yaxHbIe7JVKnGM=
-github.com/Telmate/proxmox-api-go v0.0.0-20260405210716-af179791a625/go.mod h1:HGPbpwiVsrpYYuQAygnnU04ZdGLYc8fdP9qhJIBw2Bg=
+github.com/Telmate/proxmox-api-go v0.0.0-20260423201259-0eeefb930bb2 h1:VVMmJjr9NmuekozPo3/XTdcgQZsXgGayA0eVYI1zb8g=
+github.com/Telmate/proxmox-api-go v0.0.0-20260423201259-0eeefb930bb2/go.mod h1:HGPbpwiVsrpYYuQAygnnU04ZdGLYc8fdP9qhJIBw2Bg=
 github.com/agext/levenshtein v1.2.3 h1:YB2fHEn0UJagG8T1rrWknE3ZQzWM06O8AMAatNn7lmo=
 github.com/agext/levenshtein v1.2.3/go.mod h1:JEDfjyjHDjOF/1e4FlBE/PkbqA9OfWu2ki2W0IB5558=
 github.com/apparentlymart/go-textseg/v12 v12.0.0/go.mod h1:S/4uRK2UtaQttw1GenVJEynmyUenKwP++x/+DdGV/Ec=
diff --git a/proxmox/Internal/resource/guest/powerstate/schema.go b/proxmox/Internal/resource/guest/powerstate/schema.go
@@ -9,27 +9,28 @@ import (
 const (
 	Root = "power_state"
 
+	Default string = enumRunning
+
 	enumRunning = "running"
 	enumStopped = "stopped"
 )
 
-func Schema() *schema.Schema {
-	return &schema.Schema{
-		Type:     schema.TypeString,
-		Optional: true,
-		Default:  enumRunning,
-		ValidateDiagFunc: func(i any, path cty.Path) diag.Diagnostics {
-			if v, ok := i.(string); ok {
-				switch v {
-				case enumRunning, enumStopped:
-					return nil
-				}
-			}
-			return diag.Diagnostics{
-				diag.Diagnostic{
-					Detail:   "the power state must be either '" + enumRunning + "' or '" + enumStopped + "'",
-					Summary:  "invalid power state",
-					Severity: diag.Error},
+func Schema(s schema.Schema) *schema.Schema {
+	s.Type = schema.TypeString
+	s.Optional = true
+	s.ValidateDiagFunc = func(i any, path cty.Path) diag.Diagnostics {
+		if v, ok := i.(string); ok {
+			switch v {
+			case enumRunning, enumStopped:
+				return nil
 			}
-		}}
+		}
+		return diag.Diagnostics{
+			diag.Diagnostic{
+				Detail:   "the power state must be either '" + enumRunning + "' or '" + enumStopped + "'",
+				Summary:  "invalid power state",
+				Severity: diag.Error},
+		}
+	}
+	return &s
 }
diff --git a/proxmox/Internal/resource/guest/powerstate/schema_legacy.go b/proxmox/Internal/resource/guest/powerstate/schema_legacy.go
@@ -0,0 +1,39 @@
+package powerstate
+
+import (
+	"github.com/hashicorp/go-cty/cty"
+	"github.com/hashicorp/terraform-plugin-sdk/v2/diag"
+	"github.com/hashicorp/terraform-plugin-sdk/v2/helper/schema"
+)
+
+const (
+	LegacyRoot = "vm_state"
+
+	legacyEnumStarted = "started"
+)
+
+func SchemaLegacy() *schema.Schema {
+	return &schema.Schema{
+		Type:          schema.TypeString,
+		Deprecated:    "Use " + Root + " instead",
+		Description:   "The state of the VM (" + enumRunning + ", " + legacyEnumStarted + ", " + enumStopped + ")",
+		Optional:      true,
+		ConflictsWith: []string{Root},
+		ValidateDiagFunc: func(i any, path cty.Path) diag.Diagnostics {
+			if v, ok := i.(string); ok {
+				switch v {
+				case enumRunning, enumStopped, legacyEnumStarted:
+					return nil
+				}
+			}
+			return diag.Diagnostics{
+				diag.Diagnostic{
+					Detail:   LegacyRoot + " must be one of '" + enumRunning + "', '" + enumStopped + "', '" + legacyEnumStarted + "'",
+					Summary:  "invalid " + LegacyRoot,
+					Severity: diag.Error},
+			}
+		},
+		DiffSuppressFunc: func(k, old, new string, d *schema.ResourceData) bool {
+			return new == legacyEnumStarted
+		}}
+}
diff --git a/proxmox/Internal/resource/guest/powerstate/sdk.go b/proxmox/Internal/resource/guest/powerstate/sdk.go
@@ -2,17 +2,28 @@ package powerstate
 
 import (
 	pveSDK "github.com/Telmate/proxmox-api-go/proxmox"
+	"github.com/Telmate/terraform-provider-proxmox/v2/proxmox/Internal/util"
 	"github.com/hashicorp/terraform-plugin-sdk/v2/helper/schema"
 )
 
-func SDK(d *schema.ResourceData) *pveSDK.PowerState {
-	switch d.Get(Root).(string) {
+const (
+	LegacyFalse  LegacyEnum = 0
+	LegacyCreate LegacyEnum = 1
+	LegacyUpdate LegacyEnum = 2
+)
+
+type LegacyEnum uint8
+
+func SDK(legacy LegacyEnum, d *schema.ResourceData) *pveSDK.PowerState {
+	v, ok := d.GetOk(Root)
+	if !ok && legacy > LegacyFalse {
+		return sdkLegacy(d)
+	}
+	switch v.(string) {
 	case enumRunning:
-		state := pveSDK.PowerStateRunning
-		return &state
+		return util.Pointer(pveSDK.PowerStateRunning)
 	case enumStopped:
-		state := pveSDK.PowerStateStopped
-		return &state
+		return util.Pointer(pveSDK.PowerStateStopped)
 	default:
 		return nil
 	}
diff --git a/proxmox/Internal/resource/guest/powerstate/sdk_legacy.go b/proxmox/Internal/resource/guest/powerstate/sdk_legacy.go
@@ -0,0 +1,22 @@
+package powerstate
+
+import (
+	pveSDK "github.com/Telmate/proxmox-api-go/proxmox"
+	"github.com/Telmate/terraform-provider-proxmox/v2/proxmox/Internal/util"
+	"github.com/hashicorp/terraform-plugin-sdk/v2/helper/schema"
+)
+
+func sdkLegacy(d *schema.ResourceData) *pveSDK.PowerState {
+	v, ok := d.GetOk(LegacyRoot)
+	if !ok {
+		return util.Pointer(pveSDK.PowerStateRunning)
+	}
+	switch v.(string) {
+	case enumRunning:
+		return util.Pointer(pveSDK.PowerStateRunning)
+	case enumStopped:
+		return util.Pointer(pveSDK.PowerStateStopped)
+	default:
+		return nil
+	}
+}
diff --git a/proxmox/Internal/resource/guest/powerstate/terraform.go b/proxmox/Internal/resource/guest/powerstate/terraform.go
@@ -5,13 +5,30 @@ import (
 	"github.com/hashicorp/terraform-plugin-sdk/v2/helper/schema"
 )
 
-func Terraform(state pveSDK.PowerState, d *schema.ResourceData) {
-	switch state {
+func Terraform(config pveSDK.PowerState, legacy bool, d *schema.ResourceData) {
+	if _, ok := d.GetOk(Root); ok {
+		d.Set(Root, terraform(config))
+		if legacy {
+			terraformLegacyClear(d)
+		}
+		return
+	}
+	if legacy {
+		if _, ok := d.GetOk(LegacyRoot); ok {
+			terraformLegacy(config,d)
+			return
+		}
+	}
+	d.Set(Root, terraform(config))
+}
+
+func terraform(config pveSDK.PowerState) string {
+	switch config {
 	case pveSDK.PowerStateRunning:
-		d.Set(Root, enumRunning)
+		return enumRunning
 	case pveSDK.PowerStateStopped:
-		d.Set(Root, enumStopped)
+		return enumStopped
 	default:
-		d.Set(Root, "")
+		return ""
 	}
 }
diff --git a/proxmox/Internal/resource/guest/powerstate/terraform_legacy.go b/proxmox/Internal/resource/guest/powerstate/terraform_legacy.go
@@ -0,0 +1,16 @@
+package powerstate
+
+import (
+	pveSDK "github.com/Telmate/proxmox-api-go/proxmox"
+	"github.com/hashicorp/terraform-plugin-sdk/v2/helper/schema"
+)
+
+func terraformLegacy(config pveSDK.PowerState, d *schema.ResourceData) {
+	d.Set(LegacyRoot, terraform(config))
+}
+
+func terraformLegacyClear(d *schema.ResourceData) {
+	if _, ok := d.GetOk(LegacyRoot); ok {
+		d.Set(LegacyRoot, nil)
+	}
+}
diff --git a/proxmox/resource_lxc.go b/proxmox/resource_lxc.go
@@ -641,6 +641,7 @@ func resourceLxcUpdate(ctx context.Context, d *schema.ResourceData, meta interfa
 	defer lock.unlock()
 
 	client := pconf.Client
+	clientNew := client.New()
 
 	var resourceID id.Guest
 	if err := resourceID.Parse(d.Id()); err != nil {
@@ -777,15 +778,15 @@ func resourceLxcUpdate(ctx context.Context, d *schema.ResourceData, meta interfa
 		case pveSDK.PowerStateStopped:
 			if d.Get("start").(bool) {
 				log.Print("[DEBUG][LXCUpdate] starting LXC")
-				_, err = client.StartVm(ctx, vmr)
+				err = clientNew.Guest.Start(ctx, *vmr)
 				if err != nil {
 					return diag.FromErr(err)
 				}
 			}
 		case pveSDK.PowerStateRunning:
 			if !d.Get("start").(bool) {
 				log.Print("[DEBUG][LXCUpdate] stopping LXC")
-				if err = vmr.Stop(ctx, client); err != nil {
+				if err = clientNew.Guest.Stop(ctx, *vmr, false); err != nil {
 					return diag.FromErr(err)
 				}
 			}
@@ -892,16 +893,16 @@ func resourceLxcRead(ctx context.Context, d *schema.ResourceData, vmr *pveSDK.Vm
 	}
 
 	// Pool
-	c := client.New()
-	rawPools, err := c.Pool.List(ctx)
+	clientNew := client.New()
+	rawPools, err := clientNew.Pool.List(ctx)
 	if err != nil {
 		return append(diags, diag.FromErr(err)...)
 	}
 
 	var rawPoolInfo pveSDK.RawPoolInfo
 pools:
 	for e := range rawPools.Iter() {
-		rawPoolInfo, err = c.Pool.Read(ctx, e.GetName())
+		rawPoolInfo, err = clientNew.Pool.Read(ctx, e.GetName())
 		if err != nil {
 			return append(diags, diag.FromErr(err)...)
 		}
diff --git a/proxmox/resource_lxc_guest.go b/proxmox/resource_lxc_guest.go
@@ -67,7 +67,7 @@ func resourceLxcGuest() *schema.Resource {
 			operatingsystem.Root:         operatingsystem.Schema(),
 			password.Root:                password.Schema(),
 			pool.Root:                    pool.Schema(),
-			powerstate.Root:              powerstate.Schema(),
+			powerstate.Root:              powerstate.Schema(schema.Schema{Default: powerstate.Default}),
 			privilege.RootPrivileged:     privilege.SchemaPrivileged(),
 			privilege.RootUnprivileged:   privilege.SchemaUnprivileged(),
 			reboot.RootAutomatic:         reboot.SchemaAutomatic(),
@@ -295,7 +295,7 @@ func resourceLxcGuestRead(ctx context.Context, d *schema.ResourceData, vmr *pveS
 	node.Terraform(*config.Node, d)
 	operatingsystem.Terraform(config.OperatingSystem, d)
 	pool.Terraform(config.Pool, d)
-	powerstate.Terraform(guestStatus.GetState(), d)
+	powerstate.Terraform(guestStatus.GetState(), false, d)
 	privilege.Terraform(*config.Privileged, d)
 	rootmount.Terraform(config.BootMount, d)
 	startatnodeboot.Terraform(*config.StartAtNodeBoot, d)
@@ -324,7 +324,7 @@ func lxcSDK(privilidged bool, d *schema.ResourceData) (pveSDK.ConfigLXC, diag.Di
 		Name:            guestName,
 		StartAtNodeBoot: util.Pointer(startatnodeboot.SDK(d)),
 		StartupShutdown: startupshutdown.SDK(d),
-		State:           powerstate.SDK(d),
+		State:           powerstate.SDK(powerstate.LegacyFalse, d),
 		Swap:            swap.SDK(d),
 		Tags:            tags.SDK(d),
 	}
diff --git a/proxmox/resource_vm_qemu.go b/proxmox/resource_vm_qemu.go
diff --git a/proxmox/validators.go b/proxmox/validators.go
