Skip to content

Commit 6365389

Browse files
jiawei686humyfred
jiawei686
authored and
humyfred
committed
fix: eslint fix & list test case fix
1 parent cc91c6a commit 6365389

File tree

3 files changed

+10
-9
lines changed

3 files changed

+10
-9
lines changed

‎src/core/ParagraphBase.js‎

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -168,7 +168,7 @@ export default class ParagraphBase extends SyntaxBase {
168168
return;
169169
}
170170
const $sign = sign || this.$engine.md5(str);
171-
this.cache[$sign] = {
171+
this.cache[$sign] = {
172172
content: str,
173173
using: true,
174174
};
@@ -186,10 +186,10 @@ export default class ParagraphBase extends SyntaxBase {
186186
if (!this.needCache) {
187187
return;
188188
}
189-
for (let key in this.cache) {
189+
for (const key of Object.keys(this.cache)) {
190190
if (!this.cache[key].using) delete this.cache[key];
191191
}
192-
for (let key in this.cache) {
192+
for (const key of Object.keys(this.cache)) {
193193
this.cache[key].using = false;
194194
}
195195
}

‎test/core/hooks/List.spec.ts‎

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -72,7 +72,8 @@ Object.defineProperty(listHook, '$engine', {
7272
describe('core/hooks/list', () => {
7373
it('list hook', () => {
7474
cases.forEach((item) => {
75-
expect(listHook.toHtml(item, (text) => ({ html: text }))).toMatchSnapshot();
75+
listHook.makeHtml(item, (text) => ({ html: text }));
76+
expect(listHook.cache[listHook.sign].content).toMatchSnapshot();
7677
});
7778
});
7879
});

‎test/core/hooks/__snapshots__/List.spec.ts.snap‎

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,11 +1,11 @@
11
// Jest Snapshot v1, https://goo.gl/fbAQLP
22

3-
exports[`core/hooks/list list hook 1`] = `"<ul data-lines=\\"8\\" data-sign=\\"0ee90839df66d748d6faefc70677e3ee\\" class=\\"cherry-list__default\\"><li><p>1</p></li><li><p>2</p><ul class=\\"cherry-list__default\\"><li><p>2.1</p></li><li><p>2.2</p></li></ul></li><li><p>3</p><ul class=\\"cherry-list__circle\\"><li><p>3.1</p></li></ul></li><li><p>4</p><ul class=\\"cherry-list__square\\"><li><p>4.2</p></li></ul></li></ul>"`;
3+
exports[`core/hooks/list list hook 1`] = `"<ul data-lines=\\"8\\" data-sign=\\"2052aa9811ccbbdfcace4f3e56d89249\\" class=\\"cherry-list__default\\"><li><p>1</p></li><li><p>2</p><ul class=\\"cherry-list__default\\"><li><p>2.1</p></li><li><p>2.2</p></li></ul></li><li><p>3</p><ul class=\\"cherry-list__circle\\"><li><p>3.1</p></li></ul></li><li><p>4</p><ul class=\\"cherry-list__square\\"><li><p>4.2</p></li></ul></li></ul>"`;
44
5-
exports[`core/hooks/list list hook 2`] = `"<ul data-lines=\\"8\\" data-sign=\\"517b0da7dd7b1b616ab99665b9d280eb\\" class=\\"cherry-list__default\\"><li><p>1</p><ul class=\\"cherry-list__default\\"><li><p>2</p><ul class=\\"cherry-list__default\\"><li><p>2.1</p></li><li><p>2.2</p></li></ul></li></ul></li><li><p>3<br>3.1</p></li><li><p>4</p></li><li><p>4.2</p></li></ul>"`;
5+
exports[`core/hooks/list list hook 2`] = `"<ul data-lines=\\"8\\" data-sign=\\"362f490aeca95ab73384e1e30a576e1a\\" class=\\"cherry-list__default\\"><li><p>1</p><ul class=\\"cherry-list__default\\"><li><p>2</p><ul class=\\"cherry-list__default\\"><li><p>2.1</p></li><li><p>2.2</p></li></ul></li></ul></li><li><p>3<br>3.1</p></li><li><p>4</p></li><li><p>4.2</p></li></ul>"`;
66
7-
exports[`core/hooks/list list hook 3`] = `"<ul data-lines=\\"1\\" data-sign=\\"567632d2786fbb27c9e5df62189c44a7\\" class=\\"cherry-list__default\\"><li><p>1</p></li></ul><ol data-lines=\\"2\\" data-sign=\\"567632d2786fbb27c9e5df62189c44a7\\" class=\\"cherry-list__default\\"><li><p>test<br></p></li></ol><ul data-lines=\\"8\\" data-sign=\\"567632d2786fbb27c9e5df62189c44a7\\" class=\\"cherry-list__default\\"><li><p>1.1</p><ul class=\\"cherry-list__default\\"><li><p>1.1.2</p><ul class=\\"cherry-list__default\\"><li><p>blank</p></li></ul></li><li><p>1.2</p></li></ul></li><li><p>2<br>blank</p><ul class=\\"cherry-list__default\\"><li><p>2.1</p></li><li><p>2.2</p></li></ul></li></ul><ol data-lines=\\"2\\" data-sign=\\"567632d2786fbb27c9e5df62189c44a7\\" class=\\"cherry-list__default\\"><li><p>test</p><ol class=\\"cherry-list__default\\"><li><p>2</p></li></ol></li></ol>"`;
7+
exports[`core/hooks/list list hook 3`] = `"<ul data-lines=\\"1\\" data-sign=\\"95b9a2e3d59355afad427cda2937e115\\" class=\\"cherry-list__default\\"><li><p>1</p></li></ul><ol data-lines=\\"2\\" data-sign=\\"95b9a2e3d59355afad427cda2937e115\\" class=\\"cherry-list__default\\"><li><p>test<br></p></li></ol><ul data-lines=\\"8\\" data-sign=\\"95b9a2e3d59355afad427cda2937e115\\" class=\\"cherry-list__default\\"><li><p>1.1</p><ul class=\\"cherry-list__default\\"><li><p>1.1.2</p><ul class=\\"cherry-list__default\\"><li><p>blank</p></li></ul></li><li><p>1.2</p></li></ul></li><li><p>2<br>blank</p><ul class=\\"cherry-list__default\\"><li><p>2.1</p></li><li><p>2.2</p></li></ul></li></ul><ol data-lines=\\"2\\" data-sign=\\"95b9a2e3d59355afad427cda2937e115\\" class=\\"cherry-list__default\\"><li><p>test</p><ol class=\\"cherry-list__default\\"><li><p>2</p></li></ol></li></ol>"`;
88
9-
exports[`core/hooks/list list hook 4`] = `"<ol data-lines=\\"8\\" data-sign=\\"a7f4c176bd29fce6eed2db95c7433f88\\" class=\\"cherry-list__default\\"><li><p>test</p><ol class=\\"cherry-list__default\\"><li><p>test</p></li></ol></li><li><p>test</p><ol class=\\"cherry-list__cjk-ideographic\\"><li><p>test</p></li><li><p>test<br><br></p></li><li><p>test</p></li></ol></li></ol><ul data-lines=\\"1\\" data-sign=\\"a7f4c176bd29fce6eed2db95c7433f88\\" class=\\"cherry-list__default\\"><li><p>test</p></li></ul>"`;
9+
exports[`core/hooks/list list hook 4`] = `"<ol data-lines=\\"8\\" data-sign=\\"739b7596b094aac47153f8bcbb07e2e3\\" class=\\"cherry-list__default\\"><li><p>test</p><ol class=\\"cherry-list__default\\"><li><p>test</p></li></ol></li><li><p>test</p><ol class=\\"cherry-list__cjk-ideographic\\"><li><p>test</p></li><li><p>test<br><br></p></li><li><p>test</p></li></ol></li></ol><ul data-lines=\\"1\\" data-sign=\\"739b7596b094aac47153f8bcbb07e2e3\\" class=\\"cherry-list__default\\"><li><p>test</p></li></ul>"`;
1010
11-
exports[`core/hooks/list list hook 5`] = `"<ul data-lines=\\"6\\" data-sign=\\"1352e6eb28a6f713e316fbe3733cdee7\\" class=\\"cherry-list__default\\"><li class=\\"check-list-item\\"><p><span class=\\"ch-icon ch-icon-square\\"></span> checklist 1</p></li><li><p>test</p><ul class=\\"cherry-list__default\\"><li class=\\"check-list-item\\"><p><span class=\\"ch-icon ch-icon-check\\"></span> checklist 2</p></li></ul></li><li class=\\"check-list-item\\"><p><span class=\\"ch-icon ch-icon-square\\"></span> checklist 3</p></li><li><p>test</p><ul class=\\"cherry-list__default\\"><li class=\\"check-list-item\\"><p><span class=\\"ch-icon ch-icon-square\\"></span> checklist 4</p></li></ul></li></ul>"`;
11+
exports[`core/hooks/list list hook 5`] = `"<ul data-lines=\\"6\\" data-sign=\\"d1e2504747788dc560aedd3892b6705e\\" class=\\"cherry-list__default\\"><li class=\\"check-list-item\\"><p><span class=\\"ch-icon ch-icon-square\\"></span> checklist 1</p></li><li><p>test</p><ul class=\\"cherry-list__default\\"><li class=\\"check-list-item\\"><p><span class=\\"ch-icon ch-icon-check\\"></span> checklist 2</p></li></ul></li><li class=\\"check-list-item\\"><p><span class=\\"ch-icon ch-icon-square\\"></span> checklist 3</p></li><li><p>test</p><ul class=\\"cherry-list__default\\"><li class=\\"check-list-item\\"><p><span class=\\"ch-icon ch-icon-square\\"></span> checklist 4</p></li></ul></li></ul>"`;

0 commit comments

Comments
 (0)