Skip to content

Commit eac85cb

Browse files
authored
fix(transfer-dom): fix elements not being properly removed with transfer-dom util (#3788)
* fix(transfer-dom): 修复 DOM 元素未正确移除的问题 * fix(dialog): 移除冗余的 destroySelf 方法调用
1 parent 6f760bb commit eac85cb

2 files changed

Lines changed: 3 additions & 4 deletions

File tree

src/dialog/dialog.tsx

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -229,7 +229,6 @@ export default mixins(
229229

230230
beforeDestroy() {
231231
this.addKeyboardEvent(false);
232-
this.destroySelf();
233232
this.destroySelfStyle();
234233
},
235234

@@ -249,9 +248,6 @@ export default mixins(
249248
this.styleEl.parentNode?.removeChild?.(this.styleEl);
250249
},
251250

252-
destroySelf() {
253-
this.$el.parentNode?.removeChild?.(this.$el);
254-
},
255251
// 多个dialog情况,若有些给了默认值true,出现ESC关闭不了弹窗问题解决
256252
storeUid(flag: boolean) {
257253
if (flag) {

src/utils/transfer-dom.ts

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,9 @@ const TransferDom = {
77
const parentNode = getAttach(binding.value);
88
parentNode?.appendChild(el);
99
},
10+
unbind(el: HTMLElement) {
11+
el.parentNode?.removeChild(el);
12+
},
1013
};
1114

1215
export default TransferDom;

0 commit comments

Comments
 (0)