Skip to content

feat(Table): 校验函数 validateRowData 和 validateTableData 返回值支持 Promise 对象 ; 修复退出浮层退出编辑的问题#1275

Merged
uyarn merged 5 commits intodevelopfrom
feature_table_0811
Aug 12, 2022
Merged

feat(Table): 校验函数 validateRowData 和 validateTableData 返回值支持 Promise 对象 ; 修复退出浮层退出编辑的问题#1275
uyarn merged 5 commits intodevelopfrom
feature_table_0811

Conversation

@chaishi
Copy link
Copy Markdown
Collaborator

@chaishi chaishi commented Aug 11, 2022

🤔 这个 PR 的性质是?

  • 日常 bug 修复
  • 新特性提交
  • 文档改进
  • 演示代码改进
  • 组件样式/交互改进
  • CI/CD 改进
  • 重构
  • 代码风格优化
  • 测试用例
  • 分支合并
  • 其他

🔗 相关 Issue

💡 需求背景和解决方案

📝 更新日志

  • feat(Table): 可编辑行功能,校验函数 validateRowData 和 validateTableData 返回值支持 Promise 对象

  • fix(Table): 可编辑单元格,多选和日期选择,点击下拉浮层中的内容会导致退出编辑,issue#1384

  • 本条 PR 不需要纳入 Changelog

☑️ 请求合并前的自查清单

⚠️ 请自检并全部勾选全部选项⚠️

  • 文档已补充或无须补充
  • 代码演示已提供或无须提供
  • TypeScript 定义已补充或无须补充
  • Changelog 已提供或无须提供

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Aug 11, 2022

完成

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Aug 11, 2022

Codecov Report

❌ Patch coverage is 10.71429% with 25 lines in your changes missing coverage. Please review.
✅ Project coverage is 58.20%. Comparing base (492d477) to head (fce4b04).
⚠️ Report is 1190 commits behind head on develop.

Files with missing lines Patch % Lines
src/table/hooks/useEditableRow.ts 12.50% 21 Missing ⚠️
src/table/editable-cell.tsx 0.00% 4 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1275      +/-   ##
===========================================
+ Coverage    57.94%   58.20%   +0.26%     
===========================================
  Files          407      408       +1     
  Lines        15371    15297      -74     
  Branches      2931     2884      -47     
===========================================
- Hits          8907     8904       -3     
+ Misses        6187     6117      -70     
+ Partials       277      276       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@uyarn uyarn merged commit 36610cc into develop Aug 12, 2022
@uyarn uyarn deleted the feature_table_0811 branch August 12, 2022 06:06
@uyarn uyarn changed the title [Table] set return value of validateRowData and validateTableData to be a Promise ; stopPropagation popup content click bubble to document feat(Table): 校验函数 validateRowData 和 validateTableData 返回值支持 Promise 对象 ; 修复退出浮层退出编辑的问题 Aug 12, 2022
@github-actions github-actions bot mentioned this pull request Aug 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants