Installation script isn't working on the Apache Pulsar project

[devinbost]

When I run the installation script for Apache Pulsar, nothing happens.

To reproduce:

# clone iFixFlakies repo
git clone https://github.com/TestingResearchIllinois/iFixFlakies.git
# clone Apache Pulsar repo
git clone https://github.com/apache/pulsar.git
# run installer script
bash iFixFlakies/pom-modify/modify-project.sh pulsar/

Pulsar's POM files are unmodified. Verify as follows:

cd pulsar
git status

Also, if I try manually adding the plugin to the top-level POM file and running mvn testrunner:testplugin, I get this error:

[ERROR] No plugin found for prefix 'testrunner' in the current project and in the plugin groups [org.apache.maven.plugins, org.codehaus.mojo] available from the repositories [local (/Users/dbost/.m2/repository), apache.snapshots (https://repository.apache.org/snapshots), central (https://repo.maven.apache.org/maven2)] -> [Help 1]

[august782]

Hi,

Thanks for trying out iFixFlakies.

When you run the installer script (bash iFixFlakies/pom-modify/modify-project.sh pulsar/), do you get anything printed out? For example, on my end, when I run the script as you specified, it prints out all the paths to modules within the project that get modified. After navigating into pulsar/, I indeed see that the various pom.xml files have been modified.

When you added the plugin manually to the top-level pom.xml, did it stop building at the first module and skip the rest? It seems that the first module, buildtools, does not declare the top-level module as a parent and therefore does not inherit the plugin from it. Then, the overall build would stop at the first buildtools module and skip the rest. You would need to add the plugin to this module as well (or ultimately it probably is best to add to all modules, as the script is trying to do).

[devinbost]

When I run the script, I don't get anything printed out.
I'm running MacOS 10.15.7. What operating system are you using?

When I tried adding the plugin manually to the top-level pom.xml, it stopped very early in the process. I've attached the complete console output.

build_output_ifixflakies.txt

[august782]

I run the script in a Linux environment (Ubuntu 20.04). And you are saying you do not see anything printed out, not even any error message? The script itself compiles the PomFile.java and calls it on a pom.xml. Could you try first compiling the PomFile.java (javac PomFile.java) and then running "java PomFile ifixflakies 1.0.0-SNAPSHOT edu.illinois.cs.dt.tools.fixer.CleanerFixerPlugin " to see if it would modify that pom.xml file?

From your provided output, it seems to be the case of what I described earlier, where it stops early at that buildtools module that did not inherit the plugin from the top-level pom.xml you modified. You could try modifying the pom.xml under buildtools/ to include the plugin and try running again, though in general you probably just want to modify the pom.xml of all modules in the project just to be safe.

[devinbost]

And you are saying you do not see anything printed out, not even any error message?

That is correct.

I successfully compiled PomFile.java.
However, how do I point it to the pom.xml file?
When I run:
$ java PomFile ifixflakies 1.0.0-SNAPSHOT edu.illinois.cs.dt.tools.fixer.CleanerFixerPlugin
from the directory pom-modify, I get:

Exception in thread "main" java.lang.NullPointerException
at PomFile.(PomFile.java:44)
at PomFile.main(PomFile.java:265)

If I try to point to it from a higher-level directory, I get this:

$ java ./iFixFlakies/pom-modify/PomFile ifixflakies 1.0.0-SNAPSHOT edu.illinois.cs.dt.tools.fixer.CleanerFixerPlugin
Error: Could not find or load main class ..iFixFlakies.pom-modify.PomFile

[august782]

For the java command, you need to pass it the path to a pom.xml you want to modify as the last input parameter. You should only run it from within the directory where the compiled PomFile.class is (otherwise you would need to include some classpath so java would know where the class is).

[devinbost]

Here's what I get:

$ java PomFile ifixflakies 1.0.0-SNAPSHOT edu.illinois.cs.dt.tools.fixer.CleanerFixerPlugin ../../pulsar/pom.xml
Usage: java PomFile <artifact_id> <artifact_version> <configuration_class_name>

Exception in thread "main" java.lang.NullPointerException
	at PomFile.<init>(PomFile.java:44)
	at PomFile.main(PomFile.java:265)

Am I passing that path to the pom.xml file correctly?

[devinbost]

I get the same result if I pass an absolute path, like this:

$ java PomFile ifixflakies 1.0.0-SNAPSHOT edu.illinois.cs.dt.tools.fixer.CleanerFixerPlugin /Users/dbost/src/apache-pulsar/pulsar/pom.xml

[august782]

Sorry, my mistake, you do not pass in the path to the pom.xml as an argument but rather pipe into it as an input. In other words, could you try running this command:

echo "/Users/dbost/src/apache-pulsar/pulsar/pom.xml" | java ifixflakies 1.0.0-SNAPSHOT edu.illinois.cs.dt.tools.fixer.CleanerFixerPlugin

[devinbost]

Here are my results:

$ echo "/Users/dbost/src/apache-pulsar/pulsar/pom.xml" | java PomFile ifixflakies 1.0.0-SNAPSHOT edu.illinois.cs.dt.tools.fixer.CleanerFixerPlugin
/Users/dbost/src/apache-pulsar/pulsar

It looks like it only modified the top-level pom.xml file.

[august782]

Yes, that is expected, that command should only modify the passed in pom.xml. The modify-project.sh script actually searches for all the pom.xml files via the find command and pipes those in as inputs to the java command as a means to modify all those pom.xml files.

I'm not sure why that combination of find piped to this java command does not work in your environment. You could try some loop where you find all the pom.xml files and echo each one one-by-one into this command to modify all of them.

[devinbost]

I was able to run the command on all of the POM files in my project via:
$ find /Users/dbost/src/apache-pulsar/pulsar -name "pom.xml" | xargs -n 1 sh -c 'echo $0 | java PomFile ifixflakies 1.0.0-SNAPSHOT edu.illinois.cs.dt.tools.fixer.CleanerFixerPlugin'

[devinbost]

I confirmed that all of the POM files in the project have been updated.

Now, when I run mvn testrunner:testplugin, I get:

[ERROR] Failed to execute goal edu.illinois.cs:testrunner-maven-plugin:1.0:testplugin (default-cli) on project buildtools: Execution default-cli of goal edu.illinois.cs:testrunner-maven-plugin:1.0:testplugin failed: Plugin edu.illinois.cs:testrunner-maven-plugin:1.0 or one of its dependencies could not be resolved: Could not find artifact edu.illinois.cs:ifixflakies:jar:1.0.0-SNAPSHOT in apache.snapshots (https://repository.apache.org/snapshots) -> [Help 1]

(It fails again at the Pulsar Build Tools module.)

[august782]

You will need to "mvn install" the iFixFlakies project first.

Also, seeing as you are moving forward in trying to run iFixFlakies on modules in this project, I think you will need to have some detected order-dependent flaky tests first. You would need to run iDFlakies (https://github.com/idflakies/iDFlakies) on the project first.

[devinbost]

I cloned iDFlakies and ran:

cd iDFlakies
cd pom-modify
javac PomFile.java
find /Users/dbost/src/apache-pulsar/pulsar -name "pom.xml" | xargs -n 1 sh -c 'echo $0 | java PomFile idflakies 1.1.0 edu.illinois.cs.dt.tools.detection.DetectorPlugin'

After that, I inspected the POM files and noticed that the headings were all chopped off...

(They're all like this.)

[devinbost]

I'm not sure if that happened after running the first java file or the second one.