Skip to content

Commit 9613c8b

Browse files
authored
Merge pull request #2038 from TAMULib/sprint-9-tests
Fix tests
2 parents f4d9058 + 89de53d commit 9613c8b

File tree

13 files changed

+27
-106
lines changed

13 files changed

+27
-106
lines changed

.github/workflows/build.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@ on: [ push, pull_request, workflow_dispatch ]
44

55
jobs:
66
build:
7-
runs-on: ubuntu-latest
7+
runs-on: ubuntu-22.04
88

99
steps:
1010
- uses: actions/checkout@v3

src/main/java/org/tdl/vireo/model/CustomActionValue.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,7 @@ public class CustomActionValue extends ValidatingBaseEntity {
2525
private CustomActionDefinition definition;
2626

2727
@JsonView(Views.SubmissionList.class)
28-
@Column(nullable = false)
28+
@Column(nullable = false, name = "\"value\"")
2929
private Boolean value;
3030

3131
public CustomActionValue() {

src/main/java/org/tdl/vireo/model/FieldPredicate.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,7 @@ public class FieldPredicate extends ValidatingBaseEntity {
2323
private static String period = Pattern.quote(".");
2424

2525
@JsonView(ApiView.Partial.class)
26-
@Column(nullable = false, unique = true)
26+
@Column(nullable = false, unique = true, name = "\"value\"")
2727
private String value;
2828

2929
@JsonView(ApiView.Partial.class)

src/main/java/org/tdl/vireo/model/FieldValue.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@
2121
public class FieldValue extends ValidatingBaseEntity {
2222

2323
@JsonView(Views.SubmissionList.class)
24-
@Column(columnDefinition = "text", nullable = true)
24+
@Column(columnDefinition = "text", nullable = true, name = "\"value\"")
2525
private String value;
2626

2727
@JsonView(Views.SubmissionIndividual.class)

src/main/java/org/tdl/vireo/model/FilterCriterion.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@
1111
@Table(uniqueConstraints = { @UniqueConstraint(columnNames = { "value", "gloss" }) })
1212
public class FilterCriterion extends BaseEntity {
1313

14-
@Column
14+
@Column(name = "\"value\"")
1515
private String value;
1616

1717
@Column

src/main/java/org/tdl/vireo/model/GraduationMonth.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@
1717
@Entity
1818
public class GraduationMonth extends ValidatingOrderedBaseEntity implements EntityControlledVocabulary {
1919

20-
@Column(nullable = false, unique = true)
20+
@Column(nullable = false, unique = true, name = "\"month\"")
2121
private int month;
2222

2323
public GraduationMonth() {

src/main/java/org/tdl/vireo/model/ManagedConfiguration.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,7 @@ public class ManagedConfiguration extends ValidatingBaseEntity implements Config
2323
@Column(nullable = false, length = 255)
2424
private String name;
2525

26-
@Column(nullable = false, columnDefinition = "text")
26+
@Column(nullable = false, columnDefinition = "text", name = "\"value\"")
2727
private String value;
2828

2929
@Column(nullable = false, length = 255)

src/main/java/org/tdl/vireo/model/User.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -85,7 +85,7 @@ public class User extends AbstractWeaverUserDetails {
8585
@JsonView(Views.SubmissionIndividual.class)
8686
@ElementCollection(fetch = EAGER)
8787
@MapKeyColumn(name = "setting")
88-
@Column(name = "value")
88+
@Column(name = "\"value\"")
8989
private Map<String, String> settings;
9090

9191
@JsonView(Views.Partial.class)

src/main/webapp/tests/unit/models/submissionTest.js

Lines changed: 9 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -466,9 +466,16 @@ describe('model: Submission', function () {
466466
model.removeAllUnsavedFieldValuesByPredicate(model.fieldValues[0].fieldPredicate);
467467
});*/
468468
it('removeFieldValue should call WsApi', function () {
469-
spyOn(WsApi, "fetch");
469+
var mfv = new mockFieldValue(q);
470+
471+
spyOn(WsApi, "fetch").and.returnValue(Promise.resolve({
472+
body: JSON.stringify({
473+
meta: { status: 'SUCCESS' },
474+
payload: mfv
475+
})
476+
}));
470477

471-
model.removeFieldValue(new mockFieldValue(q));
478+
model.removeFieldValue(mfv);
472479
scope.$apply();
473480

474481
expect(WsApi.fetch).toHaveBeenCalled();

src/test/java/org/tdl/vireo/ApplicationInitializationTest.java

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -10,6 +10,8 @@
1010
import org.junit.jupiter.api.Test;
1111
import org.springframework.beans.factory.annotation.Autowired;
1212
import org.springframework.boot.test.context.SpringBootTest;
13+
import org.springframework.test.annotation.DirtiesContext;
14+
import org.springframework.test.annotation.DirtiesContext.ClassMode;
1315
import org.springframework.test.context.ActiveProfiles;
1416
import org.springframework.transaction.annotation.Propagation;
1517
import org.springframework.transaction.annotation.Transactional;
@@ -27,6 +29,7 @@
2729
@ActiveProfiles(value = { "test" })
2830
@SpringBootTest(classes = { Application.class })
2931
@Transactional(propagation = Propagation.REQUIRES_NEW)
32+
@DirtiesContext(classMode = ClassMode.AFTER_CLASS)
3033
public class ApplicationInitializationTest {
3134

3235
@Autowired

0 commit comments

Comments
 (0)