Skip to content

Client Ping/Pong broken in 1.6 #170

Open
@MarcusOhman91

Description

@MarcusOhman91

Pong request payload does not match ping response payload (which causes the websocket server I try to interact with to close the connection)

In my scenario the ping from the websocket server is an empty string. When producing the pong response, the pushFrame is invoked receiving the following $frame argument: [true,"","pong",false]. This in turn produces a $data of �\u0000" which is written to the stream.

I could quickfix it for my scenario by changing this line
$this->write($data);
to
$this->write($opcode === 'pong' ? '' : $data);

But I instead solved it by downgrading to v1.5.8 where the ping/pong interaction seems to work fine.

Reproduced with PHP 8.1.12 (cli)
version 1.6.3

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions