Skip to content

Simplify Text Shadowing by Using NSShadowAttributeName #150

Open
@garrettmoon

Description

@garrettmoon

From @Adlai-Holler on October 30, 2016 16:45

Currently our shadowing is implemented by ASTextKitShadower. We can simplify our text shadowing (and improve performance!) by using NSShadowAttributeName. During our rendering, if they specify a shadow on the node, we should add the shadow attribute into the string (anywhere it isn't already set.)

Considerations:

  • We should check if NSShadowAttributeName affects sizing calculations – whether the shadow outset is included automatically or not.
  • We should avoid allocating NSShadow objects whenever possible.

Copied from original issue: facebookarchive/AsyncDisplayKit#2510

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions