Skip to content

False completion detection still occurs when Codex explains it's NOT outputting a promise #43

@ebailey-kai

Description

@ebailey-kai

Description

Ralph v1.2.1 still exits with false positive completion detection when the agent explains it's not outputting a completion promise.

Reproduction

Agent (Codex) output included:

Because `fastembed` is still not installed, I did not mark the task `[x]` and I am not outputting a completion promise.

Ralph detected:

✅ Completion promise detected: <promise>ALL_PHASE2_TASKS_DONE</promise>

Environment

  • ralph-wiggum: 1.2.1
  • Agent: Codex (gpt-5.3-codex)
  • Tasks mode enabled
  • Completion promise: ALL_PHASE2_TASKS_DONE

Notes

This is related to #28 which was fixed in PR #36. However, the fix appears to only handle cases where the promise is inside <promise> tags with negation.

In this case, Codex wrote the English phrase "I am not outputting a completion promise" WITHOUT the actual promise tags, but Ralph still detected the completion promise string and exited.

Possible cause: The detection is matching the raw promise string (ALL_PHASE2_TASKS_DONE) anywhere in the output, not just inside <promise> tags.

Suggested Fix

Promise detection should ONLY match content inside actual <promise>...\</promise> tags, not raw strings in prose.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions