Skip to content

Commit b89a5b1

Browse files
authored
Fix set_expires_in not accepting non-default Period (#402)
1 parent 7fc762d commit b89a5b1

7 files changed

Lines changed: 8 additions & 8 deletions

File tree

example/rsa-create.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -37,7 +37,7 @@ rK0/Ikt5ybqUzKCMJZg2VKGTxg==
3737
.set_type("JWT")
3838
.set_id("rsa-create-example")
3939
.set_issued_now()
40-
.set_expires_in(std::chrono::seconds{36000})
40+
.set_expires_in(std::chrono::hours{1})
4141
.set_payload_claim("sample", jwt::claim(std::string{"test"}))
4242
.sign(jwt::algorithm::rs256("", rsa_priv_key, "", ""));
4343

include/jwt-cpp/jwt.h

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -3246,8 +3246,8 @@ namespace jwt {
32463246
* \param d token expiration timeout
32473247
* \return *this to allow for method chaining
32483248
*/
3249-
template<class Rep>
3250-
builder& set_expires_in(const std::chrono::duration<Rep>& d) {
3249+
template<class Rep, class Period>
3250+
builder& set_expires_in(const std::chrono::duration<Rep, Period>& d) {
32513251
return set_payload_claim("exp", basic_claim<json_traits>(clock.now() + d));
32523252
}
32533253
/**

tests/traits/BoostJsonTest.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -87,7 +87,7 @@ TEST(BoostJsonTest, VerifyTokenExpirationInValid) {
8787
const auto token = jwt::create<jwt::traits::boost_json>()
8888
.set_issuer("auth0")
8989
.set_issued_now()
90-
.set_expires_in(std::chrono::seconds{3600})
90+
.set_expires_in(std::chrono::hours{1})
9191
.sign(jwt::algorithm::hs256{"secret"});
9292

9393
const auto decoded_token = jwt::decode<jwt::traits::boost_json>(token);

tests/traits/JsonconsTest.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -90,7 +90,7 @@ TEST(JsonconsTest, VerifyTokenExpirationInValid) {
9090
const auto token = jwt::create<jwt::traits::danielaparker_jsoncons>()
9191
.set_issuer("auth0")
9292
.set_issued_now()
93-
.set_expires_in(std::chrono::seconds{3600})
93+
.set_expires_in(std::chrono::hours{1})
9494
.sign(jwt::algorithm::hs256{"secret"});
9595

9696
const auto decoded_token = jwt::decode<jwt::traits::danielaparker_jsoncons>(token);

tests/traits/NlohmannTest.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -86,7 +86,7 @@ TEST(NlohmannTest, VerifyTokenExpirationInValid) {
8686
const auto token = jwt::create<jwt::traits::nlohmann_json>()
8787
.set_issuer("auth0")
8888
.set_issued_now()
89-
.set_expires_in(std::chrono::seconds{3600})
89+
.set_expires_in(std::chrono::hours{1})
9090
.sign(jwt::algorithm::hs256{"secret"});
9191

9292
const auto decoded_token = jwt::decode<jwt::traits::nlohmann_json>(token);

tests/traits/OspJsoncppTest.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -90,7 +90,7 @@ TEST(OspJsoncppTest, VerifyTokenExpirationInValid) {
9090
const auto token = jwt::create<jwt::traits::open_source_parsers_jsoncpp>()
9191
.set_issuer("auth0")
9292
.set_issued_now()
93-
.set_expires_in(std::chrono::seconds{3600})
93+
.set_expires_in(std::chrono::hours{1})
9494
.sign(jwt::algorithm::hs256{"secret"});
9595

9696
const auto decoded_token = jwt::decode<jwt::traits::open_source_parsers_jsoncpp>(token);

tests/traits/TraitsTest.cpp.mustache

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -90,7 +90,7 @@ TEST({{test_suite_name}}, VerifyTokenExpirationInValid) {
9090
const auto token = jwt::create<jwt::traits::{{traits_name}}>()
9191
.set_issuer("auth0")
9292
.set_issued_now()
93-
.set_expires_in(std::chrono::seconds{3600})
93+
.set_expires_in(std::chrono::hours{1})
9494
.sign(jwt::algorithm::hs256{"secret"});
9595

9696
const auto decoded_token = jwt::decode<jwt::traits::{{traits_name}}>(token);

0 commit comments

Comments
 (0)