Commit 01b62e9
fix(tests): stop asserting typeCache identity, same singleton flake as the sibling assertion
PR #20 CI (2026-08-07, seed 82518): "Project import and export unit tests
re-keys imported node ids while reusing the target component id" failed on
one of two parallel runs, same commit, different random seed -- confirmed
flaky, not a regression.
This exact test's own comments already document three prior rounds of
diagnosing identical order-dependent-identity flakiness through
NodeLibrary.instance (a singleton shared across the whole suite), each
resolved by asserting a stable property instead of raw object identity --
e.g. `instanceNode.type.name === '/comp1'` a few lines above this one,
explicitly captioned "asserted, unlike identity, because it is
order-independent". That caption turned out to be wrong for THIS assertion
too: `NodeLibrary.instance.typeCache.get('/comp1')` toBe(importedComp1) is
the last remaining raw-identity check in the spec, and seed 82518 is the
seed that proves it isn't order-independent either. Same fix as its
siblings: assert the name resolves to a real component, not that it's the
literal same object.
Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>1 parent 08a5445 commit 01b62e9
1 file changed
Lines changed: 8 additions & 2 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
518 | 518 | | |
519 | 519 | | |
520 | 520 | | |
521 | | - | |
522 | | - | |
| 521 | + | |
| 522 | + | |
| 523 | + | |
| 524 | + | |
| 525 | + | |
| 526 | + | |
| 527 | + | |
| 528 | + | |
523 | 529 | | |
524 | 530 | | |
525 | 531 | | |
| |||
0 commit comments