Skip to content

Commit 905666e

Browse files
fix(packaging): bundle eslint-linter-browserify, don't leave it as a runtime require
v0.1.1's packaged app crashed to a blank black launcher screen on first launch — the very first time a real signed macOS build was actually opened. Renderer console: "Cannot find module 'eslint-linter-browserify'". get-externals-modules.js treats every top-level node_modules package as webpack-external (left as a runtime require()) unless excluded via a !node_modules/<name> files pattern, which instead forces static bundling. eslint-linter-browserify is a dependency of noodl-core-ui (imported by esLintDiagnostics.ts for the code editor's live lint), not of noodl-editor directly -- present in the hoisted root node_modules at webpack time (so it got externalized), but electron-builder's dependency pruning for the packaged app doesn't trace it back across the workspace boundary from noodl-editor's own package.json, so it never reaches the packaged node_modules. Verified locally: the production renderer bundle now inlines the Linter class directly, zero remaining require("eslint-linter-browserify") calls. Bumps to v0.1.2 -- v0.1.1's draft stays as a record of the defect. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
1 parent 202e7aa commit 905666e

1 file changed

Lines changed: 2 additions & 1 deletion

File tree

packages/noodl-editor/package.json

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@
55
"author": "The Low Code Foundation <contact@thelowcodefoundation.com>",
66
"homepage": "https://thelowcodefoundation.com",
77
"license": "GPL-3.0-only",
8-
"version": "0.1.1",
8+
"version": "0.1.2",
99
"main": "src/main/main.bundle.js",
1010
"scripts": {
1111
"build": "npx ts-node -P ./tsconfig.build.json ./scripts/build.ts",
@@ -63,6 +63,7 @@
6363
"src",
6464
"node_modules",
6565
"node_modules/dugite",
66+
"!node_modules/eslint-linter-browserify",
6667
"!test.js",
6768
"!src/main/main.js",
6869
"!src/main/github-oauth-handler.js",

0 commit comments

Comments
 (0)