fix(azure-devops): rm redundant base fetch, cache empty diff, rename map, polish

- get_diff_files: incremental path now substitutes for the base-SHA
  original fetch instead of fetching base then overwriting, saving one
  Azure get_item call per modified file in incremental runs.
- get_diff_files: cache guard switched to `is not None` so the
  early-return on missing last_merge_commit/last_merge_target_commit is
  cached (`[]` is falsy and was being recomputed each call).
- Rename `unreviewed_files_set` -> `unreviewed_files_map` across Azure,
  GitHub, Gitea providers, the reviewer, and the unit test. The
  attribute has always been a dict (path -> path/patch); the old name
  was misleading.
- Wrap get_previous_review max() lambda for readability.
- Normalize filter_ignored(..., "azure") to double-quoted literal.

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>

Author: agonzales-ipcoop

pr_agent/git_providers/azuredevops_provider.py

@@ -79,7 +79,7 @@ def __init__(
         self.pr = None
         self.temp_comments = []
         self.incremental = incremental
-        self.unreviewed_files_set = {}
+        self.unreviewed_files_map = {}
         self.pr_commits = None
         self.previous_review = None
         if pr_url:
@@ -194,7 +194,7 @@ def get_incremental_commits(self, incremental=None):
             incremental = IncrementalPR(False)
         self.incremental = incremental
         if self.incremental.is_incremental:
-            self.unreviewed_files_set = {}
+            self.unreviewed_files_map = {}
             self._get_incremental_commits()
 
     def _get_incremental_commits(self):
@@ -245,10 +245,10 @@ def _get_incremental_commits(self):
 
         if candidate_paths:
             deduped = list(dict.fromkeys(candidate_paths))
-            filtered = filter_ignored(deduped, 'azure')
+            filtered = filter_ignored(deduped, "azure")
             for path in filtered:
                 if is_valid_file(path):
-                    self.unreviewed_files_set[path] = path
+                    self.unreviewed_files_map[path] = path
         elif had_errors and self.incremental.commits_range:
             get_logger().warning(
                 "Failed to fetch changes for incremental commits; falling back to full review."
@@ -287,7 +287,10 @@ def get_previous_review(self, *, full: bool, incremental: bool):
                 matches.append(comment)
         if not matches:
             return None
-        latest = max(matches, key=lambda c: _to_naive_utc(getattr(c, "published_date", None)) or _dt.datetime.min)
+        latest = max(
+            matches,
+            key=lambda c: _to_naive_utc(getattr(c, "published_date", None)) or _dt.datetime.min,
+        )
         latest.html_url = self.get_comment_url(latest)
         latest.created_at = _to_naive_utc(getattr(latest, "published_date", None))
         return latest
@@ -311,8 +314,8 @@ def get_repo_settings(self):
     def get_files(self):
         if (isinstance(getattr(self, "incremental", None), IncrementalPR)
                 and self.incremental.is_incremental
-                and self.unreviewed_files_set):
-            return list(self.unreviewed_files_set.keys())
+                and self.unreviewed_files_map):
+            return list(self.unreviewed_files_map.keys())
         return self._get_files_full()
 
     def _get_files_full(self):
@@ -335,7 +338,7 @@ def _get_files_full(self):
     def get_diff_files(self) -> list[FilePatchInfo]:
         try:
 
-            if self.diff_files:
+            if self.diff_files is not None:
                 return self.diff_files
 
             if self.pr.last_merge_commit is None or self.pr.last_merge_target_commit is None:
@@ -403,7 +406,7 @@ def get_diff_files(self) -> list[FilePatchInfo]:
             # diffs = list(set(diffs))
 
             diffs_original = diffs
-            diffs = filter_ignored(diffs_original, 'azure')
+            diffs = filter_ignored(diffs_original, "azure")
             if diffs_original != diffs:
                 try:
                     get_logger().info(f"Filtered out [ignore] files for pull request:", extra=
@@ -415,11 +418,11 @@ def get_diff_files(self) -> list[FilePatchInfo]:
             incremental_active = (
                 isinstance(getattr(self, "incremental", None), IncrementalPR)
                 and self.incremental.is_incremental
-                and bool(self.unreviewed_files_set)
+                and bool(self.unreviewed_files_map)
                 and self.incremental.last_seen_commit_sha
             )
             if incremental_active:
-                diffs = [f for f in diffs if f in self.unreviewed_files_set]
+                diffs = [f for f in diffs if f in self.unreviewed_files_map]
 
             invalid_files_names = []
             for file in diffs:
@@ -459,51 +462,53 @@ def get_diff_files(self) -> list[FilePatchInfo]:
                 elif "rename" in diff_types[file]: # diff_type can be `rename` | `edit, rename`
                     edit_type = EDIT_TYPE.RENAMED
 
-                version = GitVersionDescriptor(
-                    version=base_sha.commit_id, version_type="commit"
-                )
                 if edit_type == EDIT_TYPE.ADDED or edit_type == EDIT_TYPE.RENAMED:
                     original_file_content_str = ""
-                else:
+                elif incremental_active:
+                    inc_version = GitVersionDescriptor(
+                        version=self.incremental.last_seen_commit_sha, version_type="commit"
+                    )
                     try:
-                        original_file_content_str = self.azure_devops_client.get_item(
+                        inc_original = self.azure_devops_client.get_item(
                             repository_id=self.repo_slug,
                             path=file,
                             project=self.workspace_slug,
-                            version_descriptor=version,
+                            version_descriptor=inc_version,
                             download=False,
                             include_content=True,
                         )
-                        original_file_content_str = original_file_content_str.content
+                        original_file_content_str = inc_original.content or ""
                     except Exception as error:
-                        get_logger().error(f"Failed to retrieve original file content of {file} at version {version}", error=error)
+                        get_logger().warning(
+                            f"Failed to retrieve original of {file} at {self.incremental.last_seen_commit_sha}: {error}"
+                        )
                         original_file_content_str = ""
-
-                if incremental_active:
-                    inc_version = GitVersionDescriptor(
-                        version=self.incremental.last_seen_commit_sha, version_type="commit"
+                else:
+                    base_version = GitVersionDescriptor(
+                        version=base_sha.commit_id, version_type="commit"
                     )
                     try:
-                        inc_original = self.azure_devops_client.get_item(
+                        base_original = self.azure_devops_client.get_item(
                             repository_id=self.repo_slug,
                             path=file,
                             project=self.workspace_slug,
-                            version_descriptor=inc_version,
+                            version_descriptor=base_version,
                             download=False,
                             include_content=True,
                         )
-                        original_file_content_str = inc_original.content or ""
+                        original_file_content_str = base_original.content
                     except Exception as error:
-                        get_logger().warning(
-                            f"Failed to retrieve original of {file} at {self.incremental.last_seen_commit_sha}: {error}"
+                        get_logger().error(
+                            f"Failed to retrieve original file content of {file} at version {base_version}",
+                            error=error,
                         )
                         original_file_content_str = ""
 
                 patch = load_large_diff(
                     file, new_file_content_str, original_file_content_str, show_warning=False
                 ).rstrip()
                 if incremental_active:
-                    self.unreviewed_files_set[file] = patch
+                    self.unreviewed_files_map[file] = patch
 
                 # count number of lines added and removed
                 patch_lines = patch.splitlines(keepends=True)

pr_agent/git_providers/gitea_provider.py

@@ -64,7 +64,7 @@ def __init__(self, url: Optional[str] = None):
         self.diff_files = []
         self.incremental = IncrementalPR(False)
         self.comments_list = []
-        self.unreviewed_files_set = dict()
+        self.unreviewed_files_map = dict()
 
         if "pulls" in url:
             self.pr_url = url
@@ -475,9 +475,9 @@ def get_diff_files(self) -> List[FilePatchInfo]:
                 # Get file content from this pr
                 head_file = self.file_contents.get(filename,"")
 
-            if self.incremental.is_incremental and self.unreviewed_files_set:
+            if self.incremental.is_incremental and self.unreviewed_files_map:
                 base_file = self._get_file_content_from_latest_commit(filename)
-                self.unreviewed_files_set[filename] = patch
+                self.unreviewed_files_map[filename] = patch
             else:
                 if avoid_load:
                     base_file = ""

pr_agent/git_providers/github_provider.py

@@ -79,7 +79,7 @@ def _get_issue_handle(self, issue_url) -> Optional[Issue]:
     def get_incremental_commits(self, incremental=IncrementalPR(False)):
         self.incremental = incremental
         if self.incremental.is_incremental:
-            self.unreviewed_files_set = dict()
+            self.unreviewed_files_map = dict()
             self._get_incremental_commits()
 
     def is_supported(self, capability: str) -> bool:
@@ -162,7 +162,7 @@ def _get_incremental_commits(self):
                 if commit.commit.message.startswith(f"Merge branch '{self._get_repo().default_branch}'"):
                     get_logger().info(f"Skipping merge commit {commit.commit.message}")
                     continue
-                self.unreviewed_files_set.update({file.filename: file for file in commit.files})
+                self.unreviewed_files_map.update({file.filename: file for file in commit.files})
         else:
             get_logger().info("No previous review found, will review the entire PR")
             self.incremental.is_incremental = False
@@ -194,8 +194,8 @@ def get_previous_review(self, *, full: bool, incremental: bool):
                 return self.comments[index]
 
     def get_files(self):
-        if self.incremental.is_incremental and self.unreviewed_files_set:
-            return self.unreviewed_files_set.values()
+        if self.incremental.is_incremental and self.unreviewed_files_map:
+            return self.unreviewed_files_map.values()
         try:
             git_files = context.get("git_files", None)
             if git_files:
@@ -296,10 +296,10 @@ def get_diff_files(self) -> list[FilePatchInfo]:
                     else:
                         new_file_content_str = self._get_pr_file_content(file, self.pr.head.sha)  # communication with GitHub
 
-                    if self.incremental.is_incremental and self.unreviewed_files_set:
+                    if self.incremental.is_incremental and self.unreviewed_files_map:
                         original_file_content_str = self._get_pr_file_content(file, self.incremental.last_seen_commit_sha)
                         patch = load_large_diff(file.filename, new_file_content_str, original_file_content_str)
-                        self.unreviewed_files_set[file.filename] = patch
+                        self.unreviewed_files_map[file.filename] = patch
                     else:
                         if avoid_load:
                             original_file_content_str = ""

pr_agent/tools/pr_reviewer.py

@@ -142,7 +142,7 @@ async def run(self) -> None:
             # ticket extraction if exists
             await extract_and_cache_pr_tickets(self.git_provider, self.vars)
 
-            if self.incremental.is_incremental and hasattr(self.git_provider, "unreviewed_files_set") and not self.git_provider.unreviewed_files_set:
+            if self.incremental.is_incremental and hasattr(self.git_provider, "unreviewed_files_map") and not self.git_provider.unreviewed_files_map:
                 get_logger().info(f"Incremental review is enabled for {self.pr_url} but there are no new files")
                 previous_review_url = ""
                 if hasattr(self.git_provider, "previous_review") and self.git_provider.previous_review is not None:

tests/unittest/test_azure_devops_incremental.py

@@ -127,9 +127,9 @@ def test_populates_commits_range_and_files(self):
         self.assertEqual(provider.incremental.first_new_commit.sha, "new1")
         self.assertEqual(provider.incremental.last_seen_commit.sha, "old1")
         self.assertEqual(provider.incremental.last_seen_commit_sha, "old1")
-        self.assertIn("/foo.py", provider.unreviewed_files_set)
-        self.assertIn("/bar.py", provider.unreviewed_files_set)
-        self.assertNotIn("/somedir", provider.unreviewed_files_set)
+        self.assertIn("/foo.py", provider.unreviewed_files_map)
+        self.assertIn("/bar.py", provider.unreviewed_files_map)
+        self.assertNotIn("/somedir", provider.unreviewed_files_map)
         self.assertEqual(prev.html_url, provider.get_comment_url(prev))
 
     def test_skips_merge_commits(self):