Merge pull request #5 from TheAngryByrd/disposable-stack

Disposable stack

Author: TheAngryByrd

.travis.yml

@@ -4,7 +4,6 @@ dist: xenial
 
 dotnet: 2.1.401
 mono:
-  - 5.14.0
   - latest # => "stable release"
   - alpha
   - beta
@@ -23,7 +22,6 @@ script:
 matrix:
   fast_finish: true
   allow_failures:
-    - mono: latest
     - mono: alpha
     - mono: beta
     - mono: weekly

.vscode/settings.json

@@ -0,0 +1,5 @@
+{
+    "workbench.colorCustomizations": {
+        "tab.unfocusedActiveBorder": "#fff0"
+    }
+}

src/FsLibLog/FsLibLog.fs

@@ -47,12 +47,23 @@ module Types =
 
     [<AutoOpen>]
     module Inner =
-        type DisposableList (disposables : IDisposable list) =
+        open System.Collections.Generic
+
+        type DisposableStack() =
+            let stack = Stack<IDisposable>()
+
             interface IDisposable with
                 member __.Dispose () =
-                    disposables |> List.iter(fun d -> try d.Dispose() with e -> printfn "%A" e)
+                    while stack.Count > 0 do
+                        stack.Pop().Dispose()
+
+            member __.Push (item : IDisposable) = stack.Push item
+            member __.Push (items : IDisposable list) = items |> List.iter stack.Push
 
-            static member Create (disposables : IDisposable list) = new DisposableList(disposables)
+            static member Create (items : IDisposable list) =
+                let ds = new DisposableStack()
+                ds.Push items
+                ds
 
         type ILog with
 
@@ -69,8 +80,8 @@ module Types =
                 use __ =
                     log.AdditionalNamedParameters
                     |> List.map(fun (key,value, destructure) -> logger.MappedContext key value destructure)
-                    |> List.rev // This reverse is important, it causes us to unwind as if you have multiple uses in a row
-                    |> DisposableList.Create
+                    // This stack is important, it causes us to unwind as if you have multiple uses in a row
+                    |> DisposableStack.Create
 
                 log.Parameters
                 |> List.toArray