Performance of coldTask and cancellableTask #2
TheAngryByrd
started this conversation in
Show and tell
Replies: 1 comment 1 reply
-
|
Biggest difference I see is that the before version of ManyWriteFile_coldTask has more local state and it ends up calling the 'dynamic' version of try/finally, whereas the after version of ManyWriteFile_coldTask takes a state machine as input and the implementation of the state machine is more unrolled. The 'after' version appears to be more correct to me - the generated code for a callsite constructs a packet with the state machine data and then sends that packet to the state machine processor. |
Beta Was this translation helpful? Give feedback.
1 reply
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
-
I've got benchmarks from FSharp.Core working on this codebase.
With function
fun () ->/fun ct ->at beginning of Run/Dynamic coldTask cancellableTaskWith function at beginning of Run/Dynamic
With function near end of Run/Dynamic
There's some considerable improvements here in speed and memory by moving
fun () ->/fun ct ->.However I am getting a warning:
Update: 2022/03/08
Beta Was this translation helpful? Give feedback.
All reactions