Re-enable F# analyzers in Library and Console templates (#310)

* Initial plan

* Add F# analyzers to Library and Console templates

Co-authored-by: TheAngryByrd <[email protected]>

* Update fsharp-analyzers tool to version 0.29.0 in templates

Co-authored-by: TheAngryByrd <[email protected]>

* Update analyzer packages to latest versions - fsharp-analyzers to 0.33.1, Ionide.Analyzers to 0.14.9, G-Research.FSharp.Analyzers to 0.12.1

Co-authored-by: TheAngryByrd <[email protected]>

* Correct G-Research.FSharp.Analyzers version from 0.12.1 to 0.19.0 (actual latest)

Co-authored-by: TheAngryByrd <[email protected]>

---------

Co-authored-by: copilot-swe-agent[bot] <[email protected]>
Co-authored-by: TheAngryByrd <[email protected]>

Author: Copilot

Content/Console/.config/dotnet-tools.json

@@ -9,7 +9,7 @@
       ]
     },
     "fsharp-analyzers": {
-      "version": " 0.10.1",
+      "version": "0.33.1",
       "commands": [
         "fsharp-analyzers"
       ]

Content/Console/Directory.Packages.props

@@ -40,5 +40,11 @@
     <PackageVersion Include="Fake.BuildServer.GitHubActions" Version="$(FakeVersion)" />
     <PackageVersion Include="MSBuild.StructuredLogger" Version="2.2.441" />
     <PackageVersion Include="System.Formats.Asn1" Version="6.0.1" />
+
+    <!-- Analyzers -->
+    <PackageVersion Include="FSharp.Analyzers.Build" Version="0.4.0" />
+    <PackageVersion Include="Ionide.Analyzers" Version="0.14.9" />
+    <PackageVersion Include="G-Research.FSharp.Analyzers" Version="0.19.0" />
+
   </ItemGroup>
 </Project>

Content/Console/src/Directory.Build.props

@@ -53,4 +53,12 @@
         <NuGetAuditLevel>low</NuGetAuditLevel>
         <NuGetAudit>true</NuGetAudit>
     </PropertyGroup>
+
+    <ItemGroup>
+        <!-- See Directory.Build.targets for FSharpAnalyzersOtherFlags -->
+        <PackageReference Include="FSharp.Analyzers.Build" PrivateAssets="All"/>
+        <PackageReference Include="Ionide.Analyzers" PrivateAssets="All"/>
+        <PackageReference Include="G-Research.FSharp.Analyzers" PrivateAssets="All"/>
+    </ItemGroup>
+
 </Project>

Content/Console/src/Directory.Build.targets

@@ -0,0 +1,7 @@
+<Project>
+   <PropertyGroup>
+        <RunAnalyzersDuringBuild>true</RunAnalyzersDuringBuild>
+        <FSharpAnalyzersOtherFlags>--analyzers-path "$(PkgG-Research_FSharp_Analyzers)/analyzers/dotnet/fs"</FSharpAnalyzersOtherFlags>
+        <FSharpAnalyzersOtherFlags>$(FSharpAnalyzersOtherFlags) --analyzers-path "$(PkgIonide_Analyzers)/analyzers/dotnet/fs"</FSharpAnalyzersOtherFlags>
+    </PropertyGroup>
+</Project>

Content/Library/.config/dotnet-tools.json

@@ -9,7 +9,7 @@
       ]
     },
     "fsharp-analyzers": {
-      "version": "0.11.0",
+      "version": "0.33.1",
       "commands": [
         "fsharp-analyzers"
       ]

Content/Library/Directory.Packages.props

@@ -40,5 +40,11 @@
     <PackageVersion Include="Fake.BuildServer.GitHubActions" Version="$(FakeVersion)" />
     <PackageVersion Include="MSBuild.StructuredLogger" Version="2.2.441" />
     <PackageVersion Include="Argu" Version="6.0" />
+
+    <!-- Analyzers -->
+    <PackageVersion Include="FSharp.Analyzers.Build" Version="0.4.0" />
+    <PackageVersion Include="Ionide.Analyzers" Version="0.14.9" />
+    <PackageVersion Include="G-Research.FSharp.Analyzers" Version="0.19.0" />
+
   </ItemGroup>
 </Project>

Content/Library/src/Directory.Build.props

@@ -65,4 +65,11 @@
         <NuGetAudit>true</NuGetAudit>
     </PropertyGroup>
 
+    <ItemGroup>
+        <!-- See Directory.Build.targets for FSharpAnalyzersOtherFlags -->
+        <PackageReference Include="FSharp.Analyzers.Build" PrivateAssets="All"/>
+        <PackageReference Include="Ionide.Analyzers" PrivateAssets="All"/>
+        <PackageReference Include="G-Research.FSharp.Analyzers" PrivateAssets="All"/>
+    </ItemGroup>
+
 </Project>

Content/Library/src/Directory.Build.targets

@@ -0,0 +1,7 @@
+<Project>
+   <PropertyGroup>
+        <RunAnalyzersDuringBuild>true</RunAnalyzersDuringBuild>
+        <FSharpAnalyzersOtherFlags>--analyzers-path "$(PkgG-Research_FSharp_Analyzers)/analyzers/dotnet/fs"</FSharpAnalyzersOtherFlags>
+        <FSharpAnalyzersOtherFlags>$(FSharpAnalyzersOtherFlags) --analyzers-path "$(PkgIonide_Analyzers)/analyzers/dotnet/fs"</FSharpAnalyzersOtherFlags>
+    </PropertyGroup>
+</Project>