Skip to content

Odd logic in InGameUI::Can_Selected_Objects_Non_Attack_Interact_With_Object #1069

Open
@xezon

Description

@xezon
bool InGameUI::Can_Selected_Objects_Non_Attack_Interact_With_Object(
    const Object *object_to_interact_with, SelectionRules rule)
{
    for (int i = ACTIONTYPE_ATTACK_OBJECT; i < NUM_ACTIONTYPES; i++) {
        if (i != ACTIONTYPE_ATTACK_OBJECT
            && Can_Selected_Objects_Do_Action(static_cast<ActionType>(i), object_to_interact_with, rule, false)) {
            return true;
        }
    }

    return false;
}

Can be rewritten as

bool InGameUI::Can_Selected_Objects_Non_Attack_Interact_With_Object(
    const Object *object_to_interact_with, SelectionRules rule)
{
    for (int i = ACTIONTYPE_ATTACK_OBJECT + 1; i < NUM_ACTIONTYPES; i++) {
        if (Can_Selected_Objects_Do_Action(static_cast<ActionType>(i), object_to_interact_with, rule, false)) {
            return true;
        }
    }

    return false;
}

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions