Skip to content

_SliderData is memset zero twice in Gadget_List_Box_Create_Scroll_Bar #1097

Open
@xezon

Description

@xezon

_SliderData is memset zero twice in Gadget_List_Box_Create_Scroll_Bar. It is not used between both invocations. The second memset can be removed.

void Gadget_List_Box_Create_Scroll_Bar(GameWindow *list_box)
{
    _ListboxData *data = static_cast<_ListboxData *>(list_box->Win_Get_User_Data());
    WinInstanceData instance_data;
    _SliderData slider_data;
    memset(&slider_data, 0, sizeof(slider_data));
    int status = list_box->Win_Get_Status();
    bool has_text = false;

...

    memset(&slider_data, 0, sizeof(slider_data));
    data->m_slider = g_theWindowManager->Go_Go_Gadget_Slider(list_box,
        status | WIN_STATUS_ENABLED | WIN_STATUS_ACTIVE,
        width - i3 - 2,
        top + i4 + 3,
        i3,
        bottom - 2 * i4 - 6,
        &instance_data,
        &slider_data,
        nullptr,
        true);
    data->m_scrollBar = true;
}

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions