chore: drop dead code/versions for older neoforge

sadly it's not possible to keep neoforge compat between 1.21.1-8 and 1.21.9+ due to huge  changes at the internals that are used to run the mod super early

Author: TheBossMagnus

gradle.properties

@@ -34,7 +34,7 @@ modmenu_version=16.0.0-rc.1
 
 # NeoForge
 neoforge_version=21.10.48-beta
-minecraft_version_range_neoforge=[1.21,)
+minecraft_version_range_neoforge=[1.21.9,)
 neoforge_loader_version_range=[4,)
 
 ## This is the version of minecraft that the 'common' project uses, you can find a list of all versions here

neoforge/src/main/java/io/github/thebossmagnus/mods/config_manager/neoforge/NeoPlatformHelper.java

@@ -10,22 +10,6 @@ public class NeoPlatformHelper implements IPlatformHelper {
 
     @Override
     public Path getGameDir() {
-        // Hacky reflection to keep everything in a single jar
-        // 1.21.9+: FMLLoader.getCurrent().getGameDir()
-        // older version: FMLLoader.getGamePath()
-        try {
-
-            Object loader = FMLLoader.class.getMethod("getCurrent").invoke(null);
-            return (Path) loader.getClass().getMethod("getGameDir").invoke(loader);
-        } catch (NoSuchMethodException e) {
-            // Fallback to the older method if new one doesn't exist
-            try {
-                return (Path) FMLLoader.class.getMethod("getGamePath").invoke(null);
-            } catch (ReflectiveOperationException ex) {
-                throw new RuntimeException("Unable to obtain game directory from FMLLoader", ex);
-            }
-        } catch (ReflectiveOperationException e) {
-            throw new RuntimeException("Unable to obtain game directory from FMLLoader", e);
-        }
+        return FMLLoader.getCurrent().getGameDir();
     }
 }

neoforge_coremod/build.gradle

@@ -80,7 +80,7 @@ sourceSets.main.resources { srcDir 'src/generated/resources' }
 
 unifiedPublishing {
     project {
-        gameVersions = ["1.21", "1.21.1", "1.21.2", "1.21.3", "1.21.4","1.21.5","1.21.6","1.21.7","1.21.8"]
+        gameVersions = ["1.21.9","1.21.10"]
         gameLoaders = ["neoforge"]
 
 

neoforge_coremod/src/main/java/io/github/thebossmagnus/mods/config_manager/core_mod/services/ConfigManagerDependencyLocator.java

@@ -63,27 +63,13 @@ public void scanMods(List<IModFile> loadedMods, IDiscoveryPipeline pipeline) {
             }
 
             // Use reflection to access the private loadModFileFrom method
-            Method loadModFileFromMethod = JarInJarDependencyLocator.class.getDeclaredMethod(
-                    "loadModFileFrom",
-                    IModFile.class,
-                    String.class,
-                    IDiscoveryPipeline.class,
-                    Map.class
-            );
+            Method loadModFileFromMethod = JarInJarDependencyLocator.class.getDeclaredMethod("loadModFileFrom", IModFile.class, String.class, IDiscoveryPipeline.class, Map.class);
             loadModFileFromMethod.setAccessible(true);
 
             // Create a raw HashMap since we can't access EmbeddedJarKey
-            @SuppressWarnings({"rawtypes"})
-            Map createdModFiles = new HashMap<>();
+            @SuppressWarnings({"rawtypes"}) Map createdModFiles = new HashMap<>();
 
-            @SuppressWarnings("unchecked")
-            Optional<IModFile> neoForgeMod = (Optional<IModFile>) loadModFileFromMethod.invoke(
-                    this,
-                    modFile,
-                    "META-INF/jarjar/config_manager-neoforge.jar",
-                    pipeline,
-                    createdModFiles
-            );
+            @SuppressWarnings("unchecked") Optional<IModFile> neoForgeMod = (Optional<IModFile>) loadModFileFromMethod.invoke(this, modFile, "META-INF/jarjar/config_manager-neoforge.jar", pipeline, createdModFiles);
 
             pipeline.addModFile(neoForgeMod.get());
         } catch (Exception e) {

neoforge_coremod/src/main/java/io/github/thebossmagnus/mods/config_manager/core_mod/services/ConfigManagerEarlyEntrypoint.java

@@ -22,24 +22,7 @@ public class ConfigManagerEarlyEntrypoint implements GraphicsBootstrapper {
 
 
     public ConfigManagerEarlyEntrypoint() {
-        Path gameDir;
-        // Hacky reflection to keep everything in a single jar
-        // 1.21.9+: FMLLoader.getCurrent().getGameDir()
-        // older version: FMLLoader.getGamePath()
-        try {
-
-            Object loader = FMLLoader.class.getMethod("getCurrent").invoke(null);
-            gameDir = (Path) loader.getClass().getMethod("getGameDir").invoke(loader);
-        } catch (NoSuchMethodException e) {
-            // Fallback to the older method if new one doesn't exist
-            try {
-                gameDir = (Path) FMLLoader.class.getMethod("getGamePath").invoke(null);
-            } catch (ReflectiveOperationException ex) {
-                throw new RuntimeException("Unable to obtain game directory from FMLLoader", ex);
-            }
-        } catch (ReflectiveOperationException e) {
-            throw new RuntimeException("Unable to obtain game directory from FMLLoader", e);
-        }
+        Path gameDir = FMLLoader.getCurrent().getGameDir();
         ConfigManagerStartup.run(gameDir);
 
     }