Roboschool Windows Crashes Upon Exit

[Akz47]

When I exit the simulations or press Ctrl-C at the command prompt, Windows always displays a crash alert and tries to initiate a Windows Error Reporting.

I checked the windows error log, and it appears to be associated with QT5 module:

Faulting application name: python.exe, version: 3.6.1150.1013, time stamp: 0x5914acba
Faulting module name: Qt5Gui.dll, version: 5.10.0.0, time stamp: 0x5a2ae6f3
Exception code: 0xc0000005
Fault offset: 0x0000000000078626
Faulting process id: 0x2328
Faulting application start time: 0x01d41a82f4c8335f
Faulting application path: K:\Anaconda3\python.exe
Faulting module path: L:\WINDOWS\SYSTEM32\Qt5Gui.dll
Report Id: f6d73881-e892-47c0-9a5e-e2417c547b15
Faulting package full name:
Faulting package-relative application ID:

I am using the following versions:

• Python 3.6.1
• Anaconda 4.4.0 (but I'm not running the scripts within an environment)
• Tensorflow 1.8.0
• OpenAI Gym 0.10.5
• Baselines 0.1.5
• Windows 10 Pro (build 1709)

I don't think it affects the operation of the simulation, but it's weird that it crashes each time.

Thanks!

[TheCrazyT]

Ok i must admit it has nothing to do with anaconda or the python version.
For some reason i do not get the window for the crash anymore, but i can clearly see the same fault offsets inside the windows event-history. (maybe i disabled the window once with some setting, i'm not shure)
Will try to investigate it.
All i know for now is that the cpp_household-library seems to execute the
_ZN14QOpenGLContext14currentContextEv-function (wich itself calls _ZNK14QOpenGLContext14extraFunctionsEv) wich seems to access an invalid offset.
My guess is a nullpointer because of free'd resources or something like that.

Edit:
Oh well i'm quite shure it crashes on locations like here:
https://github.com/TheCrazyT/roboschool/blob/master/roboschool/cpp-household/render-simple.cpp#L340

There are probably more than one line that uses QOpenGLContext::currentContext()->extraFunctions(), guess i will just add a check for a nullpointer on those locations.

[Akz47]

Thank you for promptly locating the code segments that caused the null pointer errors. What are the ExtraFunctions for, so they are not needed for rendering the simulations?

Meanwhile, I've entirely disable Windows Error Reporting and the crash dialog.

Below are the steps, in case anyone wishes to do so too:

• Launch Local Group Policy Editor
• Go to Administrative Templates > Windows Components > Windows Error Reporting
• Set "Disable Windows Error Reporting" to Enabled
• Set "Prevent display of the user interface for critical errors" to Enabled

So I will be oblivious to any crashes. :)

Please let me know if and when an updated version is available.

[TheCrazyT]

What are the ExtraFunctions for, so they are not needed for rendering the simulations?

They are needed, but by the time some destructors are called, the QOpenGLContext is already gone.
Thats a problem because QOpenGLContext::currentContext() would return no object anymore.

[TheCrazyT]

I think I fixed it, you can download it here: https://dl.bintray.com/thecrazyt/roboschool/0.5/
(basically you only need to download cpp_household.pyd and replace it)

[Akz47]

Thank you for your fantastic speedy fix, it works perfect now without any crash!

I've re-enabled Windows Error Reporting and double checked in the Event Log to confirm that no application errors are reported.

On a separate note, I'm having a little trouble executing the multiplayer samples demo_pong.py and demo_race1.py, which make use of os.mkfifo not available on Windows:

Traceback (most recent call last):
File "demo_pong.py", line 23, in
gameserver = roboschool.multiplayer.SharedMemoryServer(game, "pongdemo", want_test_window=True)
File "roboschool\multiplayer.py", line 257, in init
player_n=n)
File "roboschool\multiplayer.py", line 147, in init
os.mkfifo(self.sh_pipe_actready_filename)
AttributeError: module 'os' has no attribute 'mkfifo'

I tried searching around for a Windows version of this multiplayer.py but couldn't seem to find any. I saw some general (non-Roboschool) recommendations to replace os.mkfifo with os.pipe / pywin32 / ctypes, but I'm not too sure how exactly to go about doing that.

Line 147 in multiplayer.py is:

os.mkfifo(self.sh_pipe_actready_filename)

Could you please shed some light on how I can fix this for Windows execution?

Thank you once again for your kind assistance.

[TheCrazyT]

I tried os.pipe and failed ...
After that I tried win32pipe to use named pipes ... and failed again ...
Guess i can't fix it that easily, would take more time i guess.

[Akz47]

No worries, thank you very much for trying. I'll experiment with the other examples that do not require the pipes first.

[TheCrazyT]

Alright it seems to work now with the commit:
ecf5279
Although i'm trying to make the project work for both operating systems, i probably break the possibility to use the same project on linux.
I do not have enough time to test on both machines and since a new roboschool-version is planned it is not worth the effort to make it work on both systems i guess.

Well my solution is working, but probably can be improved.
Not shure wich demo's are still failing, tested my solution with the demo_pong.py .

Edit:
Not shure if it is an error but the animation seems to stop at frame 999.
Currently can't figure out if this happens intensionally or by a bug.
Strange thing is that i can't find any number in the source that limits to that frame.
All i know is that you get an error about a closed pipe ... wich is weird because the source currently never closes the pipe (except if the "server"/python stops)