Refactored tests

Author: Andrey Helldar

tests/Cases/LaravelTestCase.php

@@ -41,12 +41,6 @@ protected function deleteFiles(): void
 
     protected function copyEnv(): void
     {
-        $filename = $this->envSourceFilename();
-
-        copy(__DIR__ . '/../fixtures/' . $filename, base_path('.env'));
-    }
-
-    protected function envSourceFilename(): string
-    {
+        copy(__DIR__ . '/../fixtures/' . $this->fixture_source, base_path('.env'));
     }
 }

tests/Concerns/Files.php

@@ -4,16 +4,18 @@
 
 trait Files
 {
+    protected $fixture_expected = 'expected';
+
+    protected $fixture_source = 'source';
+
     protected function source(): string
     {
         return $this->fixtures('source');
     }
 
-    protected function expected(bool $config = false): string
+    protected function expected(): string
     {
-        $filename = $config ? 'expected-config' : 'expected';
-
-        return $this->fixtures($filename);
+        return $this->fixtures($this->fixture_expected);
     }
 
     protected function actual(): string

tests/Laravel/ConfigurableTest.php

@@ -7,20 +7,24 @@
 
 final class ConfigurableTest extends LaravelTestCase
 {
+    protected $fixture_expected = 'expected-config';
+
+    protected $fixture_source = 'source-config';
+
     public function testCommand()
     {
         $this->artisan('env:sync')->assertExitCode(0)->run();
 
         $this->assertFileExists(base_path('.env.example'));
-        $this->assertFileEquals($this->expected(true), base_path('.env.example'));
+        $this->assertFileEquals($this->expected(), base_path('.env.example'));
     }
 
     public function testCustomPath()
     {
         $this->artisan('env:sync', ['--path' => base_path()]);
 
         $this->assertFileExists(base_path('.env.example'));
-        $this->assertFileEquals($this->expected(true), base_path('.env.example'));
+        $this->assertFileEquals($this->expected(), base_path('.env.example'));
     }
 
     public function testCustomPathFailed()
@@ -30,11 +34,6 @@ public function testCustomPathFailed()
         $this->artisan('env:sync', ['--path' => base_path('foo')])->run();
     }
 
-    protected function envSourceFilename(): string
-    {
-        return 'source-config';
-    }
-
     protected function getEnvironmentSetUp($app)
     {
         /** @var \Illuminate\Config\Repository $config */

tests/Laravel/MainTest.php

@@ -29,9 +29,4 @@ public function testCustomPathFailed()
 
         $this->artisan('env:sync', ['--path' => base_path('foo')])->run();
     }
-
-    protected function envSourceFilename(): string
-    {
-        return 'source';
-    }
 }

tests/Other/ConfigurableTest.php

@@ -11,13 +11,17 @@
 
 final class ConfigurableTest extends OtherTestCase
 {
+    protected $fixture_expected = 'expected-config';
+
+    protected $fixture_source = 'source-config';
+
     public function testContent()
     {
         $service = $this->service();
 
         $service->from($this->source());
 
-        $this->assertStringEqualsFile($this->expected(true), $service->cleaned());
+        $this->assertStringEqualsFile($this->expected(), $service->cleaned());
     }
 
     public function testStoring()
@@ -30,7 +34,7 @@ public function testStoring()
         $service->store();
 
         $this->assertFileExists($this->actual());
-        $this->assertFileEquals($this->expected(true), $this->actual());
+        $this->assertFileEquals($this->expected(), $this->actual());
     }
 
     protected function service(): Syncer