Changing the location of temporary files to the system’s temporary directory

Author: andrey-helldar

composer.json

@@ -18,7 +18,8 @@
         "illuminate/database": "^11.0 || ^12.0",
         "illuminate/filesystem": "^11.0 || ^12.0",
         "illuminate/support": "^11.0 || ^12.0",
-        "laravel/prompts": ">=0.3.6"
+        "laravel/prompts": ">=0.3.6",
+        "spatie/temporary-directory": "^2.3"
     },
     "require-dev": {
         "dragon-code/codestyler": "^6.3",

src/Exceptions/OpenFeedException.php

@@ -5,13 +5,14 @@
 namespace DragonCode\LaravelFeed\Exceptions;
 
 use RuntimeException;
+use Throwable;
 
 // @codeCoverageIgnoreStart
 class OpenFeedException extends RuntimeException
 {
-    public function __construct(string $path)
+    public function __construct(string $path, Throwable $e)
     {
-        parent::__construct("Unable to open file for writing: [$path]");
+        parent::__construct("Unable to open file for writing: [$path]", previous: $e);
     }
 }
 // @codeCoverageIgnoreEnd

src/Exceptions/ResourceMetaException.php

@@ -0,0 +1,15 @@
+<?php
+
+declare(strict_types=1);
+
+namespace DragonCode\LaravelFeed\Exceptions;
+
+use Exception;
+
+class ResourceMetaException extends Exception
+{
+    public function __construct()
+    {
+        parent::__construct('Unable to get a link to the file from the resource.');
+    }
+}

src/Services/FilesystemService.php

@@ -5,40 +5,49 @@
 namespace DragonCode\LaravelFeed\Services;
 
 use DragonCode\LaravelFeed\Exceptions\OpenFeedException;
+use DragonCode\LaravelFeed\Exceptions\ResourceMetaException;
 use DragonCode\LaravelFeed\Exceptions\WriteFeedException;
 use Illuminate\Filesystem\Filesystem as File;
+use Illuminate\Support\Str;
+use RuntimeException;
+use Spatie\TemporaryDirectory\TemporaryDirectory;
+use Throwable;
 
 use function dirname;
 use function fclose;
 use function fopen;
 use function fwrite;
 use function is_resource;
+use function microtime;
+use function stream_get_meta_data;
 
 class FilesystemService
 {
     public function __construct(
         protected File $file,
+        protected TemporaryDirectory $directory,
     ) {}
 
     /**
      * @return resource
      */
-    public function open(string $path) // @pest-ignore-type
+    public function createDraft(string $filename) // @pest-ignore-type
     {
-        $path = $this->draft($path);
+        $temp = $this->draftPath($filename);
 
-        $this->ensureFileDelete($path);
-        $this->ensureDirectory($path);
+        try {
+            $resource = fopen($temp, 'ab');
 
-        $resource = fopen($path, 'ab');
+            if ($resource === false) {
+                // @codeCoverageIgnoreStart
+                throw new RuntimeException($temp);
+                // @codeCoverageIgnoreEnd
+            }
 
-        if ($resource === false) {
-            // @codeCoverageIgnoreStart
-            throw new OpenFeedException($path);
-            // @codeCoverageIgnoreEnd
+            return $resource;
+        } catch (Throwable $e) {
+            throw new OpenFeedException($temp, $e);
         }
-
-        return $resource;
     }
 
     /**
@@ -58,16 +67,21 @@ public function append($resource, string $content, string $path): void // @pest-
      */
     public function release($resource, string $path): void // @pest-ignore-type
     {
+        $temp = $this->getMetaPath($resource);
+
         $this->close($resource);
 
         if ($this->file->exists($path)) {
             $this->file->delete($path);
         }
 
-        $this->file->move(
-            $this->draft($path),
-            $path
+        $this->file->ensureDirectoryExists(
+            dirname($path)
         );
+
+        $this->file->move($temp, $path);
+
+        $this->cleanTemporaryDirectory($temp);
     }
 
     /**
@@ -84,20 +98,37 @@ public function close($resource): void // @pest-ignore-type
         fclose($resource);
     }
 
-    protected function ensureFileDelete(string $path): void
+    protected function cleanTemporaryDirectory(string $filename): void
     {
-        if ($this->file->exists($path)) {
-            $this->file->delete($path);
-        }
+        $this->file->deleteDirectory(
+            dirname($filename)
+        );
+    }
+
+    protected function draftPath(string $filename): string
+    {
+        return $this->directory
+            ->name($this->temporaryFilename($filename))
+            ->create()
+            ->path((string) microtime(true));
     }
 
-    protected function ensureDirectory(string $path): void
+    protected function temporaryFilename(string $filename): string
     {
-        $this->file->ensureDirectoryExists(dirname($path));
+        return Str::of($filename)
+            ->prepend('feeds_draft_')
+            ->append('_', microtime(true))
+            ->slug('_')
+            ->toString();
     }
 
-    protected function draft(string $path): string
+    /**
+     * @param  resource  $file
+     */
+    protected function getMetaPath($file): string
     {
-        return $path . '.draft';
+        $meta = stream_get_meta_data($file);
+
+        return $meta['uri'] ?? throw new ResourceMetaException;
     }
 }

src/Services/GeneratorService.php

@@ -34,8 +34,8 @@ public function feed(Feed $feed, ?OutputStyle $output = null): void
         try {
             $this->started($feed);
 
-            $file = $this->openFile(
-                $path = $feed->path()
+            $file = $this->createDraft(
+                $feed->filename()
             );
 
             $this->performHeader($file, $feed);
@@ -45,11 +45,11 @@ public function feed(Feed $feed, ?OutputStyle $output = null): void
             $this->performItem($file, $feed, $output);
             $this->performFooter($file, $feed);
 
-            $this->release($file, $path);
+            $this->release($file, $feed->path());
 
             $this->setLastActivity($feed);
 
-            $this->finished($feed, $path);
+            $this->finished($feed, $feed->path());
         } catch (Throwable $e) {
             throw new FeedGenerationException(get_class($feed), $e);
         }
@@ -142,9 +142,9 @@ protected function release($file, string $path): void // @pest-ignore-type
         $this->filesystem->release($file, $path);
     }
 
-    protected function openFile(string $path) // @pest-ignore-type
+    protected function createDraft(string $filename) // @pest-ignore-type
     {
-        return $this->filesystem->open($path);
+        return $this->filesystem->createDraft($filename);
     }
 
     protected function setLastActivity(Feed $feed): void