Added $skip_empty option to appendChild method

Andrey Helldar · web-flow · commit 78302c4db7d6 · 2019-03-28T18:50:08.000+03:00
diff --git a/src/Facades/Xml.php b/src/Facades/Xml.php
@@ -72,8 +72,12 @@ public function makeItem(string $name, $value = null, array $attributes = []): D
         return $element;
     }
 
-    public function appendChild(DOMElement &$parent, DOMElement $child)
+    public function appendChild(DOMElement &$parent, DOMElement $child, bool $skip_empty = true)
     {
+        if ($skip_empty && !$child) {
+            return;
+        }
+
         $node = $this->doc->importNode($child, true);
 
         $parent->appendChild($node);

Original file line number	Diff line number	Diff line change
`@@ -72,8 +72,12 @@ public function makeItem(string $name, $value = null, array $attributes = []): D`
`72`	`72`	`return $element;`
`73`	`73`	`}`
`74`	`74`
`75`		`- public function appendChild(DOMElement &$parent, DOMElement $child)`
	`75`	`+ public function appendChild(DOMElement &$parent, DOMElement $child, bool $skip_empty = true)`
`76`	`76`	`{`
	`77`	`+ if ($skip_empty && !$child) {`
	`78`	`+ return;`
	`79`	`+ }`
	`80`	`+`
`77`	`81`	`$node = $this->doc->importNode($child, true);`
`78`	`82`
`79`	`83`	`$parent->appendChild($node);`