Skip to content

Commit 5a707df

Browse files
Fix height of webview bug
1 parent d515f02 commit 5a707df

File tree

4 files changed

+12
-4
lines changed

4 files changed

+12
-4
lines changed

README.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -52,7 +52,7 @@ Easily reference the library in your Android projects using this dependency in y
5252

5353
```java
5454
dependencies {
55-
compile 'com.thefinestartist:finestwebview:1.1.4'
55+
compile 'com.thefinestartist:finestwebview:1.1.5'
5656
}
5757
```
5858

library/build.gradle

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@ android {
1414
minSdkVersion 7
1515
targetSdkVersion 23
1616
versionCode 1
17-
versionName "1.1.4"
17+
versionName "1.1.5"
1818
}
1919
}
2020

@@ -34,7 +34,7 @@ publish {
3434
userOrg = 'thefinestartist'
3535
groupId = 'com.thefinestartist'
3636
artifactId = 'finestwebview'
37-
publishVersion = '1.1.4'
37+
publishVersion = '1.1.5'
3838
desc = 'Beautiful and customizable Android Activity that shows web pages within an app.'
3939
website = 'https://github.com/TheFinestArtist/FinestWebView-Android'
4040
}

library/src/main/java/com/thefinestartist/finestwebview/FinestWebViewActivity.java

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -478,6 +478,14 @@ protected void layoutViews() {
478478
}
479479
progressBar.setLayoutParams(params);
480480
}
481+
482+
{ // WebLayout
483+
float toolbarHeight = getResources().getDimension(R.dimen.toolbarHeight);
484+
int screenHeight = ScreenHelper.getHeight(this);
485+
float webLayoutMinimumHeight = screenHeight - toolbarHeight;
486+
if (showDivider && !gradientDivider) webLayoutMinimumHeight -= dividerHeight;
487+
webLayout.setMinimumHeight((int) webLayoutMinimumHeight);
488+
}
481489
}
482490

483491
@SuppressLint("SetJavaScriptEnabled") protected void initializeViews() {

sample/build.gradle

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@ android {
99
minSdkVersion 7
1010
targetSdkVersion 23
1111
versionCode 9
12-
versionName "1.1.4"
12+
versionName "1.1.5"
1313
}
1414
buildTypes {
1515
release {

0 commit comments

Comments
 (0)