Skip to content

Commit dfa5380

Browse files
author
Justin Kirk
committed
#163 Fix segmented radio buttons height
1 parent b2cefa5 commit dfa5380

1 file changed

Lines changed: 11 additions & 3 deletions

File tree

form/src/main/java/com/thejuki/kformmaster/model/FormSegmentedElement.kt

Lines changed: 11 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -232,6 +232,7 @@ class FormSegmentedElement<T>(tag: Int = -1) : BaseFormElement<T>(tag) {
232232
it.removeAllViews()
233233

234234
options?.forEach { item ->
235+
var hasSeparateHeights = false
235236
val rb = LayoutInflater.from(it.context).inflate(R.layout.template_radiobutton_center, null) as RadioButtonCenter
236237
rb.text = item.toString()
237238
rb.id = ViewCompat.generateViewId()
@@ -272,6 +273,7 @@ class FormSegmentedElement<T>(tag: Int = -1) : BaseFormElement<T>(tag) {
272273
}
273274

274275
item.height?.let { height ->
276+
hasSeparateHeights = true
275277
rb.height = height.dpToPx()
276278
}
277279

@@ -281,9 +283,15 @@ class FormSegmentedElement<T>(tag: Int = -1) : BaseFormElement<T>(tag) {
281283
}
282284

283285
if (fillSpace) {
284-
it.addView(rb, RadioGroup.LayoutParams(RadioGroup.LayoutParams.MATCH_PARENT,
285-
RadioGroup.LayoutParams.WRAP_CONTENT,
286-
1.0f))
286+
if (hasSeparateHeights) {
287+
it.addView(rb, RadioGroup.LayoutParams(RadioGroup.LayoutParams.MATCH_PARENT,
288+
RadioGroup.LayoutParams.WRAP_CONTENT,
289+
1.0f))
290+
} else {
291+
it.addView(rb, RadioGroup.LayoutParams(RadioGroup.LayoutParams.MATCH_PARENT,
292+
RadioGroup.LayoutParams.MATCH_PARENT,
293+
1.0f))
294+
}
287295
} else {
288296
it.addView(rb)
289297
}

0 commit comments

Comments
 (0)