-
Notifications
You must be signed in to change notification settings - Fork 14.5k
Rails/Node: Installing PostgreSQL on MacOS using Postgres.app #29169
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Rails/Node: Installing PostgreSQL on MacOS using Postgres.app #29169
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Always love to see more lines removed than added, this simplifies things a lot. Nice work @crespire 💪
Just a minor suggestion with using a warning box - but I think this is good to go once thats in place.
|
||
#### 3.1 PostgreSQL roles | ||
Please note that that Postgres.app installs servers without any security configured, and will accept all local connections without a password. This is fine for our development environment, but be aware that when you move things to production, this will not be a good strategy. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit: Can we wrap this in a warning box - just to make sure it's harder to miss.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, @KevinMulhern ! I have additional changes to make re: peer authentication. I recall we want to stick with it, but add some notes to ensure that people are aware that's what is happening under the hood.
Should I also replicate these changes for the NodeJS path as well? I can do so in this PR as well.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh this is the node path file, so I'd have to replicate to the Rails path!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @crespire, feel free to send me a ping when you're happy for it to be reviewed
should I also replicate these changes for the NodeJS path as well? I can do so in this PR as well.
Yes please, these changes will be great on both paths!
Because
Postgres.app makes managing and installing PSQL and its associated tooling much easier on macOS, and lets us also change versions of PSQL easily.
This PR
This PR is in draft, as I have an outstanding question on the related issue about how we should set up local authentication.
Issue
Closes #29164
Additional Information
Pull Request Requirements
location of change: brief description of change
format, e.g.Intro to HTML and CSS lesson: Fix link text
Because
section summarizes the reason for this PRThis PR
section has a bullet point list describing the changes in this PRIssue
section