Skip to content

Commit 635c641

Browse files
authored
fix: handle EXISTS/NOT EXISTS subqueries in federation analyzer (spiceai#10996)
* fix: handle EXISTS/NOT EXISTS subqueries in federation analyzer * Update * Update * Update sha
1 parent fcd3943 commit 635c641

4 files changed

Lines changed: 5 additions & 10 deletions

File tree

Cargo.lock

Lines changed: 2 additions & 2 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

Cargo.toml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -169,7 +169,7 @@ datafusion-common-runtime = "52.0.0"
169169
datafusion-datasource = "52.0.0"
170170
datafusion-execution = "52.0.0"
171171
datafusion-expr = "52.0.0"
172-
datafusion-federation = { git = "https://github.com/spiceai/datafusion-federation.git", rev = "a4fce79433e5c2fe779427c0bfce6a599193e300", features = ["sql"] } # branch: trunk; SHA format (short vs full) must match to what datafusion-table-providers use for datafusion-federation
172+
datafusion-federation = { git = "https://github.com/spiceai/datafusion-federation.git", rev = "6b6bfb0d30da8e5c2eb851094e366d98fa839575", features = ["sql"] } # branch: trunk; SHA format (short vs full) must match to what datafusion-table-providers use for datafusion-federation
173173
datafusion-functions = "52.0.0"
174174
datafusion-functions-json = "0.52"
175175
datafusion-physical-expr = "52.0.0"
@@ -427,7 +427,7 @@ datafusion-physical-optimizer = { git = "https://github.com/spiceai/datafusion.g
427427
datafusion-spark = { git = "https://github.com/spiceai/datafusion.git", rev = "06e4b624c6073c40c7b2127ce620e281ec1979ae" } # spiceai-52.5
428428
datafusion-substrait = { git = "https://github.com/spiceai/datafusion.git", rev = "06e4b624c6073c40c7b2127ce620e281ec1979ae" } # spiceai-52.5
429429

430-
datafusion-table-providers = { git = "https://github.com/datafusion-contrib/datafusion-table-providers.git", rev = "29f66085875f1d4d7b80fc1947e68c6835302241" } # spiceai-52
430+
datafusion-table-providers = { git = "https://github.com/datafusion-contrib/datafusion-table-providers.git", rev = "466acff6af701872ba41de99c1783df2a288ddf8" } # spiceai-52
431431

432432
ballista-core = { git = "https://github.com/spiceai/datafusion-ballista.git", rev = "07be66a8efff7e20c2abadaaba6ef62b02fc1ffc" } # spiceai-52.5
433433
ballista-executor = { git = "https://github.com/spiceai/datafusion-ballista.git", rev = "07be66a8efff7e20c2abadaaba6ef62b02fc1ffc" } # spiceai-52.5

crates/test-framework/src/queries/mod.rs

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1049,10 +1049,8 @@ pub fn get_tpch_test_queries(overrides: Option<QueryOverrides>) -> Vec<Query> {
10491049
Some(QueryOverrides::Turso) => remove_tpch_query!(
10501050
queries,
10511051
2, // Correlated scalar subquery not supported; DF limitation, Turso tests are not cross-table federated
1052-
4, // Federation fails for cross-provider EXISTS subquery filters; https://github.com/spiceai/spiceai/issues/10167
10531052
17, // Correlated scalar subquery not supported
1054-
21, // Correlated scalar subquery not supported
1055-
22 // Federation fails for cross-provider EXISTS subquery filters; https://github.com/spiceai/spiceai/issues/10167
1053+
21 // Correlated scalar subquery not supported
10561054
),
10571055
Some(QueryOverrides::BigQuery) => {
10581056
let mut queries: Vec<Query> = remove_tpch_query!(

tools/testoperator/dispatch/tpch/sf1/accelerated/file[parquet]-cayenne[file]turso.yaml

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -2,17 +2,14 @@ tests:
22
bench:
33
spicepod_path: accelerated/file[parquet]-cayenne[file]turso.yaml
44
query_set: tpch
5-
query_overrides: turso
65
runner_type: spiceai-dev-runners
76
validate_results: true
87
throughput:
98
spicepod_path: accelerated/file[parquet]-cayenne[file]turso.yaml
109
query_set: tpch
11-
query_overrides: turso
1210
runner_type: spiceai-dev-large-runners
1311
load:
1412
spicepod_path: accelerated/file[parquet]-cayenne[file]turso.yaml
1513
query_set: tpch
16-
query_overrides: turso
1714
runner_type: spiceai-dev-large-runners
1815
duration: 28800

0 commit comments

Comments
 (0)