Skip to content

Commit 7cfb2de

Browse files
ci: switch integration_models from pull_request_target to pull_request (spiceai#9768)
pull_request_target runs in the base branch context with full secrets access and is unnecessary for this workflow which only builds and runs tests. Using pull_request is the correct trigger and provides defense in depth alongside the org-level fork PR approval requirement.
1 parent c0bdace commit 7cfb2de

1 file changed

Lines changed: 1 addition & 17 deletions

File tree

.github/workflows/integration_models.yml

Lines changed: 1 addition & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@ on:
66
branches:
77
- trunk
88
- release/*
9-
pull_request_target:
9+
pull_request:
1010
branches:
1111
- trunk
1212
- release-*
@@ -72,7 +72,6 @@ jobs:
7272
steps:
7373
- uses: actions/checkout@8e8c483db84b4bee98b60c0593521ed34d9990e8 # v6
7474
with:
75-
ref: ${{ github.event.pull_request.head.sha }}
7675
fetch-depth: 1 # Shallow clone for faster checkout
7776

7877
- name: Set up Rust
@@ -120,8 +119,6 @@ jobs:
120119
runs-on: 'spiceai-macos'
121120
steps:
122121
- uses: actions/checkout@8e8c483db84b4bee98b60c0593521ed34d9990e8 # v6
123-
with:
124-
ref: ${{ github.event.pull_request.head.sha }}
125122

126123
- name: Set up Rust
127124
uses: ./.github/actions/setup-rust
@@ -173,8 +170,6 @@ jobs:
173170
runs-on: 'spiceai-macos'
174171
steps:
175172
- uses: actions/checkout@8e8c483db84b4bee98b60c0593521ed34d9990e8 # v6
176-
with:
177-
ref: ${{ github.event.pull_request.head.sha }}
178173

179174
- name: Set up Rust
180175
uses: ./.github/actions/setup-rust
@@ -265,8 +260,6 @@ jobs:
265260
runs-on: 'spiceai-macos'
266261
steps:
267262
- uses: actions/checkout@8e8c483db84b4bee98b60c0593521ed34d9990e8 # v6
268-
with:
269-
ref: ${{ github.event.pull_request.head.sha }}
270263

271264
- name: Set up Rust
272265
uses: ./.github/actions/setup-rust
@@ -314,8 +307,6 @@ jobs:
314307
runs-on: 'spiceai-macos'
315308
steps:
316309
- uses: actions/checkout@8e8c483db84b4bee98b60c0593521ed34d9990e8 # v6
317-
with:
318-
ref: ${{ github.event.pull_request.head.sha }}
319310

320311
- name: Set up Rust
321312
uses: ./.github/actions/setup-rust
@@ -359,8 +350,6 @@ jobs:
359350
runs-on: 'spiceai-macos'
360351
steps:
361352
- uses: actions/checkout@8e8c483db84b4bee98b60c0593521ed34d9990e8 # v6
362-
with:
363-
ref: ${{ github.event.pull_request.head.sha }}
364353

365354
- name: Set up Rust
366355
uses: ./.github/actions/setup-rust
@@ -394,8 +383,6 @@ jobs:
394383
runs-on: 'spiceai-macos'
395384
steps:
396385
- uses: actions/checkout@8e8c483db84b4bee98b60c0593521ed34d9990e8 # v6
397-
with:
398-
ref: ${{ github.event.pull_request.head.sha }}
399386

400387
- name: Set up Rust
401388
uses: ./.github/actions/setup-rust
@@ -436,7 +423,6 @@ jobs:
436423
steps:
437424
- uses: actions/checkout@8e8c483db84b4bee98b60c0593521ed34d9990e8 # v6
438425
with:
439-
ref: ${{ github.event.pull_request.head.sha }}
440426
fetch-depth: 1 # Shallow clone for faster checkout
441427

442428
- name: Set up Rust
@@ -481,8 +467,6 @@ jobs:
481467
runs-on: 'spiceai-macos'
482468
steps:
483469
- uses: actions/checkout@8e8c483db84b4bee98b60c0593521ed34d9990e8 # v6
484-
with:
485-
ref: ${{ github.event.pull_request.head.sha }}
486470

487471
- name: Set up Rust
488472
uses: ./.github/actions/setup-rust

0 commit comments

Comments
 (0)