Skip to content

Commit 7e6def3

Browse files
krinartlukekim
andauthored
Add install-runtime-dev to Makefile (spiceai#10718)
* Add install-runtime-dev * Rename runtime->spiced in Makefile * Fix workflow --------- Co-authored-by: Luke Kim <80174+lukekim@users.noreply.github.com>
1 parent c4946a6 commit 7e6def3

2 files changed

Lines changed: 17 additions & 8 deletions

File tree

.github/workflows/pr.yml

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -294,7 +294,7 @@ jobs:
294294
path: ${{ runner.temp }}/spiceio.log
295295
if-no-files-found: ignore
296296

297-
# Release-profile installs (make install, install-cli, install-runtime)
297+
# Release-profile installs (make install, install-cli, install-spiced)
298298
build-install-release:
299299
name: Build (release profile)
300300
runs-on: spiceai-macos
@@ -360,14 +360,14 @@ jobs:
360360
AWS_SECRET_ACCESS_KEY: ${{ secrets.TEST_MINIO_SECRET_KEY }}
361361
run: make install-cli
362362

363-
- name: make install-runtime
363+
- name: make install-spiced
364364
if: needs.check_changes.outputs.relevant_changes == 'true'
365365
env:
366366
RUSTC_WRAPPER: ${{ env.RUSTC_WRAPPER }}
367367
RUST_PROFILE: release
368368
AWS_ACCESS_KEY_ID: ${{ secrets.TEST_MINIO_ACCESS_KEY }}
369369
AWS_SECRET_ACCESS_KEY: ${{ secrets.TEST_MINIO_SECRET_KEY }}
370-
run: make install-runtime
370+
run: make install-spiced
371371

372372
- name: Cancel workflow on failure
373373
if: failure()

Makefile

Lines changed: 14 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -12,16 +12,20 @@ build-cli:
1212
build-cli-dev:
1313
cargo build -p spice
1414

15-
.PHONY: build-runtime
16-
build-runtime:
15+
.PHONY: build-spiced
16+
build-spiced:
1717
make -C bin/spiced
1818

19+
.PHONY: build-spiced-dev
20+
build-spiced-dev:
21+
cargo build -p spiced
22+
1923
.PHONY: build-validator
2024
build-validator:
2125
cargo build --release -p spicepod-validator
2226

2327
.PHONY: build
24-
build: build-cli build-runtime
28+
build: build-cli build-spiced
2529

2630
.PHONY: build-dev
2731
build-dev:
@@ -367,8 +371,8 @@ install-cli: build-cli
367371
mkdir -p ~/.spice/bin
368372
install -m 755 $(TARGET_DIR)/release/spice ~/.spice/bin/spice
369373

370-
.PHONY: install-runtime
371-
install-runtime: build-runtime
374+
.PHONY: install-spiced
375+
install-spiced: build-spiced
372376
mkdir -p ~/.spice/bin
373377
install -m 755 $(TARGET_DIR)/release/spiced ~/.spice/bin/spiced
374378

@@ -377,6 +381,11 @@ install-cli-dev: build-cli-dev
377381
mkdir -p ~/.spice/bin
378382
install -m 755 $(TARGET_DIR)/debug/spice ~/.spice/bin/spice
379383

384+
.PHONY: install-spiced-dev
385+
install-spiced-dev: build-spiced-dev
386+
mkdir -p ~/.spice/bin
387+
install -m 755 $(TARGET_DIR)/debug/spiced ~/.spice/bin/spiced
388+
380389
################################################################################
381390
# Target: distributed #
382391
################################################################################

0 commit comments

Comments
 (0)