Upgrade Rust toolchain to 1.94.1 (spiceai#10353)

lukekim · web-flow · commit d5fbf30b1efc · 2026-04-17T18:36:26.000Z
* Upgrade Rust toolchain to 1.94.1

Bump workspace rust-version, rust-toolchain.toml channel, Dockerfiles,
and workflow rustup installs from 1.93.1 to 1.94.1. Updates the
agent/copilot instructions baseline accordingly.

* Add #[expect(clippy::result_large_err)] annotations to multiple TryFrom implementations and update println! to use saturating_sub
diff --git a/.github/copilot-instructions.md b/.github/copilot-instructions.md
@@ -53,9 +53,9 @@ cargo run -p testoperator -- run bench -p ./test/spicepods/tpch/sf1/federated/du
 
 ### Rust Version Baseline
 
-- **Workspace Rust version is 1.93.1**: Treat Rust 1.93.1 as the minimum supported compiler version for workspace code unless a specific crate or integration explicitly documents a different constraint.
-- **Use stable Rust features through 1.93.1**: Prefer stable language, standard library, and Cargo features available in Rust 1.93.1 when they improve correctness, clarity, ergonomics, or maintainability.
-- **Do not code to an older Rust subset by default**: Avoid workarounds for pre-1.93 compilers unless there is a concrete compatibility requirement.
+- **Workspace Rust version is 1.94.1**: Treat Rust 1.94.1 as the minimum supported compiler version for workspace code unless a specific crate or integration explicitly documents a different constraint.
+- **Use stable Rust features through 1.94.1**: Prefer stable language, standard library, and Cargo features available in Rust 1.94.1 when they improve correctness, clarity, ergonomics, or maintainability.
+- **Do not code to an older Rust subset by default**: Avoid workarounds for pre-1.94 compilers unless there is a concrete compatibility requirement.
 - **Prefer modern std APIs over manual patterns**: When a newer stable standard-library API expresses the intent more clearly or avoids extra allocation or unsafe code, use it.
 
 ### Error Handling (CRITICAL)
@@ -498,7 +498,7 @@ export PATH="$PATH:$HOME/.spice/bin"
 3. Spicepod is YAML config format
 4. Integration tests need credentials (`spice login` or `.env`)
 5. testoperator is the test harness
-6. Workspace uses Rust edition 2024 and rust-version 1.93.1; use stable Rust features available through 1.93.1 by default
+6. Workspace uses Rust edition 2024 and rust-version 1.94.1; use stable Rust features available through 1.94.1 by default
 7. New files should include copyright header. The current year is 2026. Required file types: `.rs`, `.go`
 8. **Spice runtime (Rust) is 64-bit minimum**: The runtime requires at least 64-bit pointer size. Do not add 32-bit compatibility code. Code should assume `usize` is at least 64 bits but not assume it's exactly 64 bits (future 128-bit support).
 
diff --git a/.github/workflows/generate-openapi.yml b/.github/workflows/generate-openapi.yml
@@ -38,9 +38,9 @@ jobs:
         env:
           GH_TOKEN: ${{ secrets.GITHUB_TOKEN }}
 
-      - name: Install Rust 1.93.1
+      - name: Install Rust 1.94.1
         if: steps.check_pr.outputs.skip != 'true'
-        run: rustup toolchain install 1.93.1 --profile minimal
+        run: rustup toolchain install 1.94.1 --profile minimal
 
       - name: Set up make
         if: runner.os != 'macOS' && steps.check_pr.outputs.skip != 'true'
diff --git a/.github/workflows/generate_acknowledgements.yml b/.github/workflows/generate_acknowledgements.yml
@@ -14,7 +14,7 @@ jobs:
     steps:
       - uses: actions/checkout@8e8c483db84b4bee98b60c0593521ed34d9990e8 # v6
 
-      - run: rustup toolchain install 1.93.1 --profile minimal
+      - run: rustup toolchain install 1.94.1 --profile minimal
 
       - name: Set up make
         if: runner.os != 'macOS'
diff --git a/.github/workflows/generate_json_schema.yml b/.github/workflows/generate_json_schema.yml
@@ -31,7 +31,7 @@ jobs:
     steps:
       - uses: actions/checkout@8e8c483db84b4bee98b60c0593521ed34d9990e8 # v6
 
-      - run: rustup toolchain install 1.93.1 --profile minimal
+      - run: rustup toolchain install 1.94.1 --profile minimal
 
       - name: Set up make
         if: runner.os != 'macOS' && (github.event_name != 'workflow_dispatch' || inputs.run_build)
diff --git a/.github/workflows/types_check.yml b/.github/workflows/types_check.yml
@@ -21,7 +21,7 @@ jobs:
       - name: Set REL_VERSION from version.txt
         run: python3 ./.github/scripts/get_release_version.py
 
-      - run: rustup toolchain install 1.93.1 --profile minimal
+      - run: rustup toolchain install 1.94.1 --profile minimal
 
       - uses: Swatinem/rust-cache@c19371144df3bb44fab255c43d04cbc2ab54d1c4 # v2
         with:
diff --git a/Cargo.toml b/Cargo.toml
@@ -84,7 +84,7 @@ exclude = [".github/"]
 homepage = "https://spice.ai"
 license = "Apache-2.0"
 repository = "https://github.com/spiceai/spiceai"
-rust-version = "1.93.1"
+rust-version = "1.94.1"
 version = "2.0.0-unstable"
 
 [workspace.dependencies]
diff --git a/Dockerfile b/Dockerfile
@@ -1,5 +1,5 @@
 #syntax=docker/dockerfile:1.2
-ARG RUST_VERSION=1.93.1
+ARG RUST_VERSION=1.94.1
 FROM rust:${RUST_VERSION}-slim-bookworm as build
 
 # cache mounts below may already exist and owned by root
diff --git a/Dockerfile-cuda b/Dockerfile-cuda
@@ -1,5 +1,5 @@
 #syntax=docker/dockerfile:1.2
-ARG RUST_VERSION=1.93.1
+ARG RUST_VERSION=1.94.1
 
 FROM nvidia/cuda:12.2.2-cudnn8-devel-ubuntu22.04 AS build
 
diff --git a/crates/data-connectors/connector-nfs/Cargo.toml b/crates/data-connectors/connector-nfs/Cargo.toml
@@ -4,7 +4,7 @@
 name = "connector-nfs"
 edition = "2024"
 version = "1.11.0-unstable"
-rust-version = "1.93.1"
+rust-version = "1.94.1"
 license = "Apache-2.0"
 description = "NFS data connector for Spice.ai runtime"
 
diff --git a/crates/datafusion-flightsql/Cargo.toml b/crates/datafusion-flightsql/Cargo.toml
@@ -2,7 +2,7 @@
 name = "datafusion-flightsql"
 version = "0.1.0"
 edition.workspace = true
-rust-version = "1.93.1"
+rust-version = "1.94.1"
 license = "Apache-2.0"
 description = "Arrow Flight SQL service backed by an arbitrary DataFusion SessionContext"
 
diff --git a/crates/libnfs/Cargo.toml b/crates/libnfs/Cargo.toml
@@ -4,7 +4,7 @@
 name = "libnfs"
 version = "0.1.0"
 edition = "2024"
-rust-version = "1.93.1"
+rust-version = "1.94.1"
 description = "Safe Rust bindings to libnfs C library for NFS client operations"
 license = "Apache-2.0"
 
diff --git a/crates/runtime/src/component/catalog.rs b/crates/runtime/src/component/catalog.rs
@@ -163,6 +163,7 @@ pub struct CatalogBuilder {
 impl TryFrom<spicepod_catalog::Catalog> for CatalogBuilder {
     type Error = crate::Error;
 
+    #[expect(clippy::result_large_err)]
     fn try_from(catalog: spicepod_catalog::Catalog) -> std::result::Result<Self, Self::Error> {
         let provider = Catalog::provider(&catalog.from);
         let catalog_id = Catalog::catalog_id(&catalog.from).map(String::from);
diff --git a/crates/runtime/src/component/dataset/acceleration.rs b/crates/runtime/src/component/dataset/acceleration.rs
@@ -354,6 +354,7 @@ impl Acceleration {
 impl TryFrom<spicepod_acceleration::Acceleration> for Acceleration {
     type Error = crate::Error;
 
+    #[expect(clippy::result_large_err)]
     fn try_from(
         acceleration: spicepod_acceleration::Acceleration,
     ) -> std::result::Result<Self, Self::Error> {
diff --git a/crates/runtime/src/init/catalog.rs b/crates/runtime/src/init/catalog.rs
@@ -107,6 +107,7 @@ impl Runtime {
         Ok(catalog_connector)
     }
 
+    #[expect(clippy::result_large_err)]
     fn catalogs_iter(
         self: Arc<Self>,
         app: &Arc<App>,
diff --git a/crates/runtime/src/init/dataset.rs b/crates/runtime/src/init/dataset.rs
@@ -225,6 +225,7 @@ impl Runtime {
             .collect()
     }
 
+    #[expect(clippy::result_large_err)]
     fn datasets_iter(self: Arc<Self>, app: &Arc<App>) -> impl Iterator<Item = Result<Dataset>> {
         app.datasets
             .clone()
diff --git a/crates/runtime/src/init/view.rs b/crates/runtime/src/init/view.rs
@@ -120,6 +120,7 @@ impl Runtime {
 
     /// Returns a list of valid views from the given App, with SQL validated and dependencies extracted.
     /// Skips any that fail to parse and logs an error for them.
+    #[expect(clippy::result_large_err)]
     pub(crate) fn get_valid_views(
         self: Arc<Self>,
         app: &Arc<App>,
diff --git a/crates/test-framework/src/spicetest/text_to_sql/mod.rs b/crates/test-framework/src/spicetest/text_to_sql/mod.rs
@@ -111,7 +111,7 @@ impl SpiceTest<NotStarted> {
                 if (0 == i || i > buffer_size) && i.is_multiple_of(5) {
                     println!(
                         "[TextToSqlWorkers]: Complete {}/{num_requests} requests",
-                        i.checked_sub(buffer_size).unwrap_or_default(),
+                        i.saturating_sub(buffer_size),
                     );
                 }
             }
diff --git a/rust-toolchain.toml b/rust-toolchain.toml
@@ -1,3 +1,3 @@
 [toolchain]
-channel = "1.93.1"
+channel = "1.94.1"
 components = ["rustc", "cargo", "rustfmt", "clippy"]
