add missing delete method to mixin,

add remove test inv_adapters

Author: TimoImhof

src/adapters/model_mixin.py

@@ -1255,6 +1255,18 @@ def add_adapter(self, adapter_name: str, config=None, overwrite_ok: bool = False
         else:
             self.base_model.add_adapter(adapter_name, config, overwrite_ok=overwrite_ok, set_active=set_active)
 
+    def delete_adapter(self, adapter_name: str):
+        """
+        Deletes the adapter with the specified name from the model.
+
+        Args:
+            adapter_name (str): The name of the adapter.
+        """
+        if self.base_model is self:
+            super().delete_adapter(adapter_name)
+        else:
+            self.base_model.delete_adapter(adapter_name)
+
     def train_adapter(self, adapter_setup: Union[list, AdapterCompositionBlock], train_embeddings=False):
         """
         Sets the model into mode for training the given adapters. If self.base_model is self, must inherit from a class

tests_adapters/methods/test_adapter_common.py

@@ -27,11 +27,14 @@
 
 @require_torch
 class BottleneckAdapterTestMixin(AdapterMethodBaseTestMixin):
-
     adapter_configs_to_test = [
         (PfeifferConfig(), ["adapters.{name}."]),
         (MAMConfig(), ["adapters.{name}.", "prefix_tunings.{name}."]),
     ]
+    inv_adapter_configs_to_test = [
+        (PfeifferInvConfig(), ["invertible_adapters.{name}"]),
+        (HoulsbyInvConfig(), ["invertible_adapters.{name}"]),
+    ]
 
     def test_add_adapter(self):
         model = self.get_model()
@@ -104,6 +107,40 @@ def forward_pre_hook(module, input):
                 # We expect one call to invertible adapter
                 self.assertEqual(1, calls)
 
+    def test_delete_adapter_with_invertible(self):
+        """Tests if the invertible adapters are deleted correctly."""
+        model = self.get_model().base_model
+        model.eval()
+        if not isinstance(model, InvertibleAdaptersMixin) and not isinstance(model, InvertibleAdaptersWrapperMixin):
+            self.skipTest("Model does not support invertible adapters.")
+
+        # iterate through all adapter invertible adapter configs
+        for adapter_config, filter_keys in self.inv_adapter_configs_to_test:
+            with self.subTest(model_class=model.__class__.__name__, config=adapter_config.__class__.__name__):
+                name = adapter_config.__class__.__name__
+                model.add_adapter(name, config=adapter_config)
+                model.set_active_adapters([name])
+
+                # check if adapter is correctly added to config
+                self.assert_adapter_available(model, name)
+                # remove the adapter again
+                model.delete_adapter(name)
+
+                # check if adapter is correctly removed from the model
+                self.assert_adapter_unavailable(model, name)
+
+                # check additionally if invertible adapter is removed correctly from the model
+                self.assertFalse(name in model.invertible_adapters)
+                self.assertEqual(None, model.get_invertible_adapter())
+
+                # check that weights are available and active
+                has_weights = False
+                filter_keys = [k.format(name=name) for k in filter_keys]
+                print(f"filter_keys = {filter_keys}")
+                for k, v in self.filter_parameters(model, filter_keys).items():
+                    has_weights = True
+                self.assertFalse(has_weights)
+
     def test_get_adapter(self):
         model = self.get_model()
         model.eval()