Add Fraction Math in Modula2 #4520
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Hey @bellxalli! Thanks for contributing to this project! We are a rather small team, so it may take some time to process this request. In the meantime, there are several ways you can make yourself a part of The Renegade Coder community. For instance, you can:
- Subscribe to the monthly newsletter
- Become a patron
- Join us on Discord
- And, check out the rest of the list which includes links to The Renegade Coder YouTube channel and Twitter account
Thanks for your help!
rzuckerm
requested changes
Feb 18, 2025
Comment on lines
+36
to
+46
| PROCEDURE Reduce(n, d : INTEGER); | ||
| BEGIN | ||
| IF d = 0 THEN | ||
| WriteString("error cannot divide by 0"); | ||
|
|
||
| ELSE | ||
| gcd := GreatestCommonDenominator(n, d); | ||
| numerator := n / gcd; | ||
| denominator := d / gcd; | ||
| END; | ||
| END Reduce; |
There was a problem hiding this comment.
Seems like this procedure is never used. There is a lot of code duplication where this could have been used. I'd recommend just making this part of SetFraction
| END; | ||
| END result; | ||
|
|
||
| BEGIN |
There was a problem hiding this comment.
Command line arguments are used for inputs, and stdout is used for outputs for all samples. Please see the project requirements for details.
rzuckerm
added
enhancement
|
Closed due to a month of inactivity |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Congrats on taking the first step to contributing to the Sample Programs repository maintained by The Renegade Coder!
For simplicity, please make sure that your pull request includes one and only one contribution.
Please fill one of the sections below as applicable.
Please also add any other relevant information to the Notes section at the bottom.
You may delete or just ignore any other sections.
For more information please refer to our contributing documentation
I Am Adding a New Code Snippet in an Existing Language
Add {PROJECT} in {LANGUAGE}format