feat(contracts): use bytes for badge descriptions

Author: V-Vaal

the-guild-smart-contracts/src/TheGuildBadgeRegistry.sol

@@ -8,14 +8,14 @@ contract TheGuildBadgeRegistry {
     /// @notice Representation of a badge.
     struct Badge {
         bytes32 name;
-        bytes32 description;
+        bytes description;
         address creator;
     }
 
     /// @notice Emitted when a new badge is created.
     event BadgeCreated(
         bytes32 indexed name,
-        bytes32 description,
+        bytes description,
         address indexed creator
     );
 
@@ -30,7 +30,7 @@ contract TheGuildBadgeRegistry {
     /// @notice Create a new badge with a unique name.
     /// @param name The unique badge name (bytes32).
     /// @param description The badge description (bytes32).
-    function createBadge(bytes32 name, bytes32 description) external {
+    function createBadge(bytes32 name, bytes calldata description) external {
         require(name != bytes32(0), "EMPTY_NAME");
         require(!nameExists[name], "DUPLICATE_NAME");
 
@@ -50,7 +50,7 @@ contract TheGuildBadgeRegistry {
     /// @dev Reverts if the badge does not exist.
     function getBadge(
         bytes32 name
-    ) external view returns (bytes32, bytes32, address) {
+    ) external view returns (bytes32, bytes memory, address) {
         require(nameExists[name], "NOT_FOUND");
         Badge memory b = nameToBadge[name];
         return (b.name, b.description, b.creator);
@@ -76,7 +76,7 @@ contract TheGuildBadgeRegistry {
     /// @dev Reverts if index is out of bounds.
     function getBadgeAt(
         uint256 index
-    ) external view returns (bytes32, bytes32, address) {
+    ) external view returns (bytes32, bytes memory, address) {
         bytes32 name = badgeNames[index];
         Badge memory b = nameToBadge[name];
         return (b.name, b.description, b.creator);

the-guild-smart-contracts/test/TheGuildBadgeRegistry.t.sol

@@ -13,7 +13,7 @@ contract TheGuildBadgeRegistryTest is Test {
 
     function test_CreateBadge_SucceedsAndEmitsEvent() public {
         bytes32 name = bytes32("BADGE_ALPHA");
-        bytes32 description = bytes32("First badge");
+        bytes memory description = bytes("First badge");
 
         vm.expectEmit(true, false, false, true);
         emit TheGuildBadgeRegistry.BadgeCreated(
@@ -24,7 +24,7 @@ contract TheGuildBadgeRegistryTest is Test {
 
         registry.createBadge(name, description);
 
-        (bytes32 rName, bytes32 rDesc, address creator) = registry.getBadge(
+        (bytes32 rName, bytes memory rDesc, address creator) = registry.getBadge(
             name
         );
         assertEq(rName, name, "name mismatch");
@@ -37,10 +37,10 @@ contract TheGuildBadgeRegistryTest is Test {
 
     function test_CreateBadge_RevertOnDuplicate() public {
         bytes32 name = bytes32("BADGE_DUP");
-        registry.createBadge(name, bytes32("desc"));
+        registry.createBadge(name, bytes("desc"));
 
         vm.expectRevert(bytes("DUPLICATE_NAME"));
-        registry.createBadge(name, bytes32("another"));
+        registry.createBadge(name, bytes("another"));
     }
 
     function test_GetBadge_RevertOnMissing() public {
@@ -50,23 +50,34 @@ contract TheGuildBadgeRegistryTest is Test {
 
     function test_CreateBadge_RevertOnEmptyName() public {
         vm.expectRevert(bytes("EMPTY_NAME"));
-        registry.createBadge(bytes32(0), bytes32("desc"));
+        registry.createBadge(bytes32(0), bytes("desc"));
     }
 
     function test_GetBadgeAt_ByIndex() public {
         bytes32 a = bytes32("BADGE_A");
         bytes32 b = bytes32("BADGE_B");
-        registry.createBadge(a, bytes32("descA"));
-        registry.createBadge(b, bytes32("descB"));
+        registry.createBadge(a, bytes("descA"));
+        registry.createBadge(b, bytes("descB"));
 
-        (bytes32 n0, bytes32 d0, address c0) = registry.getBadgeAt(0);
+        (bytes32 n0, bytes memory d0, address c0) = registry.getBadgeAt(0);
         assertEq(n0, a);
-        assertEq(d0, bytes32("descA"));
+        assertEq(keccak256(d0), keccak256(bytes("descA")));
         assertEq(c0, address(this));
 
-        (bytes32 n1, bytes32 d1, address c1) = registry.getBadgeAt(1);
+        (bytes32 n1, bytes memory d1, address c1) = registry.getBadgeAt(1);
         assertEq(n1, b);
-        assertEq(d1, bytes32("descB"));
+        assertEq(keccak256(d1), keccak256(bytes("descB")));
         assertEq(c1, address(this));
     }
+    function test_CreateBadge_AllowsLongDescription() public {
+    bytes32 name = bytes32("BADGE_LONG");
+    bytes memory longDesc = bytes(
+        "Long descriptions matter. Short buffers do not. This test proves it."
+    );
+
+    registry.createBadge(name, longDesc);
+
+    (, bytes memory rDesc,) = registry.getBadge(name);
+    assertEq(keccak256(rDesc), keccak256(longDesc), "long description mismatch");
+    }
 }