docs: document post-V2 cleanup for BadgeRegistry retro-compat

Author: V-Vaal

frontend/docs/V2_CLEANUP.md

@@ -0,0 +1,48 @@
+# BadgeRegistry V2 Cleanup Guide
+
+## Overview
+
+This document outlines the cleanup steps required after full V2 deployment of BadgeRegistry contracts. The current codebase includes retro-compatibility logic to support both V1 and V2 contracts during the migration period. Once all registries are upgraded to V2, this temporary code can be removed.
+
+## Files to Delete
+
+- `frontend/src/lib/utils/abiDetection.ts` - Error-based ABI detection utilities
+- `frontend/src/lib/badges/registryVersion.ts` - Version detection module
+
+## Functions / Logic to Remove
+
+- `detectBadgeRegistryVersion()` - Version detection function
+- `isDecodeError()` - Decode error detection utility
+- `isFunctionSelectorError()` - Function selector error detection utility
+- `buildCreateBadgeArgs()` - Conditional argument builder for V1/V2 differences
+- Any version-probe logic / error-based ABI inference
+
+## Hook Simplifications
+
+### use-create-badge.ts
+
+- Remove version detection and conditional ABI selection
+- Remove `detectBadgeRegistryVersion()` call
+- Always use `badgeRegistryAbiV2` (remove conditional `finalAbiMode === "v2" ? badgeRegistryAbiV2 : badgeRegistryAbiV1`)
+- Always use `bytes` description format: replace `buildCreateBadgeArgs()` with direct `stringToBytes(description)`
+- Remove `badgeRegistryAbiV1` import
+- Remove `detectBadgeRegistryVersion` import
+- Remove `buildCreateBadgeArgs` import
+
+### use-get-badges.ts
+
+- Remove version probing / `abiMode` inference
+- Remove `versionProbeQuery` query
+- Remove `abiMode` useMemo logic
+- Always use `badgeRegistryAbiV2` in `badgeContracts` (remove conditional ABI selection)
+- Always decode description as `bytes` using `bytesToString()` (remove conditional `bytesToString` vs `bytes32ToString`)
+- Remove `isDecodeError` import and usage
+- Remove `badgeRegistryAbiV1` import
+
+## Expected End State
+
+- Only V2 ABI (`badgeRegistryAbiV2`) used throughout the codebase
+- No fallback branches or conditional logic based on contract version
+- No error-based ABI detection or version probing
+- Simpler, more maintainable codebase with reduced complexity
+

frontend/src/hooks/badges/use-create-badge.ts

@@ -39,6 +39,7 @@ export function useCreateBadge() {
       });
       const currentCount = Number(totalBadgesResult ?? 0n);
 
+      // TODO(cleanup-after-v2): Remove V1 fallback logic after V2 full deployment. Always use V2 ABI. See docs/V2_CLEANUP.md.
       const finalAbiMode = await detectBadgeRegistryVersion(
         config,
         account as `0x${string}`,

frontend/src/hooks/badges/use-get-badges.ts

@@ -29,6 +29,7 @@ export function useGetBadges(): {
 
   const count = Number((totalBadgesQuery.data as bigint | undefined) ?? 0n);
 
+  // TODO(cleanup-after-v2): Remove V1 fallback logic after V2 full deployment. Always use V2 ABI. See docs/V2_CLEANUP.md.
   // TODO(cleanup): Remove version probe after V2 full deployment
   // Probe version with single getBadgeAt(0) call
   // This probe runs once per address and is cached forever

frontend/src/lib/badges/registryVersion.ts

@@ -1,3 +1,7 @@
+/**
+ * TODO(cleanup-after-v2): Remove this entire module after V2 full deployment. See docs/V2_CLEANUP.md for details.
+ */
+
 import type { Config } from "wagmi";
 import { simulateContract, readContract } from "@wagmi/core";
 import { BADGE_REGISTRY_ADDRESS } from "@/lib/constants/blockchainConstants";

frontend/src/lib/utils/abiDetection.ts

@@ -1,4 +1,6 @@
 /**
+ * TODO(cleanup-after-v2): Remove this entire module after V2 full deployment. See docs/V2_CLEANUP.md for details.
+ * 
  * ABI version detection utilities for BadgeRegistry contracts.
  * 
  * These functions detect contract version (V1 vs V2) by analyzing error messages