From d7670af3a3c965bb4e6b30b36d97ac7881902a7a Mon Sep 17 00:00:00 2001 From: OmniBlade Date: Thu, 24 Apr 2025 11:25:19 +0100 Subject: [PATCH] [GEN][ZH] Fixes "Box" particle systems. A break statement was in the wrong scope leading to hollow boxes behaving as though they were line systems. --- .../Code/GameEngine/Source/GameClient/System/ParticleSys.cpp | 2 +- .../Code/GameEngine/Source/GameClient/System/ParticleSys.cpp | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/Generals/Code/GameEngine/Source/GameClient/System/ParticleSys.cpp b/Generals/Code/GameEngine/Source/GameClient/System/ParticleSys.cpp index fd2c0b6cfb..511646901b 100644 --- a/Generals/Code/GameEngine/Source/GameClient/System/ParticleSys.cpp +++ b/Generals/Code/GameEngine/Source/GameClient/System/ParticleSys.cpp @@ -1737,8 +1737,8 @@ const Coord3D *ParticleSystem::computeParticlePosition( void ) newPos.x = GameClientRandomValueReal( -m_emissionVolume.box.halfSize.x, m_emissionVolume.box.halfSize.x ); newPos.y = GameClientRandomValueReal( -m_emissionVolume.box.halfSize.y, m_emissionVolume.box.halfSize.y ); newPos.z = GameClientRandomValueReal( -m_emissionVolume.box.halfSize.z, m_emissionVolume.box.halfSize.z ); - break; } + break; } case LINE: diff --git a/GeneralsMD/Code/GameEngine/Source/GameClient/System/ParticleSys.cpp b/GeneralsMD/Code/GameEngine/Source/GameClient/System/ParticleSys.cpp index 351cd79157..39a37db660 100644 --- a/GeneralsMD/Code/GameEngine/Source/GameClient/System/ParticleSys.cpp +++ b/GeneralsMD/Code/GameEngine/Source/GameClient/System/ParticleSys.cpp @@ -1637,8 +1637,8 @@ const Coord3D *ParticleSystem::computeParticlePosition( void ) newPos.x = GameClientRandomValueReal( -m_emissionVolume.box.halfSize.x, m_emissionVolume.box.halfSize.x ); newPos.y = GameClientRandomValueReal( -m_emissionVolume.box.halfSize.y, m_emissionVolume.box.halfSize.y ); newPos.z = GameClientRandomValueReal( -m_emissionVolume.box.halfSize.z, m_emissionVolume.box.halfSize.z ); - break; } + break; } case LINE: