Handle errors gracefully for non-critical data requests - #7693
Merged
Conversation
mjamescompton
approved these changes
Aug 18, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR is a followup of the incident we had during the weekend.
The console does a lot of requests on init, which are not crucial for it to work, so I have logged the errors and just marked the data as unavailable for the time-being, that way the console stays functional. For more important requests, like managed gateway or gateway stats this only happens if the request was aborted with a timeout.
Changes
Testing
Steps
mock an init request to time out and see that you are still able to log in to the console.
mock the gateway stats request to time out and observe the gateway status panel shows a message.
Results
Checklist
README.mdfor the chosen target branch.CHANGELOG.md.CONTRIBUTING.md, there are no fixup commits left.