Store and serve webhook template logos from this repository

[KrishnaIyer]

Summary

Store and serve webhook template logos from this repository.

Why do we need this?

Currently the webhook template repo includes links to logos. There are a couple of issues with this.

1. The image behind the link can be changed at anytime and there's no traceability.
2. Images are sometimes moved and the link is broken.

What is already there? What do you see now?

Logos are loaded from TTS using the link in logo-url.

What is missing? What do you want to see?

Logos loaded from the repo. This means that logos can only be updated on a new release but this is the same as updating a field in the yml.

How do you propose to implement this?

1. Add folders with the exact same name as the webhook template. Ex: akenza.yml -> akenza. If exists, TTS will ignore the value in logo-url.
2. Allow users to submit images with a similar constraint as https://github.com/TheThingsNetwork/lorawan-devices?tab=readme-ov-file#end-device-image
3. In TTS:
   a. Check if a folder corresponding to the template exists.
   b. If yes, check and validate the image in it.
   c. Load this image when the template is loaded.

@johanstokking; thoughts?

Can you do this yourself and submit a Pull Request?

Yes, maybe.

[FieldAppEngineerCombain]

I completely support this, we are not allowing hotlinking for Traxmate material so I'm not sure how I would get around this without allowing a local logo to be uploaded.

[johanstokking]

This is a good idea yes.

I think whatever we do here is relatively easy; reference a file. I think the challenging part is on TTS side where we need to bundle the repository data and serve the images as static content from TTS.

[KrishnaIyer]

So the console actually serves End device pictures directly from Github. ex

<img class="" src="https://raw.githubusercontent.com/TheThingsNetwork/lorawan-devices/master/vendor/mclimate/mc-button.png" name="Multipurpose Button">

We could maybe simplify this and set the logo-url to the corresponding file directly on Github.

[johanstokking]

We could maybe simplify this and set the logo-url to the corresponding file directly on Github.

You mean reference a local file here?

It looks like somewhere along the way we create this URL for use in the Console. I think though that GitHub doesn't mean this for serving static content. The cache duration is short (5 minutes) and a cold request fetches a file from the git tree.

But yes, that will probably work.

What we could also do is in GitHub Actions, sync all images to an S3 bucket with CloudFront with a domain name for static assets. We have that already I think. Then we change the URL in the aforementioned code to use that domain, and we're done?

[KrishnaIyer]

Yes that can also work indeed.