Skip to content

Commit 2116630

Browse files
committed
fix: review suggestions
1 parent 49fc56c commit 2116630

File tree

4 files changed

+4
-10
lines changed

4 files changed

+4
-10
lines changed

packages/diracx-web-components/src/components/DashboardLayout/DashboardDrawer.tsx

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -444,10 +444,7 @@ export default function DashboardDrawer({
444444
data-testid="add-application-button"
445445
>
446446
<ListItemIcon>{<Add />}</ListItemIcon>
447-
<ListItemText
448-
primary={"Add application"}
449-
data-testid={"AddApplicationButton"}
450-
/>
447+
<ListItemText primary={"Add application"} />
451448
</ListItemButton>
452449
</ListItem>
453450
<ListItem key={"Documentation"}>

packages/diracx-web/test/e2e/shareImportState.cy.ts renamed to packages/diracx-web/test/e2e/importExportState.cy.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -19,11 +19,11 @@ describe("Export and import app state", () => {
1919
cy.visit("/");
2020

2121
// Open 2 Job Monitor apps
22-
cy.get('[data-testid="AddApplicationButton"]').click();
22+
cy.get('[data-testid="add-application-button"]').click();
2323
cy.get('[data-testid="create-application-button"]')
2424
.contains("Job Monitor")
2525
.click();
26-
cy.get('[data-testid="AddApplicationButton"]').click();
26+
cy.get('[data-testid="add-application-button"]').click();
2727
cy.get('[data-testid="create-application-button"]')
2828
.contains("Job Monitor")
2929
.click();

packages/diracx-web/test/e2e/jobMonitor.cy.ts

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -83,8 +83,7 @@ describe("Job Monitor", () => {
8383
addJobs(55);
8484
} else {
8585
cy.log("Data available, checking if enough jobs are present");
86-
//pclhcb21:8000/__/#/specs
87-
https: checkAndAddJobs(55);
86+
checkAndAddJobs(55);
8887
}
8988
});
9089
});

packages/extensions/src/gubbins/DefaultUserDashboard.tsx

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,4 @@
11
import { DashboardGroup } from "@dirac-grid/diracx-web-components/types";
2-
import { BugReport } from "@mui/icons-material";
3-
import { applicationList } from "@/gubbins/ApplicationList";
42

53
// New default user sections
64
export const defaultSections: DashboardGroup[] = [

0 commit comments

Comments
 (0)