fix(fantawild): guard time parsing + short-cache empty schedules

Both Copilot comments on commit bfc9945:

- parseBusinessTime validates time strings via isValidHHMM() before
  feeding them to constructDateTime. A malformed entry now drops just
  that entry instead of throwing and aborting the whole sweep.
  hhmmToMinutes also rejects out-of-range hours/minutes (>24h, >59m)
  so '25:00' is treated as malformed rather than producing nonsense.

- scrapeSchedule @cache uses a dynamic TTL: 6h for a populated result,
  60s for an empty one. Stops a transient CDN/parse failure from
  freezing a fabricated zero-day schedule for hours. Mirrors the
  'cache only TRUE, never FALSE' pattern already established for
  derived boolean flags.

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>

Author: cubehouse

src/parks/fantawild/__tests__/fantawild.test.ts

@@ -181,6 +181,41 @@ describe('parseBusinessTime', () => {
     expect(out[0].closingTime).toBe('2026-07-01T02:00:00+08:00');
   });
 
+  test('skips entries with malformed startTime/endTime instead of throwing', () => {
+    // A garbage time string would otherwise blow up constructDateTime and abort
+    // the entire sweep. Make sure only the bad entry is dropped, the good one
+    // is still parsed.
+    const json: FantawildBusinessTimeResponse = {
+      key: 'k', value: [
+        // Bad: non-HH:MM startTime
+        {currentDate: '2026-06-21 00:00:00', startTime: 'morning', endTime: '18:00', isNight: false, isMorrow: false, nightStartTime: '', nightEndTime: '', activated: true, statusTips: '', parkCloseDesc: null, closeRemarkUrl: null, remarkUrl: null, stopIntoPark: ''},
+        // Bad: out-of-range hour
+        {currentDate: '2026-06-22 00:00:00', startTime: '25:00', endTime: '18:00', isNight: false, isMorrow: false, nightStartTime: '', nightEndTime: '', activated: true, statusTips: '', parkCloseDesc: null, closeRemarkUrl: null, remarkUrl: null, stopIntoPark: ''},
+        // Good: should still parse
+        {currentDate: '2026-06-23 00:00:00', startTime: '09:30', endTime: '18:00', isNight: false, isMorrow: false, nightStartTime: '', nightEndTime: '', activated: true, statusTips: '', parkCloseDesc: null, closeRemarkUrl: null, remarkUrl: null, stopIntoPark: ''},
+      ],
+    };
+    const out = parseBusinessTime(json, TZ);
+    expect(out).toHaveLength(1);
+    expect(out[0].date).toBe('2026-06-23');
+  });
+
+  test('skips night event with malformed nightStartTime but keeps the OPERATING entry', () => {
+    const json: FantawildBusinessTimeResponse = {
+      key: 'k', value: [{
+        currentDate: '2026-06-21 00:00:00',
+        startTime: '09:30', endTime: '21:00',
+        isNight: true, isMorrow: false,
+        nightStartTime: 'evening', nightEndTime: '23:00',
+        activated: true, statusTips: '',
+        parkCloseDesc: null, closeRemarkUrl: null, remarkUrl: null, stopIntoPark: '',
+      }],
+    };
+    const out = parseBusinessTime(json, TZ);
+    expect(out).toHaveLength(1);
+    expect(out[0].type).toBe('OPERATING');
+  });
+
   test('does NOT roll when closing time is strictly after opening', () => {
     const json: FantawildBusinessTimeResponse = {
       key: 'k', value: [{

src/parks/fantawild/fantawild.ts

@@ -151,7 +151,14 @@ export function isFantawildShow(item: FantawildItem): boolean {
 function hhmmToMinutes(t: string): number {
   const m = /^(\d{1,2}):(\d{2})$/.exec(t);
   if (!m) return NaN;
-  return Number(m[1]) * 60 + Number(m[2]);
+  const h = Number(m[1]); const min = Number(m[2]);
+  if (h > 24 || min > 59) return NaN;
+  return h * 60 + min;
+}
+
+/** Time string is parseable as "HH:MM". Avoids feeding garbage to constructDateTime. */
+function isValidHHMM(t: string): boolean {
+  return Number.isFinite(hhmmToMinutes(t));
 }
 
 /**
@@ -195,7 +202,9 @@ export function parseBusinessTime(
     // Date arrives as "YYYY-MM-DD HH:MM:SS" — take the YYYY-MM-DD prefix.
     const date = ev.currentDate?.split(' ')[0];
     if (!date || !/^\d{4}-\d{2}-\d{2}$/.test(date)) continue;
-    if (ev.startTime && ev.endTime) {
+    // Validate time strings BEFORE handing them to constructDateTime — a single
+    // malformed entry would otherwise throw and abort the whole sweep.
+    if (ev.startTime && ev.endTime && isValidHHMM(ev.startTime) && isValidHHMM(ev.endTime)) {
       const closeDate = closeDateAcrossMidnight(date, ev.startTime, ev.endTime);
       out.push({
         date,
@@ -204,7 +213,8 @@ export function parseBusinessTime(
         closingTime: constructDateTime(closeDate, ev.endTime, timezone),
       });
     }
-    if (ev.isNight && ev.nightStartTime && ev.nightEndTime) {
+    if (ev.isNight && ev.nightStartTime && ev.nightEndTime
+        && isValidHHMM(ev.nightStartTime) && isValidHHMM(ev.nightEndTime)) {
       const nightCloseDate = closeDateAcrossMidnight(date, ev.nightStartTime, ev.nightEndTime);
       out.push({
         date,
@@ -353,13 +363,13 @@ class Fantawild extends Destination {
    * fetch/parse failure so an outage on one park doesn't take out a multi-
    * park sweep.
    *
-   * Cached 6h — BusinessTime is a forward-looking calendar that almost
-   * never changes intra-day, so the short TTL was wasted parse work and
-   * extra CDN traffic across a 50-park sweep. `fetchBusinessTime()`'s own
-   * `@http` cache still gives a 15-min upstream-update floor for the rare
-   * case (closure pushed at short notice).
+   * Dynamic cache TTL: 6h for a populated result (BusinessTime is a
+   * forward-looking calendar that rarely changes intra-day, so a long TTL
+   * cuts wasted parse work and CDN traffic across a 50-park sweep);
+   * 60s if the result is empty — a transient CDN/parse failure shouldn't
+   * stick around as a fabricated zero-day schedule for hours.
    */
-  @cache({ttlSeconds: 60 * 60 * 6})
+  @cache({callback: (result: ScheduleEntry[]) => result.length === 0 ? 60 : 60 * 60 * 6})
   async scrapeSchedule(): Promise<ScheduleEntry[]> {
     try {
       const resp = await this.fetchBusinessTime();