Merge pull request #236 from TimBroddin/feat/plopsa-de-panne-locations

feat(plopsa): add per-POI coordinates for Plopsaland De Panne

Author: cubehouse

src/parks/plopsa/__tests__/plopsa.test.ts

@@ -8,7 +8,8 @@
  * disagrees between instances.
  */
 import {describe, test, expect} from 'vitest';
-import {plopsaDecideOperating} from '../plopsa.js';
+import type {Entity} from '@themeparks/typelib';
+import {plopsaDecideOperating, Plopsaland} from '../plopsa.js';
 
 describe('plopsaDecideOperating', () => {
   test('park closed → ride always CLOSED regardless of other inputs', () => {
@@ -36,3 +37,100 @@ describe('plopsaDecideOperating', () => {
     expect(plopsaDecideOperating(true, true, false)).toBe(false);
   });
 });
+
+describe('De Panne POI location wiring', () => {
+  const fallbackLocation = {latitude: 1, longitude: 2};
+
+  class Probe extends Plopsaland {
+    protected override mapCoordinates(
+      coords: {x: number; y: number} | undefined,
+    ): {latitude: number; longitude: number} | undefined {
+      return coords ? fallbackLocation : undefined;
+    }
+
+    public buildEntitiesForTest(): Promise<Entity[]> {
+      return this.buildEntityList();
+    }
+  }
+
+  function jsonResponse(payload: unknown) {
+    return {json: async () => payload};
+  }
+
+  function createProbe(poiItems: unknown[]): Probe {
+    const park = new Probe();
+    park.fetchPOI = async () => jsonResponse({items: poiItems}) as any;
+    park.fetchEntertainments = async () => jsonResponse({items: []}) as any;
+    return park;
+  }
+
+  test('populates attraction location from the bundled snapshot', async () => {
+    const entities = await createProbe([{
+      id: 'poi-1',
+      title: 'Attractions',
+      type: {label: 'Attractions'},
+      map_coordinates: {x: 10, y: 20},
+      contains: [{
+        id: 'anubis',
+        title: 'Anubis The Ride',
+        type: 'attraction',
+      }],
+    }]).buildEntitiesForTest();
+
+    const anubis = entities.find((e) => e.id === 'anubis');
+    expect(anubis?.location).toEqual({latitude: 51.081837, longitude: 2.597878});
+  });
+
+  test('prefers snapshot coordinates over mapped POI coordinates', async () => {
+    const entities = await createProbe([{
+      id: 'poi-1',
+      title: 'Attractions',
+      type: {label: 'Attractions'},
+      map_coordinates: {x: 10, y: 20},
+      contains: [{
+        id: 'anubis',
+        title: 'Anubis The Ride',
+        type: 'attraction',
+      }],
+    }]).buildEntitiesForTest();
+
+    const anubis = entities.find((e) => e.id === 'anubis');
+    expect(anubis?.location).toEqual({latitude: 51.081837, longitude: 2.597878});
+    expect(anubis?.location).not.toEqual(fallbackLocation);
+  });
+
+  test('matches snapshot titles with curly apostrophes through buildEntityList', async () => {
+    const entities = await createProbe([{
+      id: 'poi-1',
+      title: 'Attractions',
+      type: {label: 'Attractions'},
+      map_coordinates: {x: 10, y: 20},
+      contains: [{
+        id: 'vics',
+        title: 'Vic’s Whirlwind',
+        type: 'attraction',
+      }],
+    }]).buildEntitiesForTest();
+
+    const vics = entities.find((e) => e.id === 'vics');
+    expect(vics?.location).toEqual({latitude: 51.082082, longitude: 2.5958043});
+  });
+
+  test('skips POI children without a usable title', async () => {
+    const entities = await createProbe([{
+      id: 'poi-1',
+      title: 'Attractions',
+      type: {label: 'Attractions'},
+      map_coordinates: {x: 10, y: 20},
+      contains: [
+        {id: 'missing-title', type: 'attraction'},
+        {id: 'null-title', title: null, type: 'foods_and_drinks'},
+        {id: 'anubis', title: 'Anubis The Ride', type: 'attraction'},
+      ],
+    }]).buildEntitiesForTest();
+
+    expect(entities.find((e) => e.id === 'missing-title')).toBeUndefined();
+    expect(entities.find((e) => e.id === 'null-title')).toBeUndefined();
+    expect(entities.find((e) => e.id === 'anubis')).toBeDefined();
+  });
+});

src/parks/plopsa/locations/README.md

@@ -0,0 +1,46 @@
+# Plopsaland De Panne — POI location snapshot
+
+`plopsaland-de-panne.json` maps each POI **title** (exactly as the middleware
+feed emits it in `contains[].title`) to a hand-verified `{latitude, longitude}`.
+
+## Why a static snapshot
+
+The Plopsa middleware feed (`/api/points-of-interest`) exposes only
+`map_coordinates` — pixel coordinates on the park-map image — not lat/lng. De
+Panne, unlike Deutschland, has no pixel→geo transform (`mapCoordinates()`
+returns `undefined`), so without this snapshot its rides and restaurants have no
+location. The base class prefers this per-title lookup and falls back to the
+pixel transform (Deutschland only).
+
+## How the coordinates were derived
+
+1. **Titles** came from the live `points-of-interest` feed (attraction +
+   `foods_and_drinks` items).
+2. **Seed coordinates** came from Google Places (New) Text Search and the Apple
+   Maps Server API, biased to the park and filtered to an in-park bounding box.
+   Only name-verified matches were trusted; generic "Plopsaland Belgium" park
+   pins were rejected.
+3. **Manual pinning** — the remaining rides (kids' rides, food stalls that no
+   API indexes precisely) were placed by hand on a satellite basemap, cross-
+   referenced against the official parkplan. The website's own marker
+   coordinates (`point_x/point_y`, authored against `PLB_Parkplan2026_0.jpg` via
+   a Leaflet `imageOverlay`) were used as a visual reference.
+
+## Coverage / maintenance
+
+- 86 of 87 POIs are located. **Merry-go-Round** is intentionally absent — it is
+  not shown on the park map.
+- Matching folds curly/straight apostrophes and is case-insensitive
+  (`lookupPoiLocation` in `../plopsa.ts`).
+- POIs Plopsa adds later will land without a location until this file is
+  refreshed. To add one, append a `"<exact feed title>": {latitude, longitude}`
+  entry.
+
+## Regenerating / refreshing the snapshot
+
+This file was produced with the **[plopsa-pinning-tool](https://github.com/TimBroddin/plopsa-pinning-tool)**
+— a three-pane tool (ride list · Apple satellite map · official parkplan
+overlay) that seeds coordinates from Google Places + Apple Maps and lets you
+place the rest by hand. Use it to refresh this snapshot for a new season or to
+add newly-opened POIs, then copy its `data/plopsaland-de-panne.json` output
+here.